Merge pull request #2177 from nspcc-dev/fix-lint

Replace golint with revive

.circleci/config.yml

@@ -39,7 +39,7 @@ jobs:
       - run:
           name: go-lint
           command: |
-            curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.40.0
+            curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.42.1
             make lint
 
   test_1_15:

.golangci.yml

@@ -29,7 +29,7 @@ linters:
   enable:
     # mandatory linters
     - govet
-    - golint
+    - revive
 
     # some default golangci-lint linters
     - deadcode

pkg/core/blockchain.go

@@ -96,7 +96,7 @@ var (
 	ErrPolicy = errors.New("not allowed by policy")
 	// ErrInvalidBlockIndex is returned when trying to add block with index
 	// other than expected height of the blockchain.
-	ErrInvalidBlockIndex error = errors.New("invalid block index")
+	ErrInvalidBlockIndex = errors.New("invalid block index")
 	// ErrHasConflicts is returned when trying to add some transaction which
 	// conflicts with other transaction in the chain or pool according to
 	// Conflicts attribute.

pkg/core/native/native_neo.go

@@ -212,7 +212,7 @@ func (n *NEO) Initialize(ic *interop.Context) error {
 	}
 	n.mint(ic, h, big.NewInt(NEOTotalSupply), false)
 
-	var index uint32 = 0
+	var index uint32
 	value := big.NewInt(5 * GASFactor)
 	err = n.putGASRecord(ic.DAO, index, value)
 	if err != nil {