dstepanov-yadro/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

services: adjust RPC server's getHistoricParams

Browse source 
Update documentation and add index upper bound check to get rid of
CodeQL warning.
This commit is contained in:
Anna Shaleva 2022-10-07 16:06:12 +03:00
parent eac5e1526e
commit 735db08f84
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkg/services/rpcsrv/server.go
View file

@ -2002,8 +2002,8 @@ func (s *Server) getInvokeContractVerifyParams(reqParams params.Params) (util.Ui
return scriptHash, tx, invocationScript, nil return scriptHash, tx, invocationScript, nil
} }
// getHistoricParams checks that historic calls are supported and returns fake block // getHistoricParams checks that historic calls are supported and returns index of
// with the specified index to perform the historic call. It also checks that // a fake next block to perform the historic call. It also checks that
// specified stateroot is stored at the specified height for further request // specified stateroot is stored at the specified height for further request
// handling consistency. // handling consistency.
func (s *Server) getHistoricParams(reqParams params.Params) (uint32, *neorpc.Error) { func (s *Server) getHistoricParams(reqParams params.Params) (uint32, *neorpc.Error) {
@ -2030,6 +2030,9 @@ func (s *Server) getHistoricParams(reqParams params.Params) (uint32, *neorpc.Err
height = int(b.Index) height = int(b.Index)
} }
} }
if height > math.MaxUint32 {
return 0, neorpc.NewInvalidParamsError("historic height exceeds max uint32 value")
}
return uint32(height) + 1, nil return uint32(height) + 1, nil
} }