core: move benchmarks into bench_test.go

They share some functions and they're benchmarks, so let's have them here.

pkg/core/bench_test.go

@@ -2,6 +2,8 @@ package core_test
 
 import (
 	"fmt"
+	"math/big"
+	"path/filepath"
 	"testing"
 
 	"github.com/nspcc-dev/neo-go/internal/random"
@@ -10,12 +12,14 @@ import (
 	"github.com/nspcc-dev/neo-go/pkg/core/state"
 	"github.com/nspcc-dev/neo-go/pkg/core/storage"
 	"github.com/nspcc-dev/neo-go/pkg/core/transaction"
+	"github.com/nspcc-dev/neo-go/pkg/crypto/keys"
 	"github.com/nspcc-dev/neo-go/pkg/io"
 	"github.com/nspcc-dev/neo-go/pkg/neotest"
 	"github.com/nspcc-dev/neo-go/pkg/neotest/chain"
 	"github.com/nspcc-dev/neo-go/pkg/smartcontract/callflag"
 	"github.com/nspcc-dev/neo-go/pkg/vm/emit"
 	"github.com/nspcc-dev/neo-go/pkg/vm/opcode"
+	"github.com/nspcc-dev/neo-go/pkg/wallet"
 	"github.com/stretchr/testify/require"
 )
 
@@ -54,6 +58,27 @@ func BenchmarkBlockchain_ForEachNEP17Transfer(t *testing.B) {
 	}
 }
 
+func BenchmarkNEO_GetGASPerVote(t *testing.B) {
+	var stores = map[string]func(testing.TB) storage.Store{
+		"MemPS": func(t testing.TB) storage.Store {
+			return storage.NewMemoryStore()
+		},
+		"BoltPS":  newBoltStoreForTesting,
+		"LevelPS": newLevelDBForTesting,
+	}
+	for psName, newPS := range stores {
+		for nRewardRecords := 10; nRewardRecords <= 1000; nRewardRecords *= 10 {
+			for rewardDistance := 1; rewardDistance <= 1000; rewardDistance *= 10 {
+				t.Run(fmt.Sprintf("%s_%dRewardRecords_%dRewardDistance", psName, nRewardRecords, rewardDistance), func(t *testing.B) {
+					ps := newPS(t)
+					t.Cleanup(func() { ps.Close() })
+					benchmarkGasPerVote(t, ps, nRewardRecords, rewardDistance)
+				})
+			}
+		}
+	}
+}
+
 func benchmarkForEachNEP17Transfer(t *testing.B, ps storage.Store, startFromBlock, nBlocksToTake int) {
 	var (
 		chainHeight       = 2_100                            // constant chain height to be able to compare paging results
@@ -108,3 +133,90 @@ func benchmarkForEachNEP17Transfer(t *testing.B, ps storage.Store, startFromBloc
 	}
 	t.StopTimer()
 }
+
+func newLevelDBForTesting(t testing.TB) storage.Store {
+	dbPath := t.TempDir()
+	dbOptions := storage.LevelDBOptions{
+		DataDirectoryPath: dbPath,
+	}
+	newLevelStore, err := storage.NewLevelDBStore(dbOptions)
+	require.Nil(t, err, "NewLevelDBStore error")
+	return newLevelStore
+}
+
+func newBoltStoreForTesting(t testing.TB) storage.Store {
+	d := t.TempDir()
+	dbPath := filepath.Join(d, "test_bolt_db")
+	boltDBStore, err := storage.NewBoltDBStore(storage.BoltDBOptions{FilePath: dbPath})
+	require.NoError(t, err)
+	return boltDBStore
+}
+
+func benchmarkGasPerVote(t *testing.B, ps storage.Store, nRewardRecords int, rewardDistance int) {
+	bc, validators, committee := chain.NewMultiWithCustomConfigAndStore(t, nil, ps, true)
+	cfg := bc.GetConfig()
+
+	e := neotest.NewExecutor(t, bc, validators, committee)
+	neoHash := e.NativeHash(t, nativenames.Neo)
+	gasHash := e.NativeHash(t, nativenames.Gas)
+	neoSuperInvoker := e.NewInvoker(neoHash, validators, committee)
+	neoValidatorsInvoker := e.ValidatorInvoker(neoHash)
+	gasValidatorsInvoker := e.ValidatorInvoker(gasHash)
+
+	// Vote for new committee.
+	sz := len(cfg.StandbyCommittee)
+	voters := make([]*wallet.Account, sz)
+	candidates := make(keys.PublicKeys, sz)
+	txs := make([]*transaction.Transaction, 0, len(voters)*3)
+	for i := 0; i < sz; i++ {
+		priv, err := keys.NewPrivateKey()
+		require.NoError(t, err)
+		candidates[i] = priv.PublicKey()
+		voters[i], err = wallet.NewAccount()
+		require.NoError(t, err)
+		registerTx := neoSuperInvoker.PrepareInvoke(t, "registerCandidate", candidates[i].Bytes())
+		txs = append(txs, registerTx)
+
+		to := voters[i].Contract.ScriptHash()
+		transferNeoTx := neoValidatorsInvoker.PrepareInvoke(t, "transfer", e.Validator.ScriptHash(), to, big.NewInt(int64(sz-i)*1000000).Int64(), nil)
+		txs = append(txs, transferNeoTx)
+
+		transferGasTx := gasValidatorsInvoker.PrepareInvoke(t, "transfer", e.Validator.ScriptHash(), to, int64(1_000_000_000), nil)
+		txs = append(txs, transferGasTx)
+	}
+	e.AddNewBlock(t, txs...)
+	for _, tx := range txs {
+		e.CheckHalt(t, tx.Hash())
+	}
+	voteTxs := make([]*transaction.Transaction, 0, sz)
+	for i := 0; i < sz; i++ {
+		priv := voters[i].PrivateKey()
+		h := priv.GetScriptHash()
+		voteTx := e.NewTx(t, []neotest.Signer{neotest.NewSingleSigner(voters[i])}, neoHash, "vote", h, candidates[i].Bytes())
+		voteTxs = append(voteTxs, voteTx)
+	}
+	e.AddNewBlock(t, voteTxs...)
+	for _, tx := range voteTxs {
+		e.CheckHalt(t, tx.Hash())
+	}
+
+	// Collect set of nRewardRecords reward records for each voter.
+	e.GenerateNewBlocks(t, len(cfg.StandbyCommittee))
+
+	// Transfer some more NEO to first voter to update his balance height.
+	to := voters[0].Contract.ScriptHash()
+	neoValidatorsInvoker.Invoke(t, true, "transfer", e.Validator.ScriptHash(), to, int64(1), nil)
+
+	// Advance chain one more time to avoid same start/end rewarding bounds.
+	e.GenerateNewBlocks(t, rewardDistance)
+	end := bc.BlockHeight()
+
+	t.ResetTimer()
+	t.ReportAllocs()
+	t.StartTimer()
+	for i := 0; i < t.N; i++ {
+		_, err := bc.CalculateClaimable(to, end)
+		require.NoError(t, err)
+	}
+	t.StopTimer()
+}

pkg/core/native_neo_test.go

@@ -1,125 +0,0 @@
-package core_test
-
-import (
-	"fmt"
-	"math/big"
-	"path/filepath"
-	"testing"
-
-	"github.com/nspcc-dev/neo-go/pkg/core/native/nativenames"
-	"github.com/nspcc-dev/neo-go/pkg/core/storage"
-	"github.com/nspcc-dev/neo-go/pkg/core/transaction"
-	"github.com/nspcc-dev/neo-go/pkg/crypto/keys"
-	"github.com/nspcc-dev/neo-go/pkg/neotest"
-	"github.com/nspcc-dev/neo-go/pkg/neotest/chain"
-	"github.com/nspcc-dev/neo-go/pkg/wallet"
-	"github.com/stretchr/testify/require"
-)
-
-func BenchmarkNEO_GetGASPerVote(t *testing.B) {
-	var stores = map[string]func(testing.TB) storage.Store{
-		"MemPS": func(t testing.TB) storage.Store {
-			return storage.NewMemoryStore()
-		},
-		"BoltPS":  newBoltStoreForTesting,
-		"LevelPS": newLevelDBForTesting,
-	}
-	for psName, newPS := range stores {
-		for nRewardRecords := 10; nRewardRecords <= 1000; nRewardRecords *= 10 {
-			for rewardDistance := 1; rewardDistance <= 1000; rewardDistance *= 10 {
-				t.Run(fmt.Sprintf("%s_%dRewardRecords_%dRewardDistance", psName, nRewardRecords, rewardDistance), func(t *testing.B) {
-					ps := newPS(t)
-					t.Cleanup(func() { ps.Close() })
-					benchmarkGasPerVote(t, ps, nRewardRecords, rewardDistance)
-				})
-			}
-		}
-	}
-}
-
-func newLevelDBForTesting(t testing.TB) storage.Store {
-	dbPath := t.TempDir()
-	dbOptions := storage.LevelDBOptions{
-		DataDirectoryPath: dbPath,
-	}
-	newLevelStore, err := storage.NewLevelDBStore(dbOptions)
-	require.Nil(t, err, "NewLevelDBStore error")
-	return newLevelStore
-}
-
-func newBoltStoreForTesting(t testing.TB) storage.Store {
-	d := t.TempDir()
-	dbPath := filepath.Join(d, "test_bolt_db")
-	boltDBStore, err := storage.NewBoltDBStore(storage.BoltDBOptions{FilePath: dbPath})
-	require.NoError(t, err)
-	return boltDBStore
-}
-
-func benchmarkGasPerVote(t *testing.B, ps storage.Store, nRewardRecords int, rewardDistance int) {
-	bc, validators, committee := chain.NewMultiWithCustomConfigAndStore(t, nil, ps, true)
-	cfg := bc.GetConfig()
-
-	e := neotest.NewExecutor(t, bc, validators, committee)
-	neoHash := e.NativeHash(t, nativenames.Neo)
-	gasHash := e.NativeHash(t, nativenames.Gas)
-	neoSuperInvoker := e.NewInvoker(neoHash, validators, committee)
-	neoValidatorsInvoker := e.ValidatorInvoker(neoHash)
-	gasValidatorsInvoker := e.ValidatorInvoker(gasHash)
-
-	// Vote for new committee.
-	sz := len(cfg.StandbyCommittee)
-	voters := make([]*wallet.Account, sz)
-	candidates := make(keys.PublicKeys, sz)
-	txs := make([]*transaction.Transaction, 0, len(voters)*3)
-	for i := 0; i < sz; i++ {
-		priv, err := keys.NewPrivateKey()
-		require.NoError(t, err)
-		candidates[i] = priv.PublicKey()
-		voters[i], err = wallet.NewAccount()
-		require.NoError(t, err)
-		registerTx := neoSuperInvoker.PrepareInvoke(t, "registerCandidate", candidates[i].Bytes())
-		txs = append(txs, registerTx)
-
-		to := voters[i].Contract.ScriptHash()
-		transferNeoTx := neoValidatorsInvoker.PrepareInvoke(t, "transfer", e.Validator.ScriptHash(), to, big.NewInt(int64(sz-i)*1000000).Int64(), nil)
-		txs = append(txs, transferNeoTx)
-
-		transferGasTx := gasValidatorsInvoker.PrepareInvoke(t, "transfer", e.Validator.ScriptHash(), to, int64(1_000_000_000), nil)
-		txs = append(txs, transferGasTx)
-	}
-	e.AddNewBlock(t, txs...)
-	for _, tx := range txs {
-		e.CheckHalt(t, tx.Hash())
-	}
-	voteTxs := make([]*transaction.Transaction, 0, sz)
-	for i := 0; i < sz; i++ {
-		priv := voters[i].PrivateKey()
-		h := priv.GetScriptHash()
-		voteTx := e.NewTx(t, []neotest.Signer{neotest.NewSingleSigner(voters[i])}, neoHash, "vote", h, candidates[i].Bytes())
-		voteTxs = append(voteTxs, voteTx)
-	}
-	e.AddNewBlock(t, voteTxs...)
-	for _, tx := range voteTxs {
-		e.CheckHalt(t, tx.Hash())
-	}
-
-	// Collect set of nRewardRecords reward records for each voter.
-	e.GenerateNewBlocks(t, len(cfg.StandbyCommittee))
-
-	// Transfer some more NEO to first voter to update his balance height.
-	to := voters[0].Contract.ScriptHash()
-	neoValidatorsInvoker.Invoke(t, true, "transfer", e.Validator.ScriptHash(), to, int64(1), nil)
-
-	// Advance chain one more time to avoid same start/end rewarding bounds.
-	e.GenerateNewBlocks(t, rewardDistance)
-	end := bc.BlockHeight()
-
-	t.ResetTimer()
-	t.ReportAllocs()
-	t.StartTimer()
-	for i := 0; i < t.N; i++ {
-		_, err := bc.CalculateClaimable(to, end)
-		require.NoError(t, err)
-	}
-	t.StopTimer()
-}