dstepanov-yadro/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

network: remove wrong ping condition

Browse source 
In reality it will never be true exactly in the case where we want this ping
mechanism to work --- when the node failed to get a block from the net. It
won't get the header either and thus its block height will be equal to header
height. The only moment when this condition is met is when the node does
initial synchronization and this synchronization works just fine without any
pings.

Relates to #430.
This commit is contained in:
Roman Khimov 2020-01-20 17:19:35 +03:00
parent 247cfa4165
commit a8252ecc05
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pkg/network/tcp_peer.go
View file

@ -207,7 +207,7 @@ func (p *TCPPeer) StartProtocol() {
// Try to sync in headers and block with the peer if his block height is higher then ours. // Try to sync in headers and block with the peer if his block height is higher then ours.
if p.LastBlockIndex() > p.server.chain.BlockHeight() { if p.LastBlockIndex() > p.server.chain.BlockHeight() {
err = p.server.requestBlocks(p) err = p.server.requestBlocks(p)
} else if p.server.chain.HeaderHeight() >= p.LastBlockIndex() { } else {
block, errGetBlock := p.server.chain.GetBlock(p.server.chain.CurrentBlockHash()) block, errGetBlock := p.server.chain.GetBlock(p.server.chain.CurrentBlockHash())
if errGetBlock != nil { if errGetBlock != nil {
err = errGetBlock err = errGetBlock