crypto/keys: enforce length in PublicKey.DecodeBytes()

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>

pkg/crypto/keys/publickey.go

@@ -8,6 +8,7 @@ import (
 	"encoding/json"
 	"errors"
 	"fmt"
+	gio "io"
 	"math/big"
 
 	"github.com/btcsuite/btcd/btcec"
@@ -234,9 +235,17 @@ func decodeCompressedY(x *big.Int, ylsb uint, curve elliptic.Curve) (*big.Int, e
 func (p *PublicKey) DecodeBytes(data []byte) error {
 	b := io.NewBinReaderFromBuf(data)
 	p.DecodeBinary(b)
+	if b.Err != nil {
 		return b.Err
 	}
 
+	b.ReadB()
+	if b.Err != gio.EOF {
+		return errors.New("extra data")
+	}
+	return nil
+}
+
 // DecodeBinary decodes a PublicKey from the given BinReader using information
 // about the EC curve to decompress Y point. Secp256r1 is a default value for EC curve.
 func (p *PublicKey) DecodeBinary(r *io.BinReader) {
@@ -375,7 +384,7 @@ func (p *PublicKey) UnmarshalJSON(data []byte) error {
 		return errors.New("wrong format")
 	}
 
-	bytes := make([]byte, l-2)
+	bytes := make([]byte, hex.DecodedLen(l-2))
 	_, err := hex.Decode(bytes, data[1:l-1])
 	if err != nil {
 		return err

pkg/crypto/keys/publickey_test.go

@@ -67,6 +67,9 @@ func TestNewPublicKeyFromBytes(t *testing.T) {
 	pub2, err := NewPublicKeyFromBytes(b, elliptic.P256())
 	require.NoError(t, err)
 	require.Same(t, pub, pub2)
+
+	_, err = NewPublicKeyFromBytes([]byte{0x00, 0x01}, elliptic.P256())
+	require.Error(t, err)
 }
 
 func TestDecodeFromString(t *testing.T) {