dstepanov-yadro/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity

mempool: fix appending to sorted pools

Browse source 
Appending and not changing the real Items is utterly wrong.
This commit is contained in:
Roman Khimov 2020-02-05 00:07:05 +03:00
parent b9b77ac1be
commit f0e3a31bc8
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
pkg/core/mempool/mem_pool.go
View file

@ -116,7 +116,13 @@ func (mp *Pool) ContainsKey(hash util.Uint256) bool {
// TryAdd try to add the Item to the Pool. // TryAdd try to add the Item to the Pool.
func (mp *Pool) TryAdd(hash util.Uint256, pItem *Item) error { func (mp *Pool) TryAdd(hash util.Uint256, pItem *Item) error {
var pool Items var pool *Items
if pItem.fee.IsLowPriority(pItem.txn) {
pool = &mp.sortedLowPrioTxn
} else {
pool = &mp.sortedHighPrioTxn
}
mp.lock.Lock() mp.lock.Lock()
if !mp.verifyInputs(pItem.txn) { if !mp.verifyInputs(pItem.txn) {
@ -128,16 +134,8 @@ func (mp *Pool) TryAdd(hash util.Uint256, pItem *Item) error {
return ErrDup return ErrDup
} }
mp.unsortedTxn[hash] = pItem mp.unsortedTxn[hash] = pItem
mp.lock.Unlock()
if pItem.fee.IsLowPriority(pItem.txn) { *pool = append(*pool, pItem)
pool = mp.sortedLowPrioTxn
} else {
pool = mp.sortedHighPrioTxn
}
mp.lock.Lock()
pool = append(pool, pItem)
sort.Sort(pool) sort.Sort(pool)
mp.lock.Unlock() mp.lock.Unlock()