dstepanov-yadro/neoneo-go
1
0
Fork 0
forked from TrueCloudLab/neoneo-go
Code Pull requests Activity
5107 commits 35 branches 134 tags 34 MiB
Commit graph

5107 commits

This branch
This branch
All branches
Author SHA1 Message Date
Roman Khimov
2d993d0da5 state: store notary deposit as stackitem 
Which is less effective, but makes it more similar to other native contracts
that are supposed to be contracts anyway.
 2021-07-19 15:42:42 +03:00
Roman Khimov
70ddbf7180 native: reuse stackitem.(De)Serialize more for data structures 
Less code bloat, no functional changes.
 2021-07-19 15:42:42 +03:00
Roman Khimov
4775b513f9 native: do proper error handling when deserializing user data 2021-07-19 15:42:42 +03:00
Roman Khimov
fbe8bd2d9c stackitem: limit deserialized arrays/maps 
See neo-project/neo#2531, even though they use MaxStackSize there resulting
element is not valid unless it has <=MaxArraySize elements.
 2021-07-19 15:42:42 +03:00
Roman Khimov
654c4a6589 stackitem: properly pass allowInvalid on binary deserialization 
Otherwise DecodeBinaryProtected() is broken for arrays/maps.
 2021-07-19 15:42:41 +03:00
Roman Khimov
3a991abb62 fee: adjust SQRT price 
See neo-project/neo#2540.
 2021-07-19 15:42:41 +03:00
Roman Khimov
15be763bb3 vm: limit POW, fix #2060 
Calculating pow(pow(2, 255), 0xffffffff) takes unknown amount of time. See
also neo-project/neo-vm#422.
 2021-07-19 15:42:41 +03:00
Roman Khimov
5e26170b79
Merge pull request #2072 from nspcc-dev/address-as-account-in-rpc-params 
rpc/request: support passing accounts as addresses
 2021-07-19 10:09:15 +03:00
Roman Khimov
a617390185 rpc/request: support passing accounts as addresses 
Turns out, it's completely legal in C#, see neo-project/neo#2543.
 2021-07-18 16:45:53 +03:00
Roman Khimov
21e05f5779
Merge pull request #2055 from nspcc-dev/fix-gas-limits 
Tune fixed GAS limits
 2021-07-16 16:53:06 +03:00
Roman Khimov
24d89e4f86
Merge pull request #2061 from nspcc-dev/incremental-dumps 
Support incremental dumps
 2021-07-16 15:17:00 +03:00
Evgeniy Stratonikov
de15d42861 cli: remove --skip parameter from restore 
It isn't really a parameter and it's value can be deduced automatically.

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-16 13:32:08 +03:00
Evgeniy Stratonikov
df5ee4abdc cli: allow to use incremental dumps in db restore 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-16 13:32:08 +03:00
Roman Khimov
05cb6586a6
Merge pull request #2066 from nspcc-dev/block-nonce 
Add `System.Runtime.GetRandom`
 2021-07-15 19:02:48 +03:00
Evgeniy Stratonikov
85ce207f40 consensus: add Nonce to PrepareRequest 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-15 16:00:02 +03:00
Evgeniy Stratonikov
8077f9232d interop: implement System.Runtime.GetRandom 
Our murmur3 implementation is architecture independent and optimized in
assembly.

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-15 16:00:01 +03:00
Evgeniy Stratonikov
fdb54f2dc3 core/test: get rid of empty tx scripts 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-15 15:58:49 +03:00
Evgeniy Stratonikov
9c5b4e5916 encoding/bigint: allow to convert unsigned integers 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-15 15:58:49 +03:00
Evgeniy Stratonikov
3a4e0caeb8 core/block: add Nonce field to header 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-15 15:58:49 +03:00
Roman Khimov
d45b1b356c
Merge pull request #2068 from nspcc-dev/cn-instr 
docs: add more info about running a CN node on public networks
 2021-07-15 13:30:19 +03:00
Roman Khimov
51a975fc25 docs: add more info about running a CN node on public networks 
Fix #2065.
 2021-07-15 12:21:07 +03:00
Evgeniy Stratonikov
2cd5b63f0b policy: fix max exec fee 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-14 10:27:09 +03:00
Evgeniy Stratonikov
451b02122a *: increase GAS for verification 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-14 10:27:09 +03:00
Roman Khimov
2b7abd20e7
Merge pull request #2057 from nspcc-dev/optimize-storage-find 
Optimize `storageFind`
 2021-07-13 12:51:10 +03:00
Roman Khimov
83a557f0eb
Merge pull request #2042 from nspcc-dev/oracle-not-supported 
Check oracle response Content-Type header
 2021-07-13 11:31:37 +03:00
Roman Khimov
d638aee7a1
Merge pull request #2053 from nspcc-dev/stackitem-json 
Speedup stackitem json serialization
 2021-07-13 11:27:33 +03:00
Evgeniy Stratonikov
9b89e3f632 docs,config: add Oracle.AllowedContentTypes option 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-13 11:11:37 +03:00
Evgeniy Stratonikov
0611031fd4 stackitem/test: improve coverage for serialization 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-13 11:06:19 +03:00
Evgeniy Stratonikov
8fdc7e32f5 stackitem: cache serialized results in EncodeBinary 
```
name            old time/op    new time/op    delta
EncodeBinary-8    8.39ms ± 1%    0.05ms ±21%  -99.44%  (p=0.000 n=10+9)

name            old alloc/op   new alloc/op   delta
EncodeBinary-8    2.24MB ± 0%    0.33MB ± 0%  -85.29%  (p=0.000 n=9+10)

name            old allocs/op  new allocs/op  delta
EncodeBinary-8     65.6k ± 0%      0.0k ± 0%  -99.95%  (p=0.000 n=10+10)
```

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-13 11:06:19 +03:00
Evgeniy Stratonikov
17a3f17c74 stackitem: use byte-slice directly during encoding 
```
name            old time/op    new time/op    delta
EncodeBinary-8    10.6ms ± 1%     8.4ms ± 1%  -20.94%  (p=0.000 n=9+10)

name            old alloc/op   new alloc/op   delta
EncodeBinary-8    1.64MB ± 0%    2.24MB ± 0%  +36.18%  (p=0.000 n=8+9)

name            old allocs/op  new allocs/op  delta
EncodeBinary-8      131k ± 0%       66k ± 0%  -49.98%  (p=0.000 n=10+10)
```

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-13 11:06:18 +03:00
Roman Khimov
a0b062dc18
Merge pull request #2058 from nspcc-dev/extend-contributing 
CONTRIBUTING.md: add section for benchmarks
 2021-07-13 10:10:18 +03:00
Evgeniy Stratonikov
c4eb7db8a5 stackitem: access value of Array/Struct directly 
```
name      old time/op    new time/op    delta
ToJSON-8    50.3µs ±34%    47.8µs ± 9%     ~     (p=0.971 n=10+10)

name      old alloc/op   new alloc/op   delta
ToJSON-8     396kB ± 0%     396kB ± 0%   -0.10%  (p=0.000 n=6+10)

name      old allocs/op  new allocs/op  delta
ToJSON-8      34.0 ± 0%      18.0 ± 0%  -47.06%  (p=0.000 n=10+10)
```

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 14:40:21 +03:00
Evgeniy Stratonikov
dc0a17dd0e stackitem: cache visited items while marshaling json 
```
name      old time/op    new time/op    delta
ToJSON-8    4.52ms ± 4%    0.05ms ±34%  -98.89%  (p=0.000 n=8+10)

name      old alloc/op   new alloc/op   delta
ToJSON-8    2.13MB ± 0%    0.40MB ± 0%  -81.44%  (p=0.000 n=9+6)

name      old allocs/op  new allocs/op  delta
ToJSON-8     65.6k ± 0%      0.0k ± 0%  -99.95%  (p=0.000 n=10+10)
```

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 14:40:21 +03:00
Evgeniy Stratonikov
69cdd5252a stackitem: add benchmark for serialization routines 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 14:40:17 +03:00
Evgeniy Stratonikov
c32e63239e CONTRIBUTING.md: add section for benchmarks 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 14:34:38 +03:00
Evgeniy Stratonikov
eb7bd7b99b core: optimize storageFind 
Because `Map` stores elements in arbitrary order, addition of new
element takes linear time (`Index` iterates over all keys). Thus our
`storageFind` is actually quadratic in time. Optimize this by creating
map from sorted slice.

```
name           old time/op    new time/op    delta
StorageFind-8     157µs ± 2%     112µs ± 1%  -28.60%  (p=0.000 n=10+10)

name           old alloc/op   new alloc/op   delta
StorageFind-8    69.4kB ± 0%    60.5kB ± 0%  -12.90%  (p=0.000 n=9+10)

name           old allocs/op  new allocs/op  delta
StorageFind-8     2.21k ± 0%     2.00k ± 0%   -9.37%  (p=0.000 n=10+7)
```

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 14:22:17 +03:00
Evgeniy Stratonikov
b8b272c8c4 core/test: add benchmark for storageFind 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 14:20:45 +03:00
Evgeniy Stratonikov
0d5ede0bff core/test: use testing.TB in constructors 
This allows to use chain in benchmarks.

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 14:20:45 +03:00
Evgeniy Stratonikov
9f377cde12 storage: convert key once in MemoryStore.seek 
There is no need in additional allocations.

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 14:14:32 +03:00
Evgeniy Stratonikov
e936e5e295 oracle: set request Content-Type 
Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 13:13:48 +03:00
Evgeniy Stratonikov
8e9302f40b oracle: check response Content-Type 
If not specified everything is allowed.

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-12 13:13:48 +03:00
Roman Khimov
9de5c850e7
Merge pull request #2054 from nspcc-dev/fix-oom-on-struct-cloning 
Fix OOM on struct cloning
 2021-07-12 13:04:12 +03:00
Roman Khimov
fe3c68b92d vm: panic in cloneIfStruct 
It's internal, so we can deduplicate code a bit.
 2021-07-12 11:52:24 +03:00
Roman Khimov
bc5a1b7bcd
Merge pull request #2043 from nspcc-dev/runtime-getnetwork 
interop/runtime: add `System.Runtime.GetNetwork`, fix #2038
 2021-07-12 10:46:41 +03:00
Roman Khimov
4000dd692c vm: make cloning limits a bit more effective 
Take actual reference counter value into account.
 2021-07-11 19:37:06 +03:00
Roman Khimov
cfe41abd35 vm: fix OOM during nested structure cloning 
Resulting item can't have more than MaxStackSize elements. Technically this
limits to MaxStackSize cloned elements but it's considered to be enough to
mitigate the issue (the next size check is going to happen during push to the
stack). See neo-project/neo#2534, thanks @vang1ong7ang.
 2021-07-11 18:47:50 +03:00
Roman Khimov
1853d0c713 core: don't copy config in ApplyPolicyToTxSet 
Makes no sense, GetConfig() is for external users.
 2021-07-09 13:01:42 +03:00
Roman Khimov
701a3a728a CHANGELOG: release v0.95.4 2021-07-09 11:33:44 +03:00
Roman Khimov
fc83b34d02
Merge pull request #2052 from nspcc-dev/fix-state-276 
vm: copy integers for unary operations, fix #2051
 2021-07-08 17:30:02 +03:00
Evgeniy Stratonikov
1863023e27 vm: copy argument in unary opcodes, fix #2051 
We already do this in binary opcodes, let's be consistent.

This fixes state difference at height 275663
for tx 3c498317684d63849b03e4c58ad57ce4b19bb206b7b01bcc64233de3b3e207f4

Signed-off-by: Evgeniy Stratonikov <evgeniy@nspcc.ru>
 2021-07-08 17:09:04 +03:00