Dmitrii Stepanov dstepanov-yadro
  • Joined on 2023-03-06
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#12 2023-03-21 09:24:45 +00:00
Tracing

yes, it is the same. fixed.

dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-api-go 2023-03-21 09:24:29 +00:00
f48ba1dbff [#12] changelog: Add info about tracing
8081f9a7f9 [#12] tracing: Add gRPC middleware
Compare 2 commits »
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#12 2023-03-21 09:22:02 +00:00
Tracing

They set by propagator. Other clients must implement TextMapCarrier interface and use it with public propagator. For example, http-gw has TextMapCarrier implementation that reads/write…

dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#12 2023-03-21 09:18:19 +00:00
Tracing

Fixed

dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#12 2023-03-21 09:18:08 +00:00
Tracing

Fixed

dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-api-go 2023-03-21 09:17:38 +00:00
0cd07b17fa [#12] changelog: Add info about tracing
bc38cc9b7c [#12] tracing: Add gRPC middleware
8b41019c99 [#12] tracing: Add tracing package
Compare 3 commits »
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#12 2023-03-21 09:17:14 +00:00
Tracing

propagator implements OTEL's TextMapPropagator interface. It requires TextMapCarrier instance. So grpcMetadataCarrier implements TextMapCarrier interface.

dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#12 2023-03-21 09:01:40 +00:00
Tracing

It's our. Here is Open Telemetry semantic conventions: https://pkg.go.dev/go.opentelemetry.io/otel@v1.14.0/semconv/v1.14.0 The convention has http.target key and rpc.grpc.status_code. …

dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#12 2023-03-21 08:48:57 +00:00
Tracing

testify was updated with otel dependency:

go get go.opentelemetry.io/otel@v1.14.0
...
go: upgraded github.com/stretchr/testify v1.7.0 => v1.8.2
...

separate commit added.

dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-api-go 2023-03-21 08:48:41 +00:00
8c68c04fb1 [#12] changelog: Add info about tracing
aa185668c0 [#12] tracing: Add gRPC middleware
0a50e906c8 [#12] tracing: Add tracing package
f028cb7fe6 [#12] tracing: Add tracing dependencies
Compare 4 commits »
dstepanov-yadro pushed to bug/OBJECT-2279 at dstepanov-yadro/frostfs-node 2023-03-21 08:31:29 +00:00
7a31988a36 [#145] docs: Add expired object collector params
5059dcc19d [#145] shard-gc: Delete expired objects after locks
6c4a1699ef [#145] shard-gc: Expired locked unit test
9cd8f7cea0 [#152] IR: Process empty basic incomes
44b86bac5a [#148] linter: Add contextcheck linter
Compare 9 commits »
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#145 2023-03-21 08:24:25 +00:00
Simple object with lock and expiration time not removed after locks are expired
  1. source code looks simpler when variable initialization is near variable usage. getExpiredObjectsParameters() doesn't look hard to run.
  2. it will be easier to support sighup for gc…
dstepanov-yadro pushed to feat/linters at dstepanov-yadro/frostfs-node 2023-03-21 06:55:05 +00:00
44b86bac5a [#148] linter: Add contextcheck linter
481a1ca6f3 [#148] linter: Add gocognit linter
97c36ed3ec [#148] linter: Add funlen linter
Compare 3 commits »
dstepanov-yadro pushed to feat/linters at dstepanov-yadro/frostfs-node 2023-03-21 06:52:59 +00:00
50b92e2019 [#148] linter: Add contextcheck linter
bbb4d016c4 [#148] linter: Add gocognit linter
6f35878570 [#148] linter: Add funlen linter
cc8ff015b4 [#148] linter: Add containedctx linter
2dc86058c3 [#148] memstore: Drop space line
Compare 9 commits »
dstepanov-yadro pushed to bug/OBJECT-2279 at dstepanov-yadro/frostfs-node 2023-03-21 06:51:20 +00:00
0112da3974 [#145] docs: Add expired object collector params
dstepanov-yadro pushed to bug/OBJECT-2279 at dstepanov-yadro/frostfs-node 2023-03-21 06:44:20 +00:00
acf79b8425 [#145] shard-gc: Delete expired objects after locks
8cd02c17d4 [#145] shard-gc: Expired locked unit test
de1f815488 [#145] linter: Drop redundant space
573d920821 [#149] Use custom image and kludges for node
d64fb887ff [#149] Reorder pre-commit hooks
Compare 10 commits »
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#145 2023-03-20 15:26:29 +00:00
Simple object with lock and expiration time not removed after locks are expired

removerBatchSize is batch size for removing objects.

expiredCollectorBatchSize is batch size for marking objects expired.

These parameters relate to different processes. In the…

dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#145 2023-03-20 15:13:22 +00:00
Simple object with lock and expiration time not removed after locks are expired

If s.getExpiredObjects fails with an error then all other goroutines executing s.handleExpiredObjects will be cancelled by egCtx, and vice versa. It is possible to write code…