Dmitrii Stepanov dstepanov-yadro
  • Joined on 2023-03-06
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#135 2023-04-12 06:37:14 +00:00
Tracing for get object

Also, storage_id is not needed for FSTree.

fixed

dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-node 2023-04-12 06:37:01 +00:00
166ebbb51e [#135] signature: Add tracing
196885fa75 [#135] acl: Add tracing spans
ae3c3e11ac [#135] get-object: Add tracing spans
Compare 3 commits »
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#135 2023-04-12 06:33:26 +00:00
Tracing for get object

Can we create a custom attributes for this? Like zap.Stringer. When tracing is disabled it seems not worth doing this allocations.

WithAttributes receives KeyValue struct. `attributes.Str…

dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#135 2023-04-11 15:36:21 +00:00
Tracing for get object

@fyrchik @aarifullin @acid-ant added two commits for acl and signature spans

dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-node 2023-04-11 15:28:55 +00:00
bec75d45dc [#135] signature: Add tracing
a67ebe265e [#135] acl: Add tracing spans
Compare 2 commits »
dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-node 2023-04-11 15:22:52 +00:00
02ce8e2728 [#135] signature: Add tracing
dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-node 2023-04-11 15:05:26 +00:00
14493b352f [#135] acl: Add tracing spans
dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-node 2023-04-11 14:03:44 +00:00
ce7806f734 [#135] get-object: Add tracing spans
8e26556d3c [#135] tracing: Add tracing to node gRPC endpoints
c396668c78 [#135] node: Update api-go version
6bf11f7cca [#230] CHANGELOG.md: Remove older entries
Compare 4 commits »
dstepanov-yadro pushed to tracing_node at dstepanov-yadro/frostfs-dev-env 2023-04-11 13:32:02 +00:00
c7b4a8eb01 [#17] storage: Enable tracing
dstepanov-yadro created pull request TrueCloudLab/frostfs-dev-env#17 2023-04-11 13:31:09 +00:00
WIP: storage: Enable tracing
dstepanov-yadro created branch tracing_node in dstepanov-yadro/frostfs-dev-env 2023-04-11 12:45:56 +00:00
dstepanov-yadro pushed to tracing_node at dstepanov-yadro/frostfs-dev-env 2023-04-11 12:45:56 +00:00
dc95fbca3e [#9999] storage: Enable tracing
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#135 2023-04-11 12:14:46 +00:00
Tracing for get object

@aarifullin @fyrchik contextcheck linter violation for evacuate was fixed after review

dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-node 2023-04-11 12:13:51 +00:00
66970da98c [#135] get-object: Add tracing spans
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#135 2023-04-11 12:00:21 +00:00
Tracing for get object

Agree, fixed. I hope it wasn't the most important optimization.

dstepanov-yadro pushed to feat/OBJECT-3310 at dstepanov-yadro/frostfs-node 2023-04-11 11:59:25 +00:00
0f60ed02df [#135] get-object: Add tracing spans
5026aa0b68 [#135] tracing: Add tracing to node gRPC endpoints
Compare 2 commits »
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#135 2023-04-11 11:56:38 +00:00
Tracing for get object

It's about using context.Background() for shutting down. If e use the main context of the application, then it will already be canceled at this point.

dstepanov-yadro commented on pull request TrueCloudLab/frostfs-node#233 2023-04-11 11:53:05 +00:00
[#118] node: add unit concurrent tests for blobstor

to check the error from deletion because I check concurrent deletes

Yes, it's true. I'm talking about the fact that after deletion there should be no object exist. Maybe delete does not…