Dmitrii Stepanov dstepanov-yadro
  • Joined on 2023-03-06
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#8 2023-03-07 10:06:08 +00:00
Refactor sign/verify message

Fixed.

7f9809b7eb [#3] signature: Drop marshaller wrapper pool
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#8 2023-03-07 10:00:22 +00:00
Refactor sign/verify message

You are right. Fixed.

f2fb28bb38 [#3] signature: Drop buffer wrapper
dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#8 2023-03-07 08:36:02 +00:00
Refactor sign/verify message

Speaking of buffers pool, do we need a local benchmark for this?

There are two benchmarks already (sign and verify) that use pool.

dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#8 2023-03-07 08:34:03 +00:00
Refactor sign/verify message

Don't understand you. StableMarshalerWrapper is used to convert stableMarshaller interface to DataSource integface.

dstepanov-yadro commented on pull request TrueCloudLab/frostfs-api-go#8 2023-03-07 08:23:55 +00:00
Refactor sign/verify message

This makes easier to create new buffer here:

	if cap(result.buf) < size {
		result.buf = make([]byte, size)

It just creates a new slice in case of current capacity does not meet the…

dstepanov-yadro created pull request TrueCloudLab/frostfs-api-go#8 2023-03-07 07:35:08 +00:00
Refactor sign/verify message
af06ff25d2 [#3] signature: Use pool for buffers
bfd5ac6e14 [#3] signature: Use pool for wrappers
Compare 2 commits »
dstepanov-yadro created repository dstepanov-yadro/frostfs-api-go 2023-03-07 07:28:24 +00:00
dstepanov-yadro created repository dstepanov-yadro/frostfs-node 2023-03-07 06:16:07 +00:00