fyrchik/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Issues Pull requests Projects Releases Packages Wiki Activity
4773 commits 18 branches 26 tags 27 MiB
Commit graph

3135 commits

Author SHA1 Message Date
Evgenii Stratonikov
602ee11123 [#934] containersvc: Marhal public key in short format for APE 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-02-02 17:51:38 +00:00
Airat Arifullin
c1a5b831b6 [#955] chainbase: Fix rule chain unmarshalling 
* Use correct way DecodeBytes instead unmarshalling by json.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-02-02 20:28:04 +03:00
Anton Nikiforov
9916598dfb [#922] control: Extend api with ListOverrideDefinedTargets 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2024-02-02 12:09:51 +00:00
Anton Nikiforov
95e15f499f [#922] Update files generated by protoc 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2024-02-02 12:09:51 +00:00
Anton Nikiforov
2cb04379a4 [#922] go.mod: Update APE 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2024-02-02 12:09:51 +00:00
Airat Arifullin
a5446bc17d [#952] object: Pass namespace within context in ACL service 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-02-02 14:48:11 +03:00
Anton Nikiforov
d0eadf7ea2 [#799] engine: Skip put when object removed from shard 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2024-02-01 17:49:22 +00:00
Anton Nikiforov
6534252c22 [#799] policer: Refactor method processNodes 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2024-02-01 17:49:22 +00:00
Airat Arifullin
5be2af881a [#934] container: Make container APE middleware read namespaces 
* Those methods that can access already existing containers and thus
  can get container properties should read namespace from Zone
  property. If Zone is not set, take a namespace for root.
* Otherwise, define namespaces by owner ID via frostfs-id contract.
* Improve unit-tests, consider more cases.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-02-01 17:38:24 +00:00
Airat Arifullin
4352bd0e8e [#934] ape: Transform empty namespace within chainbase 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-02-01 17:38:24 +00:00
Anton Nikiforov
483a67b170 [#937] ape: Validate chain resource name 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2024-01-31 11:34:35 +03:00
Anton Nikiforov
e3573de6db [#930] gc: Stop internal activity by context 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2024-01-31 08:30:34 +00:00
Anton Nikiforov
c441296592 [#930] policer: Release task pool when context cancelled 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2024-01-31 08:30:34 +00:00
Dmitrii Stepanov
675eec91f3 [#938] shard: Update only changed counters 
If metric value hasn't changed, but we update metric, then
non existed metric will apear with zero value.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-30 12:37:48 +03:00
Dmitrii Stepanov
c681354afd [#938] engine: Fix container count removal 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-30 12:37:48 +03:00
Evgenii Stratonikov
df055fead5 [#931] morph: Provide batch size for container listing explicitly 
Besides VM stack item limit we also have restrictions on the size of
JSON for a stackitem, which is 128k. This limit is much harder to
calculate, because JSON representation includes type and the encoding is
different for different items. Thus is makes no sense to invent our own
default, so use the one provided by neo-go. But for container listing we
know exactly what we process, so use big enough value, which is tested.

Introduced in be8607a1f6.

Refs #902
Refs https://github.com/nspcc-dev/neo-go/blob/v0.105.0/pkg/vm/stackitem/json.go#L353

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-01-29 14:00:11 +00:00
Evgenii Stratonikov
6e2cc32768 [#681] objsvc: Validate session token owner for local sessions 
Previously, the check was in place only when session token was missing.
Format validator checks are applied only to fully-prepared object, so
this lead to the following situation:
1. Object is put locally with malformed token, because there are no
   checks.
2. Object cannot be replicated, because the token is malformed.

This is now fixed and token check is done before any payload receival.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-01-26 08:52:29 +00:00
Anton Nikiforov
b6fc3321c5 [#876] Fix linters 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2024-01-25 20:26:13 +03:00
Airat Arifullin
1fe7736d92 [#925] morph: Introduce switch rpc guarded rpc actor 
* Introduce switch rpc guarded rpc actor in morph client
  to prevent using invalidated rpc actor when RPC switch
  happens.
* Initialize NewContractStorage with SwitchRPCGuardedActor.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-01-25 13:24:13 +00:00
Dmitrii Stepanov
5ed330e436 [#927] metabase: Delete GC marks 
`key` is changed inside `db.get`, so encode address again after get.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-24 18:51:16 +03:00
Dmitrii Stepanov
931a5e9aaf [#918] engine: Move shard to degraded mode if metabase open failed 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-23 11:16:40 +03:00
Airat Arifullin
f2f3294fc3 [#919] ape: Improve error messages in ape service 
* Wrap all APE middleware errors in apeErr that
  makes errors more explicit with status AccessDenied.
* Use denyingRuleErr for denying status from chain router.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-01-23 08:11:24 +00:00
Dmitrii Stepanov
f526f49995 [#874] engine: Check object existance concurrently 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-23 09:28:29 +03:00
Dmitrii Stepanov
f5160b27fc [#920] tests: Fix data races 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-19 14:06:05 +03:00
Airat Arifullin
be33070550 [#910] control: Take empty namespace for 'root' 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-01-19 06:22:10 +00:00
Dmitrii Stepanov
63d3ed1ad8 [#904] tests: Close test engine after test 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-17 19:04:39 +03:00
Dmitrii Stepanov
57171907e3 [#904] metabase: Return if object was actuall inserted 
This requires to count metrics properly.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-17 19:04:39 +03:00
Dmitrii Stepanov
c1a80235db [#904] metabase: Log Inhume operation 
It will be very useful for troubleshooting.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-17 18:42:52 +03:00
Airat Arifullin
96b020626f [#915] ape: Fix method name in getStreamBasicChecker 
* Replace incorrect MethodGetContainer by MethodGetObject constant.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-01-16 23:52:37 +03:00
Airat Arifullin
c8baf76fae [#872] object: Introduce APE middlewar for object service 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-01-12 18:41:35 +03:00
Dmitrii Stepanov
52ffa9f164 [#891] getSvc: Refactor Get service V2 creation 
Use arguments for mandatory fields.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-12 13:35:38 +03:00
Dmitrii Stepanov
394f086fe2 [#891] getSvc: Fix get range hash implementation 
Get range can perform GET request, so this request must be done
from container node to not to get access denied error.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-12 13:35:38 +03:00
Evgenii Stratonikov
be8607a1f6 [#902] morph: Avoid creating session in TestInvokeIterator 
When the number of items to iterate over is less than 2048, there is no
need to create a session and consume resources.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2024-01-12 10:25:56 +00:00
Dmitrii Stepanov
a2ab373a0a [#895] metabase: Do not delete GC mark for virtual objects 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-11 12:32:09 +00:00
Dmitrii Stepanov
7166e77c2b [#895] test: Add logger to test shard 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-11 12:32:09 +00:00
Dmitrii Stepanov
47dcfa20f3 [#895] test: Use t.Cleanup only for external resources 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-11 12:32:09 +00:00
Dmitrii Stepanov
836818fb75 [#895] test: Use zaptest logger 
Previous implementation mixes logs from different tests, now logs
are separeted by test.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-11 12:32:09 +00:00
Dmitrii Stepanov
f1b2b8bffa [#895] test: Fix NewLogger arguments list 
`debug` is always true.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-11 12:32:09 +00:00
Airat Arifullin
a8e52ef7aa [#898] control: Fix codes for returning APE errors 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-01-11 12:31:31 +00:00
Airat Arifullin
5d982976fd [#898] ape: Fix bug with creating type bucket in chainbase 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2024-01-11 12:31:31 +00:00
Denis Kirillov
c19396d203 [#885] control: Make chain id bytes in grpc 
Signed-off-by: Denis Kirillov <d.kirillov@yadro.com>
 2024-01-11 07:24:22 +00:00
Dmitrii Stepanov
5c0a736a25 [#899] containerSvc: Fix invalid session token type 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-10 18:37:54 +03:00
Alexander Chuprov
79bebe4a68 [#884] cli: Fix error message for undefined endpoint 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
 2024-01-10 10:02:16 +00:00
Dmitrii Stepanov
4b8b4da681 [#864] engine: Drop container count metric if container removed 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-10 10:45:32 +03:00
Dmitrii Stepanov
d75e7e9a21 [#864] engine: Drop container size metric if container deleted 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-10 10:44:54 +03:00
Dmitrii Stepanov
dfd62ca6b1 [#864] metabase: Refactor delete/inhume 
Available -> Logic, Raw -> Phy for delete/inhume results.
Use single counter instead of vectors.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2024-01-09 09:59:42 +03:00
Evgenii Stratonikov
225fe2d4d5 [#894] blobovniczatree: Speedup rebuild test 
Down from 3s to 300ms.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-12-29 16:28:54 +00:00
Evgenii Stratonikov
530249e3bd [#893] go.mod: Update neo-go 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-12-29 15:03:47 +00:00
Dmitrii Stepanov
581887148a [#569] cli: Add control shards writecache seal command 
It does the same as `control shards flush-writecache --seal`, but
has better name.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-29 16:05:37 +03:00
Dmitrii Stepanov
7a9db5bcdd [#569] writecache: Do not wait modeMtx if mode changes 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-29 16:05:37 +03:00
Dmitrii Stepanov
32c282ca10 [#569] writecache: Refactor flush 
Make single RUnlock call instead of two.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-29 16:05:37 +03:00
Dmitrii Stepanov
0cb0fc1735 [#569] writecache: Allow to seal writecache after flush 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-29 16:05:37 +03:00
Dmitrii Stepanov
b118734909 [#890] getsvc: Log node PK 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-29 14:24:13 +03:00
Dmitrii Stepanov
764f70634d [#881] containerSvc: Add APE validation 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-27 11:05:34 +03:00
Dmitrii Stepanov
8180a0664f [#887] node: Drop badger writecache implementation 
Badger implementation isn't tested and works not well,
but requires human resources to maintain.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-22 13:00:54 +03:00
Anton Nikiforov
eab981bf1a [#876] Fix linter error 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-12-21 18:21:37 +03:00
Anton Nikiforov
d9cbb16bd3 [#866] Use TTL for blobovnicza tree cache 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-12-19 16:36:28 +00:00
Airat Arifullin
7d7cf05575 [#851] ape: Initialize and use policy contract interface 
* Replace inmemory policy contract mock by initialized
  policy contract interface.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-12-18 11:06:35 +00:00
Airat Arifullin
bdd43f6211 [#869] object: Pass just CID to chain router 
* Do not convert CID from request to native-schema resource
  format - this step is unneccessary for APE.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-12-14 11:01:20 +00:00
Ekaterina Lebedeva
2d4c0a0f4a [#552] Add systemd notifications to ir service 
Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
 2023-12-13 17:51:41 +03:00
Ekaterina Lebedeva
eca7ac9f0d [#552] Add sdnotify package 
To avoid using third-party dependencies.

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
 2023-12-13 17:49:26 +03:00
Ekaterina Lebedeva
05f8f49289 [#552] gofumpt changes 
Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
 2023-12-13 15:02:25 +03:00
Dmitrii Stepanov
7eb46404a1 [#863] blobovnicza: Fix counters 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-13 13:34:29 +03:00
Dmitrii Stepanov
11add38e87 [#857] golangci: Add protogetter linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-12 16:27:02 +03:00
Dmitrii Stepanov
94ffe8bb45 [#857] golangci: Add testifylint linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-12 16:27:02 +03:00
Dmitrii Stepanov
5d7833c89b [#857] golangci: Add perfsprint linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-12 16:27:02 +03:00
Dmitrii Stepanov
3b7c0362a8 [#861] shard: Fix Delete object 
It is possible that object doesn't exist in metabase.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-12 14:25:40 +03:00
Dmitrii Stepanov
681b2c5fd4 [#825] policer: Do not drop required linking objects 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-12 11:04:03 +00:00
Dmitrii Stepanov
a3ef7b58b4 [#755] innerring: Check container owner namespace 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-12 12:36:34 +03:00
Dmitrii Stepanov
1cd2bfe51a [#755] morph: Drop FrostFSID contract usage 
Unused.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-12 12:36:34 +03:00
Anton Nikiforov
70e0c1e082 [#841] ir: Execute netmap.addPeerIR only for state online 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-12-11 13:14:41 +00:00
aarifullin
0f45e3d344 [#804] ape: Implement boltdb storage for local overrides 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-12-07 19:08:41 +03:00
aarifullin
e361e017f3 [#842] control: Pass target instead resource name 
* Update policy-engine package version in go.mod, go.sum.
* Refactor CheckIfRequestPermitted: pass container target
  instead container ID.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-12-07 14:21:55 +00:00
aarifullin
39060382a1 [#842] control: Recieve target in gRPC methods for APE managing 
* Introduce Target type and pass it to all gRPC methods
  for APE chain managing instead CID.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-12-07 14:21:55 +00:00
Dmitrii Stepanov
db49ad16cc [#826] blobovniczatree: Do not create DB's on init 
Blobovniczas will be created on write requests.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
ad0697adc4 [#661] blobovnicza: Compute size with record size 
To get more accurate size of blobovnicza use record
size (lenght of key + lenght of data).

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
e54dc3dc7c [#698] blobovnicza: Store counter values 
Blobovnicza initialization take a long time because of bucket
Stat() call. So now blobovnicza stores counters in META bucket.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
5e8c08da3e [#661] blobstore: Add address to error logs 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
8911656b1a [#661] metrcis: Add rebuild percent metric 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
2407e5f5ff [#661] blobovniczatree: Do not sort DB's and indicies 
Put stores object to next active DB, so there is no need to sort DBs.
In addition, it adds unnecessary DB openings.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
c6a739e746 [#661] blobovniczatree: Make Rebuild concurrent for objects 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
f1c7905263 [#661] blobovniczatree: Make Rebuild concurrent 
Different DBs can be rebuild concurrently.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
d4d905ecc6 [#661] metrics: Add blobovniczatree rebuild metrics 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
b2769ca3de [#661] blobovniczatree: Make Rebuild failover safe 
Now move info stores in blobovnicza, so in case of failover
rebuild completes previous operation first.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
da4fee2d0b [#698] blobovniczatree: Init blobovniczas concurrently 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:33 +03:00
Dmitrii Stepanov
422226da18 [#661] blobovniczatree: Add Rebuild implementation 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:32 +03:00
Dmitrii Stepanov
a531eaf8bc [#661] blobstor: Add Rebuild implementation 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:32 +03:00
Dmitrii Stepanov
c1667a11d2 [#661] blobovniczatree: Allow to change depth or width 
Now it is possible to change depth or with of blobovniczatree.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:32 +03:00
Dmitrii Stepanov
484eb59893 [#661] blobovniczatree: Use .db extension for db files 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:32 +03:00
Dmitrii Stepanov
44552a849b [#661] shard: Add blobstor rebuilder 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-07 15:37:32 +03:00
Dmitrii Stepanov
a478050639 [#838] metabase: Resolve funlen linter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-06 15:44:21 +03:00
Dmitrii Stepanov
d30ab5f29e [#838] metabase: Count user objects 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-06 15:44:21 +03:00
Dmitrii Stepanov
f314da4af3 [#838] metabase: Add user object type counter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-06 15:44:21 +03:00
Dmitrii Stepanov
29550fe600 [#838] shard: Refactor updateMetrics method 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-12-06 15:44:21 +03:00
Alexander Chuprov
b2c63e57ba [#651] engine/test: Speedup StorageEngine_Inhume 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
 2023-11-30 13:19:43 +00:00
Alexander Chuprov
445ebcc0e7 [#651] shard/test: Speedup Shard_Delete 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
 2023-11-30 13:19:43 +00:00
Alexander Chuprov
2302e5d342 [#651] shard/test: Refactor Shard_Delete 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
 2023-11-30 13:19:43 +00:00
Dmitrii Stepanov
26e4f7005c [#741] treesvc: Refactor tree sync 
Fix linter issues.
Add error logging.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-30 12:45:02 +00:00
Dmitrii Stepanov
b21be1abdd [#741] treesvc: Do not update sync height if some node is unavailable 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-30 12:45:02 +00:00
Dmitrii Stepanov
b215817e14 [#741] treesvc: Remove unused height variables 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-30 12:45:02 +00:00
Dmitrii Stepanov
c516c7c5f4 [#821] node: Pass user.ID by value 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-23 10:21:07 +03:00
Dmitrii Stepanov
07390ad4e3 [#715] node: Unify config parameter names 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-22 17:13:50 +03:00
Dmitrii Stepanov
8d18fa159e [#667] writecache: Fix flush test 
Allow to disable background flusher for testing purposes.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-17 17:45:43 +03:00
aarifullin
02454df14a [#809] client: Refactor PrmInit, PrmDial usage 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-11-17 13:37:03 +00:00
Dmitrii Stepanov
76ff26039c [#96] node: Drop neo-go's slices package 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-17 13:24:04 +03:00
aarifullin
47286ebf32 [#805] pilorama: Fix TreeDrop 
* If treeID is empty then deleting buckets for cursor may get
  invalidated. So, buckets should be gathered before deleting.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-11-17 10:21:35 +00:00
Dmitrii Stepanov
29fe8c41f3 [#655] storage: Drop ErrorHandler 
The only one usage was for logging.
Now logging performed by storage anyway.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-16 17:27:38 +03:00
Dmitrii Stepanov
137e987a4e [#655] storage: Drop LazyHandler 
LazyHandler is implemented and used incorrectly.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-16 17:27:38 +03:00
aarifullin
4d5be5ccb5 [#811] ape: Update policy-engine module version and rebase 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-11-16 11:31:37 +03:00
Evgenii Stratonikov
a952a406a2 [#506] container: Use uint64 for epoch type 
It is `uint64` in netmap source interfaces and other code.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-11-14 19:00:11 +00:00
Evgenii Stratonikov
f04806ccd3 [#506] container: Use user.ID in DeletionInfo response 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-11-14 19:00:11 +00:00
Dmitrii Stepanov
8088063195 [#787] netmap: Refactor NewEpoch method 
Split for user and control methods.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-13 17:22:31 +03:00
Dmitrii Stepanov
c8a62ffedd [#787] morph: Calculate VUB and nonce when hash is nil 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-13 17:13:03 +03:00
Dmitrii Stepanov
2393d13e4d [#787] morph: Return VUB for IR service calls 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-13 17:13:03 +03:00
Dmitrii Stepanov
518f3baf41 [#787] morph: Return VUB from Invoke method 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-13 17:13:03 +03:00
Dmitrii Stepanov
bdfa523487 [#787] proto: Add VUB field for IR service 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-13 17:13:03 +03:00
Dmitrii Stepanov
0f75e48138 [#796] policer: Fix tombstone objects replication 
Tombstone objects must be replicated to all container nodes.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-09 13:39:33 +03:00
Dmitrii Stepanov
7cdae4f660 [#792] proto: Regenerate with fixed version 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-09 10:09:13 +00:00
Dmitrii Stepanov
9133b4389e [#788] objectsvc: Fix formatting (gofumpt) 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-09 10:27:32 +03:00
Dmitrii Stepanov
1b22801eed [#788] engine: Fix flaky tests 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-09 10:25:46 +03:00
aarifullin
3534d6d05b [#794] objectsvc: Return accidentally removed acl checks for Head 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-11-08 17:13:58 +03:00
Airat Arifullin
66848d3288 [#770] cli: Add methods to work with APE rules via control svc 
* Add methods to frostfs-cli
* Implement rpc in control service

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-11-08 13:34:03 +00:00
Airat Arifullin
8e11ef46b8 [#770] object: Introduce ape chain checker for object svc 
* Introduce Request type converted from RequestInfo type
  to implement policy-engine's Request interface
* Implement basic ape checker to check if a request is
  permitted to be performed
* Make put handlers use APE checker instead EACL

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-11-08 13:34:03 +00:00
Airat Arifullin
5ec73fe8a0 [#770] node: Introduce ape chain source 
* Provide methods to access rule chains with access
  policy engine (APE) chain source
* Initialize apeChainSource within object service
  initialization
* Share apeChainSource with control service
* Implement dummy apeChainSource instance based on
  in-memory implementation

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-11-08 13:34:03 +00:00
Airat Arifullin
3a2c319b87 [#770] control: Generate gRPC methods to manipulate APE chains 
* Define new types and gRPC methods to manipulate APE chains
  in control service.
* Stub gRPC handlers for the generated methods.

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-11-08 13:34:03 +00:00
Dmitrii Stepanov
70ab1ebd54 [#763] metrics: Add container_objects_total metric 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-08 12:30:57 +03:00
Dmitrii Stepanov
9c98fa6152 [#763] metabase: Add container objects counter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-08 12:30:57 +03:00
Dmitrii Stepanov
226e84d782 [#684] node: Add skipped objects count to evacuation result 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-07 12:17:11 +00:00
Dmitrii Stepanov
523fb3ca51 [#684] proto: Add skipped count to evacuation status response 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-07 12:17:11 +00:00
aarifullin
74c91eeef5 [#777] client: Refactor PrmContainerList, PrmObjectSearch usage 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-11-06 06:50:11 +00:00
Dmitrii Stepanov
20d6132f31 [#531] signSvc: Add SetMarshaledData method call 
To reduce memory allocations add `SetMarshaledData` method call
to return already marshalled data in next `StableMarshal` calls.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-02 17:34:33 +03:00
Anton Nikiforov
a26483fc30 [#749] morph: Fix panic when closing morph client 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-11-01 10:48:10 +00:00
Dmitrii Stepanov
c80b46fad3 [#754] blobstor: Estimate compressability 
Now it is possible to enable compressability estimation.
If data is likely uncompressable, it should reduce CPU time and memory.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-11-01 11:24:32 +03:00
Dmitrii Stepanov
05b508f79a [#772] proto: Fix file ending 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-31 17:03:04 +03:00
Dmitrii Stepanov
79088baa06 [#772] node: Apply gofumpt 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-31 17:03:03 +03:00
Evgenii Stratonikov
00aa6d9749 [#633] shard/test: Fix TestCounters() 
Introduced in 362f24953a, forgotten to be changed because test
generator didn't provide payload size.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-31 12:53:28 +00:00
Evgenii Stratonikov
b8f79f4227 [#633] shard/test: Fix race conditions in TestCounters() 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-31 12:53:28 +00:00
Evgenii Stratonikov
261d281154 [#762] go.mod: Update sdk-go 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-31 11:22:29 +00:00
Dmitrii Stepanov
869518be0a [#728] writecache: Fix Badger writecache race. 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-30 18:36:41 +03:00
Dmitrii Stepanov
d4b6ebe7e7 [#725] writecache: Fix metric values 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-27 12:22:29 +03:00
Anton Nikiforov
121f5c4dd8 [#757] ir: Do not exclude node in maintenance mode from netmap 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-10-26 10:50:32 +03:00
Evgenii Stratonikov
9f7c2d8810 [#752] innerring: Simplify keyPosition() 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-25 16:06:44 +03:00
Evgenii Stratonikov
cddc58ace2 [#752] innerring: Optimize keyPosition() 
```
goos: linux
goarch: amd64
pkg: git.frostfs.info/TrueCloudLab/frostfs-node/pkg/innerring
cpu: 11th Gen Intel(R) Core(TM) i5-1135G7 @ 2.40GHz
              │      old       │                 new                 │
              │     sec/op     │   sec/op     vs base                │
KeyPosition-8   2771.50n ± 10%   40.32n ± 4%  -98.55% (p=0.000 n=10)

              │     old      │                  new                  │
              │     B/op     │     B/op      vs base                 │
KeyPosition-8   1.531Ki ± 0%   0.000Ki ± 0%  -100.00% (p=0.000 n=10)

              │    old     │                new                 │
              │ allocs/op  │ allocs/op  vs base                 │
KeyPosition-8   21.00 ± 0%   0.00 ± 0%  -100.00% (p=0.000 n=10)
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-25 16:06:44 +03:00
Evgenii Stratonikov
0a9830564f [#752] morph: Adopt neo-go RPC statuses 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-25 16:06:44 +03:00
Evgenii Stratonikov
6950312967 [#752] morph: Drop loop copy kludges 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-25 16:06:44 +03:00
Evgenii Stratonikov
fe1acf9e9a [#750] morph: Remove deprecated channel use 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-25 07:57:05 +00:00
Anton Nikiforov
559ad58ab1 [#642] writecache: Remove usage of close channel in bbolt 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-10-24 15:57:50 +00:00
Anton Nikiforov
c0b86f2d93 [#642] writecache: Remove usage of close channel in badger 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-10-24 15:57:50 +00:00
Anton Nikiforov
b0cf100427 [#49] node: React on SIGHUP only when node in READY state 
Add more info in logs when node is going to shut down,
but initialization process still in progress.

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-10-24 15:55:29 +00:00
aarifullin
58b6224dd8 [#747] client: Refactor PrmObjectPutInit usage 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-10-20 11:55:40 +00:00
aarifullin
12b7cf2533 [#747] client: Refactor PrmObjectPutSingle usage 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-10-20 11:55:40 +00:00
Dmitrii Stepanov
dc4d27201b [#733] morph: Fix delete container signature check 
Committed invalid condition, it was just for debug.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-19 18:07:37 +03:00
Dmitrii Stepanov
189dbb01be [#733] frostfs-cli: Add control ir remove-container 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-19 16:22:18 +03:00
Dmitrii Stepanov
f2437f7ae9 [#734] shard: Fix Delete method 
Due to the flushing data from the writecache to the storage
and simultaneous deletion, a partial deletion situation is possible.
So as a solution, deletion is allowed only when the object is in storage,
because object will be deleted from writecache by flush goroutine.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-16 17:00:18 +03:00
Dmitrii Stepanov
f26233b47a [#734] metabase: Include UpdateStorageID in metrics and traces 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-16 17:00:18 +03:00
Dmitrii Stepanov
7e0c5a55de [#734] writecache: Fix flush 
Now UpdateStorageID doesn't return error in case of logical error.
If object is in graveyard or GC market, it is still required to
update storage ID.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-16 17:00:17 +03:00
Anton Nikiforov
3a997d1207 [#680] metrics: Initialize log metrics together with services 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-10-11 17:08:03 +03:00
Anton Nikiforov
994f48f8bb [#680] metrics: Export log and morph with script 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-10-11 17:08:03 +03:00
Evgenii Stratonikov
aca11d7474 [#735] policer: Allow to provide metrics from the outside 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-11 15:14:13 +03:00
Ekaterina Lebedeva
5e229dc248 [#701] metrics: add metric to evaluate policer performance 
Add processed objects counter in policerMetrics,
add policer field to NodeMetrics

Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
 2023-10-09 19:02:08 +00:00
Evgenii Stratonikov
4caa934eea [#729] containersvc: Remove load announcement 
IR code was removed in 8879c6ea.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-10-09 19:01:13 +00:00
Dmitrii Stepanov
d07afd803c [#726] writecache: Fix small object flush for Badger 
Do not marshal object twice.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-06 11:32:50 +03:00
Dmitrii Stepanov
997ac7cd8d [#726] writecache: Fix small object flush for BBolt 
Do not marshal object twice.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-10-06 11:32:44 +03:00
Alexander Chuprov
c1e4130020 [#146] node: Add trace_id to logs 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
 2023-09-27 11:05:27 +03:00
a.arifullin
3889e829e6 [#667] writecache: Add logs for report error func in tests 
Signed-off-by: Airat Arifullin a.arifullin@yadro.com
 2023-09-14 17:02:54 +00:00
Evgenii Stratonikov
c6af4a3ec8 [#679] engine: Do not increase error counter on meta mismatch 
It was introduced in 69e1e6ca to help node determine faulty shards.
However, the situation is possible in a real-life scenario:
1. Object O is evacuated from shard A to B.
2. Shard A is unmounted because of lower-level errors.
3. We now have object in meta on A and in blobstor on B. Technically we
   have it in meta on shard B too, but we still got the error if B goes
   to a degraded mode.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-14 10:39:18 +03:00
Ekaterina Lebedeva
8a81af5a3b [#653] Add context parameter to Open functions 
Signed-off-by: Ekaterina Lebedeva <ekaterina.lebedeva@yadro.com>
 2023-09-07 18:03:29 +03:00
Evgenii Stratonikov
a716db99db [#668] shard/test: Do not alter rootPath option 
Supposedly, this was added to allow creating 2 different shards without
subtest. Now we use t.TempDir() everywhere, so this should not be a
problem.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
36759f8434 [#668] shard/test: Properly check event processing 
See https://git.frostfs.info/TrueCloudLab/frostfs-node/actions/runs/1594/jobs/2

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
39879fa868 [#668] shard/test: Add dontRelease options 
Most of the time we would like to close shard with minor exceptions.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
c661ba1312 [#668] shard/test: Use sane defaults in the test constructor 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
268adb79cb [#668] shard/test: Simplify shard construction 
newCustomShard() has many parameters but only the first is obligatory.
`enableWriteCache` is left as-is, because it directly affects the
functionality.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
429f941cda [#668] shard/test: Release shard in t.Cleanup() 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
382eb8a485 [#668] shard/test: Disable GC where it is not needed 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
42696016de [#668] shard: Close stopChannel in GC 
It is done once, but now we could read it from multiple places.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
bdecfbc1be [#668] shard/test: Move tests to the main package 
Semantic patch (also, duplicate definitions are removed):
```
@@
var e identifier
@@
-import "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/shard"

-shard.e
+e
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
aa23c6a83a [#668] shard/test: Remove subtest from TestCounters 
Otherwise, individual tests cannot be run.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Evgenii Stratonikov
da8f384324 [#668] shard/test: Fix typo in existence 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-07 07:39:39 +00:00
Anton Nikiforov
aeeb8193d2 [#676] node: Fix header source creation when checking eacl 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-09-06 17:06:54 +03:00
Anton Nikiforov
88d50e4c77 [#656] policer: Add "bad" testcase 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-09-06 08:04:59 +00:00
Evgenii Stratonikov
a54b4472de [#674] network: Close connections on address updates 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-09-04 15:34:24 +03:00
Dmitrii Stepanov
7456c8556a [#536] blobovnicza: Add blobovniczatree DB cache 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-09-01 13:53:11 +03:00
Dmitrii Stepanov
c672f59ab8 [#536] blobovnicza: Drop cache 
Each blobovnicza instance is opened
while is in use.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-09-01 13:51:26 +03:00
Evgenii Stratonikov
b9b86d2ec8 [#666] shard/test: Fix data race in metrics tests 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-31 08:39:42 +00:00
Anton Nikiforov
4dff9555f1 [#568] writecache: Improve flushing scheme for badger 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-08-30 17:22:28 +00:00
Airat Arifullin
806cc13d9f [#658] client: Refactor PrmObjectGet/Head/Range usage 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-08-30 17:13:23 +00:00
Alejandro Lopez
1daef2ceeb [#660] writecache: Fix remaining addr2key uses 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
 2023-08-30 17:12:33 +00:00
Anton Nikiforov
fe5aa06a75 [#665] node: Bind length of copies number to number of replicas 
Allow to use one digit in copies number array for backward compatibility.

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-08-30 17:11:55 +00:00
Dmitrii Stepanov
55b82e744b [#529] objectcore: Use common sender classifier 
Use common sender classifier for ACL service and format validator.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-29 10:33:06 +03:00
Dmitrii Stepanov
ae81d6660a [#529] objectcore: Fix object content validation 
There are old objects where the owner of the object
may not match the one who issued the token.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-29 10:33:06 +03:00
Dmitrii Stepanov
ab2614ec2d [#528] objectcore: Validate token issuer 
Add token issuer against object owner validation.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-29 10:10:10 +03:00
Airat Arifullin
4ea0df77d0 [#574] policer: Check if the container was really removed 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-08-28 14:21:38 +00:00
Airat Arifullin
554ff2c06b [#574] core: Extend Source interface with DeletionInfo method 
* Introduce common method EverExisted
* Define DeletionInfo for struct that must implement Source
* Refactor tree srv

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-08-28 14:21:38 +00:00
Evgenii Stratonikov
9072772a09 [#649] shard/test: Increase GC remover interval 
This was set in #348 to speed up tests.
It seems 100ms doesn't increase overall test time,
but it reduces the amount of logs by 100x factor.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-25 10:10:25 +00:00
Evgenii Stratonikov
c4db8e7690 [#637] shard/test: Fix data race 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-25 10:10:25 +00:00
Evgenii Stratonikov
f8ba60aa0c [#648] objsvc/delete: Handle errors in Go style 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-25 09:45:35 +00:00
Evgenii Stratonikov
d2084ece41 [#648] objsvc/delete: Remove redundant logs 
We never propagate delete requests to the container node, because
tombstone broadcast is done via PUT. No need to pollute logs.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-25 09:45:35 +00:00
Evgenii Stratonikov
40b556fc19 [#647] objsvc/search: Improve testing coverage 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-25 10:40:01 +03:00
Evgenii Stratonikov
4db2cbc927 [#647] objsvc/search: Wrap in uniqueIDWriter during parameter setting 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-25 10:40:01 +03:00
Evgenii Stratonikov
966ad22abf [#647] objsvc/search: Simplify error handling 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-25 10:40:01 +03:00
Evgenii Stratonikov
56f841b022 [#647] objsvc/search: Remove TraverserGenerator wrapper 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-25 10:40:01 +03:00
Evgenii Stratonikov
ba58144de1 [#647] objsvc/search: Remove netmap.Source wrapper 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-25 10:40:01 +03:00
Evgenii Stratonikov
c9e3c9956e [#643] objsvc/put: Unify extraBroadcastEnabled usage 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-24 11:03:17 +03:00
Evgenii Stratonikov
facd3b2c4b [#643] objsvc/put: Unify placement iterators 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-24 11:03:17 +03:00
Evgenii Stratonikov
3fcf56f2fb [#643] objsvc/put: Copy config to distributedTarget 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-24 11:03:17 +03:00
Evgenii Stratonikov
96e690883f [#638] Unify test loggers 
In some places we have debug=false, in others debug=true.
Let's be consistent.

Semantic patch:
```
@@
@@
-test.NewLogger(..., false)
+test.NewLogger(..., true)
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-23 11:21:05 +00:00
Evgenii Stratonikov
322c1dc273 [#638] Use test.NewLogger() in tests 
Semantic patch (restricted to **/*_test.go):
```
@@
@@
+import "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/logger/test"
-import "go.uber.org/zap"
-import "git.frostfs.info/TrueCloudLab/frostfs-node/pkg/util/logger"

-&logger.Logger{Logger: zap.L()}
+test.NewLogger(t, false)
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-23 11:21:05 +00:00
Evgenii Stratonikov
02b03d9c4f [#638] logger: Remove sampling from test loggers 
Losing logs is always a bad idea, especially when we debug tests.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-23 11:21:05 +00:00
Evgenii Stratonikov
82cc453be9 [#xx] shard: Fix data race in metrics tests 
Protect test metric store fields with a mutex. Probably, not every field
should be protected, but better safe than sorry.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-23 10:26:12 +00:00
Alejandro Lopez
345a1a69a2 [#635] Use internal key type when deleting from badger wc 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
 2023-08-22 10:53:19 +03:00
Airat Arifullin
23be3eb627 [#574] tree: Check if container is really removed 
* Use DeletionInfo method from morph client to check if
  the container has been really removed from neo-go

Signed-off-by: Airat Arifullin a.arifullin@yadro.com
 2023-08-21 12:50:20 +03:00
Airat Arifullin
42fb6fb372 [#574] morph: Add DeletionInfo method for morph client 
Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
 2023-08-21 12:49:06 +03:00
Dmitrii Stepanov
354a92ea2c [#602] blobovnicza: Add leaf width implementation 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-21 10:27:32 +03:00
Alexander Chuprov
4d9a6c07fb [#618] core: Replace fmt.Sprintf with strconv.FormatUint 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
 2023-08-21 07:14:50 +00:00
Dmitrii Stepanov
f2811f8585 [#602] metrics: Add blobovnicza items counter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-18 13:01:27 +03:00
Dmitrii Stepanov
c4e1d8eb07 [#602] node: Fix blobovnicza typos 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-18 11:14:10 +03:00
Dmitrii Stepanov
10e63537b2 [#602] metrics: Rename blobovnicza size metric 
`Size` is not size, but open db size.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-17 19:17:35 +00:00
Dmitrii Stepanov
809e97626b [#602] blobovnicza: Fix size counter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-17 19:17:35 +00:00
Dmitrii Stepanov
2e49d7ea7e [#602] blobovnicza: Init before using 
Fix blobovnicza size: after restart size metric resets.

Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-17 19:17:35 +00:00
Evgenii Stratonikov
f7042c5a6f [#609] Replace zaptest.NewLogger() with zap.L() 
Semantic patch:
```
@@
@@
-import "go.uber.org/zap/zaptest"
+import "go.uber.org/zap"

-zaptest.NewLogger(t)
+zap.L()
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-17 16:51:10 +00:00
Evgenii Stratonikov
127c676786 [#607] *: Use keys.PublicKeys.Copy() where possible 
Semantic patch:
```
@@
var dst identifier
var src identifier
var keys identifier
@@
 import keys "github.com/nspcc-dev/neo-go/pkg/crypto/keys"

-dst := make(keys.PublicKeys, len(src))
-copy(dst, src)
+dst := src.Copy()
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-17 16:50:02 +00:00
Evgenii Stratonikov
e604a3d749 [#607] *: Use zap.Stringer() where possible 
Semantic patch:
```
@@
var f expression
var t expression
var a expression
@@
 f(
    ...,
-    zap.String(t, a.String()),
+    zap.Stringer(t, a),
    ...,
)
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-17 16:50:02 +00:00
Evgenii Stratonikov
a8de37c8a2 [#607] *: Remove redundant if on error returns 
Semantic patch:
```
@@
@@
-if err != nil { return err }
-return nil
+return err
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-17 16:50:02 +00:00
Evgenii Stratonikov
5a51b78946 [#620] object: Send status response for server-side streams 
Previously status responses were wrapped in the gRPC error and thus
couldn't be correctly handled on client.

Introduced in c2617baf63, thanks @ale64bit for having found.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-17 12:52:38 +00:00
Anton Nikiforov
6407bb5bd1 [#619] node: Fix object put when copies numbers contains only zeros 
In this case object should placement according to replicas.

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-08-17 11:31:34 +03:00
Evgenii Stratonikov
5335e7089e [#615] pilorama: Speedup TestForest_ApplyRandom() 
Some of our pilorama tests fail on CI.
The reasons are not obvious, but one possible improvement
is using `WithNoSync` option for these. It should have much effect,
because we are writing on the tmpfs, but doesn't hurt anyway.

If I replace `t.TempDir()` with a local directory, test execution time
goes down from 5s (sync) to 0.4s (nosync), which is the same time as
with `t.TempDir()`. Maybe we have some strange CI configuration.

```
panic: test timed out after 10m0s
running tests:
	TestForest_ApplyRandom (8m22s)
	TestForest_ApplyRandom/bbolt (8m21s)
...
goroutine 170 [syscall]:
syscall.Syscall(0xc000100000?, 0xc00047b758?, 0x6aff9a?, 0xc00041c1b0?)
	/opt/hostedtoolcache/go/1.20.7/x64/src/syscall/syscall_linux.go:69 +0x27
syscall.Fdatasync(0x9e35c0?)
	/opt/hostedtoolcache/go/1.20.7/x64/src/syscall/zsyscall_linux_amd64.go:418 +0x2a
go.etcd.io/bbolt.fdatasync(0xc000189000?)
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-16 19:09:08 +00:00
Dmitrii Stepanov
2efe9cc1be [#585] writecache: Fix DB counter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-16 14:47:44 +03:00
Dmitrii Stepanov
58c8722c81 [#585] fstree: Add optional file counter 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-16 14:47:44 +03:00
Dmitrii Stepanov
baad49990c [#585] fstree: Return logical error if object deleted 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-16 14:47:44 +03:00
Dmitrii Stepanov
0c52186572 [#585] fstree: Remove unused method 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-16 14:47:44 +03:00
Dmitrii Stepanov
eec97d177e [#585] writecache: Count items periodically 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
 2023-08-16 14:47:44 +03:00
Evgenii Stratonikov
d15199c5d8 [#596] engine: Consider context errors as logical 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-16 10:39:41 +03:00
Alejandro Lopez
88b6755c5e [#598] Fix use-after-close bug in badger writecache 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
 2023-08-15 07:04:06 +00:00
Alejandro Lopez
ae8be495c8 [#xx] Avoid manual management of files in tests 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
 2023-08-14 14:01:39 +03:00
Alejandro Lopez
376f03a445 [#598] Hold mode mutex when setting mode 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
 2023-08-14 07:12:27 +00:00
Alexander Chuprov
21800e9fcc [#162] core: Move literals to constants 
Signed-off-by: Alexander Chuprov <a.chuprov@yadro.com>
 2023-08-11 15:48:42 +03:00
Evgenii Stratonikov
b44a8dd46c [#597] *: Fix linter warnings 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-11 09:55:51 +03:00
Evgenii Stratonikov
e084c47bd6 [#248] innerring: Remove audit from tests 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-10 16:38:43 +00:00
Evgenii Stratonikov
779da6ec35 [#248] morph: Remove audit contract name 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-10 16:38:43 +00:00
Evgenii Stratonikov
55ce4dc075 [#248] morph: Remove obsolete network parameters 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-10 16:38:43 +00:00
Anton Nikiforov
4ad0ebb32f [#565] Add metrics for current GRPC endpoint status 
Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>
 2023-08-10 16:37:49 +00:00
Evgenii Stratonikov
c3e23a1448 [#578] gendoc: Allow to override flags 
The command is used in multiple places across the whole FrostFS
ecosystem. While we want to have uniform interfaces everywhere,
sometimes we can't: already defined global flags can be harder to change
because of our obligations to the users. Cobra framework doesn't allow
conflicting flags (we can have global ones), so allow to override them.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-10 11:10:11 +00:00
Evgenii Stratonikov
6bcba27757 [#578] gendoc: Remove flag shorthands 
Make it harder to encounter conflicts in already existing commands.
Because the command is executed once, I don't think the usability is
worse.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-10 11:10:11 +00:00
Evgenii Stratonikov
dca31e8888 [#578] gendoc: Add date to man pages 
```
HISTORY
       8-Aug-2023 Auto generated by spf13/cobra
```

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-10 11:10:11 +00:00
Evgenii Stratonikov
b02a1a34c1 [#578] gendoc: Allow to customize man pages 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-10 11:10:11 +00:00
Evgenii Stratonikov
082370583f [#578] gendoc: Replace NSPCC with FrostFS 
Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-10 11:10:11 +00:00
Alejandro Lopez
8f994163ee [#586] Fix writecache benchmarks and refactor hacky NeedsCompression 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
 2023-08-10 08:05:18 +00:00
Alejandro Lopez
023b90342c [#584] Disable compression in badger writecache 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
 2023-08-10 10:14:06 +03:00
Evgenii Stratonikov
d641cba2fc [#587] Do not use math/rand.Read 
Fix staticcheck warnings after go1.20 update.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
 2023-08-09 16:02:44 +03:00
Alejandro Lopez
5b7e4a51b7 [#481] Update frostfs-sdk-go and error pointer receivers 
Signed-off-by: Alejandro Lopez <a.lopez@yadro.com>
 2023-08-09 10:26:53 +00:00