george.bartolomey/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Pull requests Activity

[#493] logger: Do not set global fields in constructor

Browse source 
Remove setting of `app_name` and `app_version` fields in `NewLogger`
constructor. Set these fields in Node and IR application in already
constructed log and remove them from viper .

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
Leonard Lyubich 2021-05-11 11:25:54 +03:00 • committed by Alex Vanin
parent d17526f8ac
commit 2a970b0125
4 changed files with 11 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

12
pkg/util/logger/logger.go
View file

@ -27,20 +27,10 @@ func NewLogger(v *viper.Viper) (*Logger, error) {
c.Encoding = "console"
c.EncoderConfig.EncodeTime = zapcore.ISO8601TimeEncoder
l, err := c.Build(
return c.Build(
// record a stack trace for all messages at or above fatal level
zap.AddStacktrace(zap.NewAtomicLevelAt(zap.FatalLevel)),
)
if err != nil {
return nil, err
}
name := v.GetString("app.name")
version := v.GetString("app.version")
return l.With(
zap.String("app_name", name),
zap.String("app_version", version)), nil
}
func safeLevel(lvl string) zap.AtomicLevel {