george.bartolomey/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Pull requests Activity

[#1764] neofs-node: Allow to return error from IterateShards

Browse source 
Signed-off-by: Evgenii Stratonikov <evgeniy@morphbits.ru>
This commit is contained in:
Evgenii Stratonikov 2022-09-20 15:33:59 +03:00 • committed by fyrchik
parent 898689ec14
commit 9113793688
3 changed files with 26 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

19
cmd/neofs-node/config/engine/config_test.go
View file

@ -20,17 +20,17 @@ func TestEngineSection(t *testing.T) {
t.Run("defaults", func(t *testing.T) {
empty := configtest.EmptyConfig()
require.Panics(t, func() {
engineconfig.IterateShards(empty, true, nil)
})
require.ErrorIs(t,
engineconfig.IterateShards(empty, true, nil),
engineconfig.ErrNoShardConfigured)
handlerCalled := false
require.NotPanics(t, func() {
engineconfig.IterateShards(empty, false, func(_ *shardconfig.Config) {
require.NoError(t,
engineconfig.IterateShards(empty, false, func(_ *shardconfig.Config) error {
handlerCalled = true
})
})
return nil
}))
require.False(t, handlerCalled)
@ -47,7 +47,7 @@ func TestEngineSection(t *testing.T) {
require.EqualValues(t, 100, engineconfig.ShardErrorThreshold(c))
require.EqualValues(t, 15, engineconfig.ShardPoolSize(c))
engineconfig.IterateShards(c, true, func(sc *shardconfig.Config) {
err := engineconfig.IterateShards(c, true, func(sc *shardconfig.Config) error {
defer func() {
num++
}()
@ -145,8 +145,9 @@ func TestEngineSection(t *testing.T) {
require.Equal(t, true, sc.RefillMetabase())
require.Equal(t, mode.ReadWrite, sc.Mode())
}
return nil
})
require.NoError(t, err)
require.Equal(t, 2, num)
}