forked from TrueCloudLab/frostfs-node
Aleksey Savchuk
f0c43c8d80
Use `zap.Error` instead of `zap.String` for logging errors: change all expressions like
`zap.String("error", err.Error())` or `zap.String("err", err.Error())` to `zap.Error(err)`.
Leave similar expressions with other messages unchanged, for example,
`zap.String("last_error", lastErr.Error())` or `zap.String("reason", ctx.Err().Error())`.
This change was made by applying the following patch:
```diff
@@
var err expression
@@
-zap.String("error", err.Error())
+zap.Error(err)
@@
var err expression
@@
-zap.String("err", err.Error())
+zap.Error(err)
```
Signed-off-by: Aleksey Savchuk <a.savchuk@yadro.com>
71 lines
2.1 KiB
Go
71 lines
2.1 KiB
Go
package blobstor
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"time"
|
|
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/internal/logs"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-node/pkg/local_object_storage/blobstor/common"
|
|
"git.frostfs.info/TrueCloudLab/frostfs-observability/tracing"
|
|
oid "git.frostfs.info/TrueCloudLab/frostfs-sdk-go/object/id"
|
|
"go.opentelemetry.io/otel/attribute"
|
|
"go.opentelemetry.io/otel/trace"
|
|
"go.uber.org/zap"
|
|
)
|
|
|
|
// Iterate traverses the storage over the stored objects and calls the handler
|
|
// on each element.
|
|
//
|
|
// Returns any error encountered that
|
|
// did not allow to completely iterate over the storage.
|
|
//
|
|
// If handler returns an error, method wraps and returns it immediately.
|
|
func (b *BlobStor) Iterate(ctx context.Context, prm common.IteratePrm) (common.IterateRes, error) {
|
|
var (
|
|
startedAt = time.Now()
|
|
success = false
|
|
)
|
|
defer func() {
|
|
b.metrics.Iterate(time.Since(startedAt), success)
|
|
}()
|
|
ctx, span := tracing.StartSpanFromContext(ctx, "BlobStor.Iterate",
|
|
trace.WithAttributes(
|
|
attribute.Bool("ignore_errors", prm.IgnoreErrors),
|
|
))
|
|
defer span.End()
|
|
|
|
b.modeMtx.RLock()
|
|
defer b.modeMtx.RUnlock()
|
|
|
|
for i := range b.storage {
|
|
_, err := b.storage[i].Storage.Iterate(ctx, prm)
|
|
if err != nil {
|
|
if prm.IgnoreErrors {
|
|
b.log.Warn(ctx, logs.BlobstorErrorOccurredDuringTheIteration,
|
|
zap.String("storage_path", b.storage[i].Storage.Path()),
|
|
zap.String("storage_type", b.storage[i].Storage.Type()),
|
|
zap.Error(err))
|
|
continue
|
|
}
|
|
return common.IterateRes{}, fmt.Errorf("blobstor iterator failure: %w", err)
|
|
}
|
|
}
|
|
success = true
|
|
return common.IterateRes{}, nil
|
|
}
|
|
|
|
// IterateBinaryObjects is a helper function which iterates over BlobStor and passes binary objects to f.
|
|
// Errors related to object reading and unmarshaling are logged and skipped.
|
|
func IterateBinaryObjects(ctx context.Context, blz *BlobStor, f func(addr oid.Address, data []byte, descriptor []byte) error) error {
|
|
var prm common.IteratePrm
|
|
|
|
prm.Handler = func(elem common.IterationElement) error {
|
|
return f(elem.Address, elem.ObjectData, elem.StorageID)
|
|
}
|
|
prm.IgnoreErrors = true
|
|
|
|
_, err := blz.Iterate(ctx, prm)
|
|
|
|
return err
|
|
}
|