From 8538ff06b7f2bcf3d8cc673b34927381bd541d21 Mon Sep 17 00:00:00 2001 From: Mariano Cano Date: Mon, 3 Oct 2022 12:54:26 -0700 Subject: [PATCH 1/2] Add missing error case. --- acme/errors.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/acme/errors.go b/acme/errors.go index c7c6c2cf..a969bd96 100644 --- a/acme/errors.go +++ b/acme/errors.go @@ -75,6 +75,8 @@ func (ap ProblemType) String() string { return "accountDoesNotExist" case ErrorAlreadyRevokedType: return "alreadyRevoked" + case ErrorBadAttestationStatementType: + return "badAttestationStatement" case ErrorBadCSRType: return "badCSR" case ErrorBadNonceType: From 21666ba887edb7008725aae14fc92e7fb9e1ea33 Mon Sep 17 00:00:00 2001 From: Mariano Cano Date: Mon, 3 Oct 2022 12:56:23 -0700 Subject: [PATCH 2/2] Revert "Set timestamp when marking an acme challenge invalid" This reverts commit 5f130895f3937ea040935230dd8b31093393595c. --- acme/challenge.go | 1 - acme/challenge_test.go | 1 - 2 files changed, 2 deletions(-) diff --git a/acme/challenge.go b/acme/challenge.go index 264cf73a..84b3f83a 100644 --- a/acme/challenge.go +++ b/acme/challenge.go @@ -729,7 +729,6 @@ func storeError(ctx context.Context, db DB, ch *Challenge, markInvalid bool, err ch.Error = err if markInvalid { ch.Status = StatusInvalid - ch.ValidatedAt = clock.Now().Format(time.RFC3339) } if err := db.UpdateChallenge(ctx, ch); err != nil { return WrapErrorISE(err, "failure saving error to acme challenge") diff --git a/acme/challenge_test.go b/acme/challenge_test.go index cc5642c3..e452b175 100644 --- a/acme/challenge_test.go +++ b/acme/challenge_test.go @@ -170,7 +170,6 @@ func Test_storeError(t *testing.T) { assert.Equals(t, updch.Token, ch.Token) assert.Equals(t, updch.Value, ch.Value) assert.Equals(t, updch.Status, StatusInvalid) - assert.True(t, updch.ValidatedAt != "") assert.HasPrefix(t, updch.Error.Err.Error(), err.Err.Error()) assert.Equals(t, updch.Error.Type, err.Type)