From 945a1371f182ef038f53b0b182a46b1b52df4781 Mon Sep 17 00:00:00 2001 From: Mariano Cano Date: Wed, 13 Mar 2019 16:46:12 -0700 Subject: [PATCH] Fix tests. --- authority/provisioner/jwk_test.go | 10 +++++++++- authority/provisioner/oidc_test.go | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/authority/provisioner/jwk_test.go b/authority/provisioner/jwk_test.go index ab02a4c6..c714ded0 100644 --- a/authority/provisioner/jwk_test.go +++ b/authority/provisioner/jwk_test.go @@ -52,9 +52,17 @@ func TestJWK_Init(t *testing.T) { err error } tests := map[string]func(*testing.T) ProvisionerValidateTest{ - "fail-empty-name": func(t *testing.T) ProvisionerValidateTest { + "fail-empty": func(t *testing.T) ProvisionerValidateTest { return ProvisionerValidateTest{ p: &JWK{}, + err: errors.New("provisioner type cannot be empty"), + } + }, + "fail-empty-name": func(t *testing.T) ProvisionerValidateTest { + return ProvisionerValidateTest{ + p: &JWK{ + Type: "JWK", + }, err: errors.New("provisioner name cannot be empty"), } }, diff --git a/authority/provisioner/oidc_test.go b/authority/provisioner/oidc_test.go index 8dfe5a8a..5a1dbb21 100644 --- a/authority/provisioner/oidc_test.go +++ b/authority/provisioner/oidc_test.go @@ -84,6 +84,7 @@ func TestOIDC_Init(t *testing.T) { {"ok", fields{"oidc", "name", "client-id", srv.URL + "/openid-configuration", nil, nil}, args{config}, false}, {"ok-admins", fields{"oidc", "name", "client-id", srv.URL + "/openid-configuration", nil, []string{"foo@smallstep.com"}}, args{config}, false}, {"no-name", fields{"oidc", "", "client-id", srv.URL + "/openid-configuration", nil, nil}, args{config}, true}, + {"no-type", fields{"", "name", "client-id", srv.URL + "/openid-configuration", nil, nil}, args{config}, true}, {"no-client-id", fields{"oidc", "name", "", srv.URL + "/openid-configuration", nil, nil}, args{config}, true}, {"no-configuration", fields{"oidc", "name", "client-id", "", nil, nil}, args{config}, true}, {"bad-configuration", fields{"oidc", "name", "client-id", srv.URL, nil, nil}, args{config}, true},