Mariano Cano
f49a4b326f
Add missing comments.
2022-01-05 10:54:09 -08:00
Mariano Cano
6600f1253e
Fix error messages after review.
2022-01-05 10:12:49 -08:00
Mariano Cano
6a1d0cb9f8
Add linkedca conversions.
2022-01-04 18:42:57 -08:00
Mariano Cano
de51c2edfb
More unit tests for nebula.
2022-01-04 18:16:41 -08:00
Mariano Cano
99845d38bb
Add some extra unit tests for nebula.
2022-01-04 12:06:44 -08:00
Mariano Cano
76794ce613
Use default SANs without sans in the token.
...
Fix step claim condition in SSH
2022-01-04 12:05:58 -08:00
Mariano Cano
9ec0276887
Update certificate set with new api.
2022-01-03 18:54:01 -08:00
Mariano Cano
cb72796a2d
Fix decoding of certificate.
2021-12-29 16:07:05 -08:00
Mariano Cano
32390a2964
Add initial implementation of a nebula provisioner.
...
A nebula provisioner will generate a X509 or SSH certificate with
the identities in the nebula certificate embedded in the token.
The token is signed with the private key of the nebula certificate.
2021-12-29 14:12:03 -08:00
Herman Slatman
5fe9909174
Refactor AdminAuthority interface
2021-12-22 15:30:40 +01:00
Herman Slatman
f9ae875f9d
Use short if-style statements
2021-12-20 14:30:01 +01:00
Herman Slatman
5f224b729e
Add tests for Provisioner Admin API
2021-12-09 23:15:38 +01:00
Herman Slatman
43a78f495f
Add tests for Admin API
2021-12-09 17:29:23 +01:00
Herman Slatman
bd169f505f
Add Admin API Middleware tests
2021-12-09 15:26:18 +01:00
Herman Slatman
d799359917
Merge branch 'master' into hs/acme-eab
2021-12-09 13:58:40 +01:00
Herman Slatman
63371a8fb6
Add additional tests for ACME EAB Admin
2021-12-09 13:46:47 +01:00
Herman Slatman
3bc3957b06
Merge branch 'master' into hs/acme-revocation
2021-12-09 09:36:52 +01:00
Herman Slatman
2215a05c28
Add tests for ACME EAB Admin
...
Refactored some of the existing bits for testing the Authority
API by creation of a new LinkedAuthority interface and changing
visibility of the MockAuthority to be usable by other packages.
At this time, not all of the functions of MockAuthority it usable
yet. Will refactor when needed or requested.
2021-12-08 15:19:38 +01:00
Herman Slatman
d0c23973cc
Merge branch 'master' into hs/acme-eab
2021-12-06 13:01:23 +01:00
Mariano Cano
e0fee84694
Add comment about public key validator.
2021-12-03 15:24:42 -08:00
Herman Slatman
47a8a3c463
Add test case for ACME Revoke to Authority
2021-12-02 17:11:36 +01:00
Herman Slatman
a7fbbc4748
Add tests for GetCertificateBySerial
2021-11-28 21:20:57 +01:00
Herman Slatman
2d357da99b
Add tests for ACME revocation
2021-11-26 17:27:42 +01:00
Herman Slatman
c9cd876a7d
Merge branch 'master' into hs/acme-revocation
2021-11-25 00:40:56 +01:00
Mariano Cano
d35848f7a9
Fix unit tests.
2021-11-24 11:43:24 -08:00
Mariano Cano
c3f98fd04d
Change some bad requests to forbidded.
...
Change in the sign options bad requests to forbidded if is the
provisioner the one adding a restriction, e.g. list of dns names,
validity, ...
2021-11-24 11:32:35 -08:00
Mariano Cano
ff04873a2a
Change the default error type to forbidden in Sign.
...
The errors will also be propagated from sign options.
2021-11-23 18:58:16 -08:00
Mariano Cano
b9beab071d
Fix unit tests.
2021-11-23 18:43:36 -08:00
Mariano Cano
507a272b4d
Return always http errors in sign options.
2021-11-23 18:32:33 -08:00
Mariano Cano
a33709ce8d
Fix sign ssh options tests.
2021-11-23 18:06:18 -08:00
Mariano Cano
1da7ea6646
Return always http errors in sign ssh options.
2021-11-23 17:52:39 -08:00
Mariano Cano
031d4d7000
Return BadRequest when validating sign options.
2021-11-23 17:52:17 -08:00
Mariano Cano
bb26799583
Modify errs.Wrap with forbidden errors.
2021-11-23 12:04:51 -08:00
Herman Slatman
2d50c96d99
Merge branch 'master' into hs/acme-revocation
2021-11-19 17:00:18 +01:00
Mariano Cano
b6ebd118fc
Update temporal solution for sending message to users
2021-11-18 18:47:55 -08:00
Mariano Cano
668d3ea6c7
Modify errs.Wrap() with bad request to send messages to users.
2021-11-18 18:44:58 -08:00
Mariano Cano
8c8db0d4b7
Modify errs.BadRequestErr() to always return an error to the client.
2021-11-18 18:17:36 -08:00
Mariano Cano
8ce807a6cb
Modify errs.BadRequest() calls to always send an error to the client.
2021-11-18 15:12:44 -08:00
Max
de2ce5cf9f
Merge pull request #692 from smallstep/max/context
...
Context management
2021-11-17 12:06:42 -08:00
Mariano Cano
440616cffa
Merge pull request #750 from smallstep/duration-errors
...
Report duration errors directly to the cli.
2021-11-17 12:06:31 -08:00
Mariano Cano
acd0bac025
Remove extra and in comment.
2021-11-17 12:03:29 -08:00
Mariano Cano
1aadd63cef
Use always badRequest on duration errors.
2021-11-17 12:00:54 -08:00
Mariano Cano
41fec1577d
Report duration errors directly to the cli.
2021-11-17 11:46:57 -08:00
max furman
7fac8c96c3
Merge branch 'master' into max/context
2021-11-17 11:40:01 -08:00
max furman
922d239171
Simplify conditional
2021-11-16 21:47:14 -08:00
max furman
a7d144996f
SSH backwards compat updates
...
- use existence of new value in data map as boolean
- add tests for backwards and forwards compatibility
- fix old tests that used static dir locations
2021-11-16 21:47:14 -08:00
max furman
507be61e8c
Use a more distint map key to indicate template version
...
- make the key a variable that can be reused on the CLI side.
2021-11-16 21:47:14 -08:00
max furman
f426c152a9
backwards compatibility for version of cli older than v0.18.0
2021-11-16 21:47:14 -08:00
max furman
ed4b56732e
updates after rebase to keep up with master
2021-11-16 21:47:14 -08:00
Herman Slatman
e7a988b2cd
Pin golangci-lint to v1.43.0 and fix issues
2021-11-13 01:30:03 +01:00
Herman Slatman
3151255a25
Merge branch 'master' into hs/acme-revocation
2021-10-30 15:41:29 +02:00
Herman Slatman
4d726d6b4c
Add pagination to ACME EAB credentials endpoint
2021-10-17 22:42:36 +02:00
Herman Slatman
bc5f0e429b
Fix gocritic remark
2021-10-17 12:53:02 +02:00
Herman Slatman
d354d55e7f
Improve handling duplicate ACME EAB references
2021-10-16 14:44:56 +02:00
Herman Slatman
dd4b4b0435
Fix remaining gocritic remarks
2021-10-11 23:34:23 +02:00
Herman Slatman
e0b495e4c8
Merge branch 'master' into hs/acme-eab
2021-10-09 01:06:49 +02:00
Herman Slatman
c26041f835
Add ACME EAB nosql tests
2021-10-09 01:02:00 +02:00
max furman
933b40a02a
Introduce gocritic linter and address warnings
2021-10-08 14:59:57 -04:00
Herman Slatman
f34d68897a
Refactor retrieval of provisioner into middleware
2021-10-08 14:29:44 +02:00
Herman Slatman
9d4cafc4bd
Merge branch 'master' into hs/acme-eab
2021-10-08 10:33:09 +02:00
Mariano Cano
9fb6df3abb
Fix ssh template variables when CA is injected using options.
2021-09-28 18:50:45 -07:00
Mariano Cano
aedd7fcc05
Be able to start a SSH host or SSH user only CA
...
In previous versions if the host or user CA is not configured, the
start of step-ca was crashing. This allows to configure a user or
host only ssh ca.
2021-09-28 15:07:09 -07:00
Mariano Cano
a50654b468
Check for admins in both emails and groups.
2021-09-23 15:49:28 -07:00
max furman
2d5bfd3485
fix comment
2021-09-22 11:56:52 -07:00
Herman Slatman
c2bc1351c6
Add provisioner to remove endpoint and clear reference index on delete
2021-09-17 17:48:09 +02:00
Herman Slatman
746c5c9fd9
Disallow creation of EAB keys with non-unique references
2021-09-17 17:25:19 +02:00
Herman Slatman
9c0020352b
Add lookup by reference and make reference optional
2021-09-17 17:08:02 +02:00
Herman Slatman
02cd3b6b3b
Fix PR comments
2021-09-16 23:09:24 +02:00
Mariano Cano
6729c79253
Add support for setting individual password for ssh and tls keys
...
This change add the following flags:
* --ssh-host-password-file
* --ssh-user-password-file
Fixes #693
2021-09-16 11:55:41 -07:00
Herman Slatman
66464ae302
Merge branch 'master' into hs/acme-eab
2021-09-16 18:20:39 +02:00
Mariano Cano
141c519171
Simplify check of principals in a case insensitive way
...
Fixes #679
2021-09-08 16:00:33 -07:00
Fearghal O Floinn
7a94b0c157
Converts group and subgroup to lowercase for comparison.
...
Fixes #679
2021-09-08 12:24:49 +01:00
Mariano Cano
f919535475
Add an extra way to distinguish Azure and Azure OIDC tokens.
...
We used to distinguish these tokens using the azp claim, but this
claim does not appear on new azure oidc tokens, at least on some
configurations.
This change will try to load by audience (client id) if the token
contains an email, required for OIDC.
2021-08-30 16:37:29 -07:00
Mariano Cano
097a918da7
Fix tests when we create re-use a token with a new authority.
2021-08-30 16:36:18 -07:00
Herman Slatman
f11c0cdc0c
Add endpoint for listing ACME EAB keys
2021-08-27 16:58:04 +02:00
Herman Slatman
9d09f5e575
Add support for deleting ACME EAB keys
2021-08-27 14:10:00 +02:00
Herman Slatman
a98fe03e80
Merge branch 'master' into hs/acme-eab
2021-08-27 12:50:19 +02:00
Herman Slatman
1dba8698e3
Use LinkedCA.EABKey type in ACME EAB API
2021-08-27 12:39:37 +02:00
Mariano Cano
40e77f6e9a
Initialize required variables on GetIdentityToken
...
Fixes smallstep/cli#465
2021-08-26 17:56:40 -07:00
Mariano Cano
42fde8ba28
Merge branch 'master' into linkedca
2021-08-25 15:56:50 -07:00
Mariano Cano
61b8bfda1a
Fix comment typos.
2021-08-23 15:18:54 -07:00
Mariano Cano
da2802504b
Use Default min version if not specified.
2021-08-11 15:33:45 -07:00
Mariano Cano
d4ae267add
Fix ErrAllowTokenReuse comment.
2021-08-11 14:59:26 -07:00
Mariano Cano
9e5762fe06
Allow the reuse of azure token if DisableTrustOnFirstUse is true
...
Azure caches tokens for 24h and we cannot issue a new certificate
for the same instance in that period of time.
The meaning of this parameter is to allow the signing of multiple
certificate in one instance. This is possible in GCP, because we
get a new token, and is possible in AWS because we can generate
a new one. On Azure there was no other way to do it unless you
wait for 24h.
Fixes #656
2021-08-11 11:50:54 -07:00
Mariano Cano
492ff4b632
Ask for the first provisioner password if none is provided.
2021-08-10 17:30:33 -07:00
Mariano Cano
28e882c9b3
Add deployment type to export.
2021-08-10 17:14:17 -07:00
Mariano Cano
072ba4227c
Add deployment type to config.
...
This field is ignored except for the start of the ca. If the type
is linked and the token is not passed, it will fail with an error.
2021-08-10 17:07:15 -07:00
Herman Slatman
f31ca4f6a4
Add tests for validateExternalAccountBinding
2021-08-10 12:39:44 +02:00
Herman Slatman
492256f2d7
Add first test cases for EAB and make provisioner unique per EAB
...
Before this commit, EAB keys could be used CA-wide, meaning that
an EAB credential could be used at any ACME provisioner. This
commit changes that behavior, so that EAB credentials are now
intended to be used with a specific ACME provisioner. I think
that makes sense, because from the perspective of an ACME client
the provisioner is like a distinct CA.
Besides that this commit also includes the first tests for EAB.
The logic for creating the EAB JWS as a client has been taken
from github.com/mholt/acmez. This logic may be moved or otherwise
sourced (i.e. from a vendor) as soon as the step client also
(needs to) support(s) EAB with ACME.
2021-08-09 10:37:32 +02:00
Herman Slatman
71b3f65df1
Add processing of RequireEAB through Linked CA
2021-08-07 01:33:08 +02:00
Mariano Cano
536536c92d
Wrap json errors.
2021-08-06 14:55:17 -07:00
Mariano Cano
9d51c2cceb
Fix linter errors in the name of export methods.
2021-08-06 14:29:54 -07:00
Mariano Cano
16d3afb92a
Remove unused method.
2021-08-06 12:37:20 -07:00
Mariano Cano
d72fa953ac
Remove debug statements.
2021-08-05 18:50:18 -07:00
Mariano Cano
3f07eb597a
Implement revocation using linkedca.
2021-08-05 18:45:50 -07:00
Mariano Cano
798b90c359
Move linkedca configuration to the main package.
2021-08-04 20:15:04 -07:00
Mariano Cano
384be6e205
Do not show provisioners if they are not required.
...
For deployment types like linked ca, the list of provisioners in
the ca.json are not required, so we should tag the json as omitempty.
2021-08-02 15:34:39 -07:00
Mariano Cano
b0e0f2b89d
Use linkedca GetAdmin and GetProvisioner.
2021-08-02 14:45:59 -07:00
Mariano Cano
91a369f618
Automatically enable admin properly on linked cas.
2021-08-02 12:13:39 -07:00
Mariano Cano
26122a2cbf
Enable admin automatically if a token is provided.
2021-08-02 11:48:37 -07:00
Mariano Cano
2620c38aee
Add is converting provisioners to linkedca.
...
The ids are required to be able to link admins with provisioners.
2021-07-28 18:05:57 -07:00
Mariano Cano
e62d7988b8
Do not store password on exports.
2021-07-28 15:22:21 -07:00
Mariano Cano
4f27f4b002
Change default ciphersuites to newer names.
2021-07-28 13:56:05 -07:00
Mariano Cano
07f7316851
Add bastion to export.
2021-07-27 19:22:29 -07:00
Mariano Cano
0730a165fd
Add collection of files and authority template.
2021-07-27 19:19:58 -07:00
Mariano Cano
c7f8516142
Add to export all the information in the ca.json
2021-07-27 18:29:29 -07:00
Mariano Cano
887423ee6e
Update TLS cipher suites.
2021-07-27 18:29:10 -07:00
Mariano Cano
dc1ec18b52
Create a way to export ca configurations.
2021-07-26 19:01:56 -07:00
Mariano Cano
3a00b6b396
Properly marshal a certificate when we send it to linkedca.
2021-07-26 14:31:42 -07:00
Mariano Cano
4ad82a2f76
Check linkedca for revocation.
2021-07-23 16:10:13 -07:00
Herman Slatman
7dad7038c3
Fix missing ACME EAB API endpoints
2021-07-23 15:41:24 +02:00
Herman Slatman
c6a4c4ecba
Change ACME EAB endpoint
2021-07-23 15:16:11 +02:00
Herman Slatman
c6bfc6eac2
Fix PR comments
2021-07-22 23:48:41 +02:00
Herman Slatman
b65a588d5b
Make authentication work for /admin/eak
2021-07-22 22:43:21 +02:00
Mariano Cano
f7542a5bd9
Move check of ssh revocation from provisioner to the authority.
2021-07-21 15:22:57 -07:00
Mariano Cano
71f8019243
Store x509 and ssh certificates on linkedca if enabled.
2021-07-20 18:16:24 -07:00
Mariano Cano
8fb5340dc9
Use a token at start time to configure linkedca.
...
Instead of using `step-ca login` we will use a new token provided
as a flag to configure and start linkedca. Certificates will be kept
in memory and refreshed automatically.
2021-07-19 19:28:06 -07:00
Herman Slatman
f81d49d963
Add first working version of External Account Binding
2021-07-17 17:35:44 +02:00
Mariano Cano
dd9850ce4c
Add working implementation of the linkedca.
...
Replaces the authority adminDB with a new impmentation that users the
linkedca client to retrieve the data.
Note that this implementation still hardcodes the endpoint to localhost.
2021-07-12 18:11:00 +02:00
Mariano Cano
49c1427d15
Use authorityId instead of authorityID.
...
In json or javascript world authorityId, userId, ... are more common
than authorityID, ...
2021-07-12 15:31:05 +02:00
Herman Slatman
258efca0fa
Improve revocation authorization
2021-07-10 00:28:31 +02:00
Herman Slatman
8f7e700f09
Merge branch 'master' into hs/acme-revocation
2021-07-09 11:22:25 +02:00
max furman
1df21b9b6a
Addressing comments in PR review
...
- added a bit of validation to admin create and update
- using protojson where possible in admin api
- fixing a few instances of admin -> acme in errors
2021-07-06 17:14:13 -07:00
max furman
5679c9933d
Fixes from PR review
2021-07-03 12:08:30 -07:00
max furman
77fdfc9fa3
Merge branch 'master' into max/cert-mgr-crud
2021-07-02 20:26:46 -07:00
max furman
9fdef64709
Admin level API for provisioner mgmt v1
2021-07-02 19:05:17 -07:00
Herman Slatman
84e7d468f2
Improve handling of ACME revocation
2021-07-03 00:21:17 +02:00
Herman Slatman
7e82bd6ef3
Add setup for Authority tests
2021-05-26 16:15:26 -07:00
Herman Slatman
a64974c179
Fix small typo in divisible
2021-05-26 16:15:26 -07:00
Herman Slatman
d46a4eaca4
Change fmt to errors package for formatting errors
2021-05-26 16:15:26 -07:00
Herman Slatman
2beea1aa89
Add configuration option for specifying the minimum public key length
...
Instead of using the defaultPublicKeyValidator a new validator called
publicKeyMinimumLengthValidator has been implemented that uses a
configurable minimum length for public keys in CSRs.
It's also an option to alter the defaultPublicKeyValidator to also
take a parameter, but that would touch quite some lines of code. This
might be a viable option after merging SCEP support.
2021-05-26 16:15:26 -07:00
Herman Slatman
4168449935
Fix typo
2021-05-26 16:15:26 -07:00
Herman Slatman
fa100a5138
Mask challenge password after it has been read
2021-05-26 16:15:26 -07:00
Herman Slatman
13fe7a0121
Make serving SCEP endpoints optional
...
Only when a SCEP provisioner is enabled, the SCEP endpoints
will now be available.
The SCEP endpoints will be served on an "insecure" server,
without TLS, only when an additional "insecureAddress" and a
SCEP provisioner are configured for the CA.
2021-05-26 16:13:57 -07:00
Herman Slatman
97b88c4d58
Address (most) PR comments
2021-05-26 16:12:57 -07:00
Herman Slatman
be528da709
Make tests green
2021-05-26 16:10:22 -07:00
Herman Slatman
57a62964b1
Make tests not fail hard on ECDSA keys
...
All tests for the Authority failed because the test data
contains ECDSA keys. ECDSA keys are no crypto.Decrypter,
resulting in a failure when instantiating the Authority.
2021-05-26 16:10:22 -07:00
Herman Slatman
491c2b8d93
Improve initialization of SCEP authority
2021-05-26 16:10:21 -07:00
Herman Slatman
2d85d4c1c1
Add non-TLS server and improve crypto.Decrypter interface
...
A server without TLS was added to serve the SCEP endpoints. According
to the RFC, SCEP has to be served via HTTP. The `sscep` client, for
example, will stop any URL that does not start with `http://` from
being used, so serving SCEP seems to be the right way to do it.
This commit adds a second server for which no TLS configuration is
configured. A distinct field in the configuration, `insecureAddress`
was added to specify the address for the insecure server.
The SCEP endpoints will also still be served via HTTPS. Some clients
may be able to work with that.
This commit also improves how the crypto.Decrypter interface is
handled for the different types of KMSes supported by step. The
apiv1.Decrypter interface was added. Currently only SoftKMS
implements this interface, providing a crypto.Decrypter required
for SCEP operations.
2021-05-26 16:09:38 -07:00
Herman Slatman
e7cb80f880
Fix linter issues
2021-05-26 16:08:24 -07:00
Herman Slatman
4fe7179b95
Add support for configuring capabilities (cacaps)
2021-05-26 16:08:24 -07:00
Herman Slatman
3b86550dbf
Add support for challenge password
2021-05-26 16:08:24 -07:00
Herman Slatman
da65f46d0f
Add AuthorizeSign method to SCEP authority
2021-05-26 16:04:21 -07:00
Herman Slatman
2a249d20de
Refactor initialization of SCEP authority
2021-05-26 16:04:19 -07:00
Herman Slatman
339039768c
Refactor SCEP authority initialization and clean some code
2021-05-26 16:00:08 -07:00
Herman Slatman
48c86716a0
Add rudimentary (and incomplete) support for SCEP
2021-05-26 15:58:04 -07:00
max furman
94ba057f01
wip
2021-05-26 14:55:31 -07:00
max furman
01a4460812
wip
2021-05-25 21:13:01 -07:00
max furman
1726076ea2
wip
2021-05-25 16:52:06 -07:00
max furman
423942da44
wip
2021-05-24 13:38:24 -07:00
