David Cowden
86efe7aff0
aws: use http.NoBody instead of nil
...
It's a little more descriptive.
2020-07-22 18:39:46 -07:00
David Cowden
2b121efc8f
aws: test constructor with empty IDMS string array
2020-07-22 18:33:44 -07:00
Mariano Cano
6c64fb3ed2
Rename provisioner options structs:
...
* provisioner.ProvisionerOptions => provisioner.Options
* provisioner.Options => provisioner.SignOptions
* provisioner.SSHOptions => provisioner.SingSSHOptions
2020-07-22 18:24:45 -07:00
David Cowden
dc39eef721
aws: test badIDMS functional path
...
The existing test only covers the constructor logic. Also test the live
code path that is executed when a bad IDMS version is supplied.
2020-07-22 17:40:26 -07:00
David Cowden
51f16ee2e0
aws: add tests covering metadata service versions
...
* Add constructor tests for the aws provisioner.
* Add a test to make sure the "v1" logic continues to work.
By and large, v2 is the way to go. However, there are some instances of
things that specifically request metadata service version 1 and so this
adds minimal coverage to make sure we don't accidentally break the path
should anyone need to depend on the former logic.
2020-07-22 16:52:06 -07:00
David Cowden
5efe5f3573
metadata-v2: pull in joshathysolate-master
...
Taking of this PR to get it across the goal line.
2020-07-22 04:15:34 -07:00
Mariano Cano
978ad7e2b6
Fix merged tests.
2020-07-21 14:34:55 -07:00
Mariano Cano
5ac3f8a160
Add provisioner options tests.
2020-07-21 14:21:54 -07:00
Mariano Cano
02c4f9817d
Set full token payload instead of only the known properties.
2020-07-21 14:21:54 -07:00
Mariano Cano
0c8376a7f6
Fix existing unit tests.
2020-07-21 14:21:54 -07:00
Mariano Cano
d64cb99a22
Fix authority package tests.
2020-07-21 14:21:48 -07:00
Mariano Cano
ccc705cdcd
Use alias x509legacy to cli x509util in tls.go.
2020-07-21 14:20:48 -07:00
Mariano Cano
8f0dd811af
Allow to send errors from template to cli.
2020-07-21 14:18:06 -07:00
Mariano Cano
a7fe0104c4
Remove ACME restrictions and add proper template support.
2020-07-21 14:18:06 -07:00
Mariano Cano
cf2989a848
Add token and subject to K8sSA provisioner to be used in custom
...
templates.
2020-07-21 14:18:06 -07:00
Mariano Cano
71be83b25e
Add iss#sub uri in OIDC certificates.
...
Admin will use the CR template if none is provided.
2020-07-21 14:18:06 -07:00
Mariano Cano
c58117b30d
Allow to use base64 when defining a template in the ca.json.
2020-07-21 14:18:06 -07:00
Mariano Cano
b2ca3176f5
Prepend insecure to user and CR variables names.
2020-07-21 14:18:06 -07:00
Mariano Cano
b11486f41f
Fix option method for template variable.
2020-07-21 14:18:06 -07:00
Mariano Cano
04f5053a7a
Add template support for x5c.
2020-07-21 14:18:06 -07:00
Mariano Cano
eb8886d828
Add CR subject as iid default subject.
...
Add a minimal subject with just a common name to iid provisioners
in case we want to use it.
2020-07-21 14:18:06 -07:00
Mariano Cano
e60ea419cc
Add template support for gcp provisioner.
2020-07-21 14:18:06 -07:00
Mariano Cano
32646c49bf
Add templates support to Azure provisioner.
2020-07-21 14:18:06 -07:00
Mariano Cano
a44f0ca866
Add token payload.
2020-07-21 14:18:06 -07:00
Mariano Cano
00fd41a3d0
Add template support to K8sSA provisioners.
2020-07-21 14:18:06 -07:00
Mariano Cano
13b704aeed
Add template support for AWS provisioner.
2020-07-21 14:18:05 -07:00
Mariano Cano
49b9aa6e3f
Fix log string.
2020-07-21 14:18:05 -07:00
Mariano Cano
4795e371bd
Add back the support for ca.json DN template.
2020-07-21 14:18:05 -07:00
Mariano Cano
e6fed5e0aa
Minor fixes and comments.
2020-07-21 14:18:05 -07:00
Mariano Cano
81cd288104
Enable templates in acme provisioners.
2020-07-21 14:18:05 -07:00
Mariano Cano
ca2fb42d68
Move options to the provisioner.
2020-07-21 14:18:05 -07:00
Mariano Cano
206bc6757a
Add initial support for templates in the OIDC provisioner.
2020-07-21 14:18:05 -07:00
Mariano Cano
95c3a41bf0
Rename UserData to TemplateData and fix unmarshaling.
2020-07-21 14:18:04 -07:00
Mariano Cano
9f3acc254b
Set the token payload in the JWK provisioner.
2020-07-21 14:18:04 -07:00
Mariano Cano
ef0ed0ff95
Integrate simple templates in the JWK provisioner.
2020-07-21 14:18:04 -07:00
Mariano Cano
d1d9ae42d6
Use certificates x509util instead of cli for certificate signing.
2020-07-21 14:18:04 -07:00
Mariano Cano
9032018cf2
Convert x509util.WithOptions to new modifiers.
2020-07-21 14:18:04 -07:00
Carl Tashian
912e298043
Whitelist -> Allowlist per https://tools.ietf.org/id/draft-knodel-terminology-01.html
2020-07-20 15:42:47 -07:00
max furman
fd05f3249b
A few last fixes and tests added for rekey/renew ...
...
- remove all `renewOrRekey`
- explicitly test difference between renew and rekey (diff pub keys)
- add back tests for renew
2020-07-09 12:11:40 -07:00
Max
ea9bc493b8
Merge pull request #307 from dharanikumar-s/master
...
Add support for rekeying Fixes #292
2020-07-09 11:39:00 -07:00
dharanikumar-s
57fb0c80cf
Removed calculating SubjectKeyIdentifier on Rekey
2020-07-08 12:52:53 +05:30
dharanikumar-s
dfda497929
Renamed RenewOrRekey to Rekey
2020-07-08 11:47:59 +05:30
dharanikumar-s
fe73154a20
Corrected misspelling
2020-07-05 22:50:02 +05:30
dharanikumar-s
0c21f0ae9e
Added error check after GenerateDefaultKeyPair
2020-07-05 22:38:45 +05:30
dharanikumar-s
2479371c06
Added error check while marshalling public key
2020-07-05 22:37:29 +05:30
dharanikumar-s
b368a53149
Modified TestAuthority_Renew to TestAuthority_RenewOrRekey
2020-07-05 22:17:57 +05:30
dharanikumar-s
c8c3581e2f
SubjectKeyIdentifier extention is calculated from public key passed to this function instead of copying from old certificate
2020-07-05 22:15:01 +05:30
dharanikumar-s
8f504483ce
Added RenewOrRekey function based on @maraino suggestion. RenewOrReky is called from Renew.
2020-07-03 15:58:15 +05:30
dharanikumar-s
3813f57b1a
Add support for rekeying Fixes #292
2020-07-01 19:10:13 +05:30
Max
debce1cec2
Merge pull request #299 from smallstep/max/refactor
...
Refactor
2020-06-25 15:32:04 -07:00
max furman
accf1be7e9
wip
2020-06-25 14:02:24 -07:00
max furman
71d87b4e61
wip
2020-06-24 23:25:15 -07:00
max furman
d25e7f64c2
wip
2020-06-24 09:58:40 -07:00
max furman
3636ba3228
wip
2020-06-23 17:13:39 -07:00
Mariano Cano
39650637d4
Merge pull request #297 from smallstep/no-bastion-bastion
...
Do not return bastion for the configured bastion host.
2020-06-23 11:45:25 -07:00
Mariano Cano
fcfc4e9b2b
Fix ssh federated template variables.
2020-06-23 11:14:26 -07:00
max furman
1951669e13
wip
2020-06-23 11:10:45 -07:00
Mariano Cano
b0fdd0b2be
Do not return bastion for the configured bastion host.
...
Fixes #296
2020-06-19 12:37:08 -07:00
Mariano Cano
ff32746312
Add test case for error executing template.
2020-06-16 18:21:44 -07:00
Mariano Cano
e3ae751b57
Use templates from authority instead of config.
2020-06-16 17:57:35 -07:00
Mariano Cano
237baa5169
Check for required variables in templates.
...
Fixes smallstep/cli#232
2020-06-16 17:26:54 -07:00
Mariano Cano
6c844a0618
Load default templates if no templates are configured.
2020-06-16 17:26:18 -07:00
Max
2ebfc73f77
Merge pull request #290 from smallstep/max/profileLimit
...
Update profileLimitDuration validator ...
2020-06-16 13:04:34 -07:00
max furman
7d5cf34ce5
Update profileLimitDuration validator ...
...
- respect notBefore of the provisioner
- modify/fix the reported errors
2020-06-16 12:16:43 -07:00
Mariano Cano
9832d1538b
Avoid nil pointer panic on step ssh config with no templates.
2020-06-15 17:25:47 -07:00
Mariano Cano
4ac51dd508
Merge pull request #274 from smallstep/oidc-raw-locals
...
Allow dots and other symbols in principals for OIDC
2020-05-26 11:28:30 -07:00
Mariano Cano
3246a3e81f
Add missing test case.
2020-05-26 10:22:15 -07:00
max furman
6e69f99310
Always set nbf and naf for new ACME orders ...
...
- Use the default value from the ACME provisioner if values are not
defined in the request.
2020-05-22 10:31:58 -07:00
Mariano Cano
0b5fd156e8
Add a third principal on OIDC tokens with the raw local part of the email.
...
For the email first.last@example.com it will create the principals
["firstlast", "first.last", "first.last@example.com"]
Fixes #253 , #254
2020-05-21 12:09:11 -07:00
Josh Hogle
e9b500daf2
Updated error message
2020-05-20 14:43:25 -04:00
Josh Hogle
044d00045a
Fixed missing initialization of IMDS versions
2020-05-20 13:24:45 -04:00
Josh Hogle
18ac5c07e2
Added support for specifying IMDS version preference
2020-05-20 13:15:51 -04:00
Josh Hogle
8c6a46887b
Added token URL fixes to tests
2020-05-20 09:39:19 -04:00
Josh Hogle
dd27901b12
Moved token URL and TTL to config values
2020-05-20 09:03:35 -04:00
Josh Hogle
bbbe4738c7
Added status code checking
2020-05-19 23:57:09 -04:00
Josh Hogle
af0f21d744
added support for IMDSv2 API
2020-05-19 18:42:12 -04:00
Mariano Cano
2bc69d3edd
Merge pull request #252 from smallstep/yubikey
...
Yubikey support
2020-05-19 13:47:33 -07:00
Oleksandr Kovalchuk
4cd01b6868
Implement tests for forceCNOption modifier
...
Implement unit tests which checks forceCNOption modifier (implemented
in 322200b7db
) is not broken and works
correctly.
Ref: https://github.com/smallstep/certificates/issues/259
2020-05-17 20:29:28 +03:00
Oleksandr Kovalchuk
893a53793a
Modify existing tests to accept forceCNOption modifier
...
Modify existing tests to pass with changes introduced in commit
322200b7db
. This is safe to do as
tests assert exact length of modifiers, which has changed.
2020-05-17 20:27:09 +03:00
Oleksandr Kovalchuk
322200b7db
Implement modifier to set CommonName
...
Implement modifier which sets CommonName to the certificate if
CommonName is empty and forceCN is set in the config. Replace previous
implementation introduced in 0218018cee
with new modifier.
Closes https://github.com/smallstep/certificates/issues/259
Ref: https://github.com/smallstep/certificates/pull/260#issuecomment-628961322
2020-05-17 20:23:13 +03:00
Oleksandr Kovalchuk
503c9f6101
Add config option to force CN
...
Add configuration option `forceCN` to ACME provisioner. When this option
is set to `true`, provisioner should generate Subject.CommonName for
certificate if it was not present in the request. Default value of
`false` should keep the existing behavior (do not modify CSR and
certificate).
Ref: https://github.com/smallstep/certificates/issues/259
2020-05-14 13:20:55 +03:00
Mariano Cano
c02fe77998
Close the key manager before shutting down.
2020-05-07 18:59:30 -07:00
Mariano Cano
4e544344f9
Initialize the required config fields on embedded authorities.
...
This change is to make easier the use of embedded authorities. It
can be difficult for third parties to know what fields are required.
The new init methods will define the minimum usable configuration.
2020-05-06 13:00:42 -07:00
Mariano Cano
b5eab009b2
Rename method to NewEmbedded
2020-05-05 17:46:22 -07:00
Mariano Cano
824374bde0
Create a method to initialize the authority without a config file.
...
When the CA is embedded in a third party product like Caddy, the
config needed to use placeholders to be valid. This change adds
a new method `NewEmbeddedAuthority` that allows to create an
authority with the given options, the minimum options are a root
and intermediate certificate, and the intermediate key.
Fixes #218
2020-05-04 18:52:18 -07:00
Mariano Cano
4e9bff0986
Add support for OIDC multitoken tenants for azure.
2020-04-24 14:36:32 -07:00
Mariano Cano
8bc3b05232
Add new extra test case.
2020-04-24 10:27:44 -07:00
Mariano Cano
b0ff731d18
Add support for user provisioner certificates on OIDC provisioners.
...
OIDC provisioners create an SSH certificate with two principals. This
was avoiding the creationg of user provisioner certificates for those
provisioners.
Fixes smallstep/cli#268
2020-04-23 19:42:55 -07:00
Mariano Cano
a2dfa6faa8
Fix unit tests.
2020-04-20 12:29:23 -07:00
Mariano Cano
13507efb35
Remove the requirement for CSR to have a common name.
...
Fixes #226
2020-04-20 10:43:33 -07:00
Mariano Cano
02ed784a9b
Do not enable by default ForwardAgent.
2020-04-15 11:17:24 -07:00
Mariano Cano
bfe1f4952d
Rename interface to CertificateEnforcer and add tests.
2020-03-31 11:41:36 -07:00
Mariano Cano
64f26c0f40
Enforce a duration for identity certificates.
2020-03-30 17:33:04 -07:00
Mariano Cano
fa416336a8
Add context to tests.
2020-03-10 19:17:32 -07:00
Mariano Cano
c49a9d5e33
Add context parameter to all SSH methods.
2020-03-10 19:01:45 -07:00
Mariano Cano
f868e07a76
Allow to use custom principals on cloud provisioners.
...
Fixes #203
2020-03-05 14:33:42 -08:00
Mariano Cano
59fc8cdd2d
Fix typo in comments.
2020-02-27 10:48:16 -08:00
Mariano Cano
5c8c741fab
Fix linting issues.
2020-02-14 11:46:31 -08:00
Mariano Cano
05cc1437b7
Remove unnecessary parse of certificate.
2020-02-13 17:48:43 -08:00
Mariano Cano
2d4f369db2
Add options to set root and federated certificates using x509.Certificate
2020-02-12 15:36:24 -08:00