mbiryukova/lego
1
0
Fork 0
forked from TrueCloudLab/lego
Code Pull requests Activity

Merge pull request #136 from xi2/fix-handling-of-cnames

Browse source 
DNS Challenge: Fix handling of CNAMEs
This commit is contained in:
xenolf 2016-02-20 01:24:12 +01:00
commit 7dcfb4a92b
1 changed files with 8 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
acme/dns_challenge.go
View file

@ -82,10 +82,7 @@ func checkDNSPropagation(fqdn, value string) (bool, error) {
if err != nil { if err != nil {
return false, err return false, err
} }
if r.Rcode != dns.RcodeSuccess { if r.Rcode == dns.RcodeSuccess {
return false, fmt.Errorf("Could not resolve %s -> %s", fqdn, dns.RcodeToString[r.Rcode])
}
// If we see a CNAME here then use the alias // If we see a CNAME here then use the alias
for _, rr := range r.Answer { for _, rr := range r.Answer {
if cn, ok := rr.(*dns.CNAME); ok { if cn, ok := rr.(*dns.CNAME); ok {
@ -95,6 +92,7 @@ func checkDNSPropagation(fqdn, value string) (bool, error) {
} }
} }
} }
}
authoritativeNss, err := lookupNameservers(fqdn) authoritativeNss, err := lookupNameservers(fqdn)
if err != nil { if err != nil {