[#143] Change network utils

Signed-off-by: Dmitriy Zayakin <d.zayakin@yadro.com>

src/frostfs_testlib/storage/controllers/cluster_state_controller.py

@@ -13,7 +13,7 @@ from frostfs_testlib.plugins import load_all
 from frostfs_testlib.resources.cli import FROSTFS_ADM_CONFIG_PATH, FROSTFS_ADM_EXEC, FROSTFS_CLI_EXEC
 from frostfs_testlib.resources.common import DEFAULT_WALLET_CONFIG, MORPH_BLOCK_TIME
 from frostfs_testlib.shell import CommandOptions, Shell, SshConnectionProvider
-from frostfs_testlib.steps.network import IfUpDownHelper, IpTablesHelper
+from frostfs_testlib.steps.network import IpHelper
 from frostfs_testlib.storage.cluster import Cluster, ClusterNode, S3Gate, StorageNode
 from frostfs_testlib.storage.controllers.disk_controller import DiskController
 from frostfs_testlib.storage.dataclasses.node_base import NodeBase, ServiceClass
@@ -22,7 +22,6 @@ from frostfs_testlib.testing.test_control import retry, run_optionally, wait_for
 from frostfs_testlib.utils.datetime_utils import parse_time
 
 logger = logging.getLogger("NeoLogger")
-if_up_down_helper = IfUpDownHelper()
 
 
 class StateManager:
@@ -305,57 +304,25 @@ class ClusterStateController:
             [node.host.wait_success_resume_process(process_name) for node in list_nodes]
         self.suspended_services = {}
 
-    @reporter.step("Drop traffic to {node}, with ports - {ports}, nodes - {block_nodes}")
+    @reporter.step("Drop traffic to {node}, nodes - {block_nodes}")
     def drop_traffic(
         self,
-        mode: str,
         node: ClusterNode,
         wakeup_timeout: int,
-        ports: list[str] = None,
+        name_interface: str,
         block_nodes: list[ClusterNode] = None,
     ) -> None:
-        allowed_modes = ["ports", "nodes"]
-        assert mode in allowed_modes
-
-        match mode:
-            case "ports":
-                IpTablesHelper.drop_input_traffic_to_port(node, ports)
-            case "nodes":
-                list_ip = self._parse_intefaces(block_nodes)
-                IpTablesHelper.drop_input_traffic_to_node(node, list_ip)
+        list_ip = self._parse_interfaces(block_nodes, name_interface)
+        IpHelper.drop_input_traffic_to_node(node, list_ip)
         time.sleep(wakeup_timeout)
         self.dropped_traffic.append(node)
 
-    @reporter.step("Ping traffic")
-    def ping_traffic(
-        self,
-        node: ClusterNode,
-        nodes_list: list[ClusterNode],
-        expect_result: int,
-    ) -> bool:
-        shell = node.host.get_shell()
-        options = CommandOptions(check=False)
-        ips = self._parse_intefaces(nodes_list)
-        for ip in ips:
-            code = shell.exec(f"ping {ip} -c 1", options).return_code
-            if code != expect_result:
-                return False
-        return True
-
     @reporter.step("Start traffic to {node}")
     def restore_traffic(
         self,
-        mode: str,
         node: ClusterNode,
     ) -> None:
-        allowed_modes = ["ports", "nodes"]
-        assert mode in allowed_modes
-
-        match mode:
-            case "ports":
-                IpTablesHelper.restore_input_traffic_to_port(node=node)
-            case "nodes":
-                IpTablesHelper.restore_input_traffic_to_node(node=node)
+        IpHelper.restore_input_traffic_to_node(node=node)
 
     @reporter.step("Restore blocked nodes")
     def restore_all_traffic(self):
@@ -385,22 +352,25 @@ class ClusterStateController:
     @reporter.step("Down {interface} to {nodes}")
     def down_interface(self, nodes: list[ClusterNode], interface: str):
         for node in nodes:
-            if_up_down_helper.down_interface(node=node, interface=interface)
-            assert if_up_down_helper.check_state(node=node, interface=interface) == "DOWN"
+            node.host.down_interface(interface=interface)
+            assert node.host.check_state(interface=interface) == "DOWN"
             self.nodes_with_modified_interface.append(node)
 
     @reporter.step("Up {interface} to {nodes}")
     def up_interface(self, nodes: list[ClusterNode], interface: str):
         for node in nodes:
-            if_up_down_helper.up_interface(node=node, interface=interface)
-            assert if_up_down_helper.check_state(node=node, interface=interface) == "UP"
+            node.host.up_interface(interface=interface)
+            assert node.host.check_state(interface=interface) == "UP"
             if node in self.nodes_with_modified_interface:
                 self.nodes_with_modified_interface.remove(node)
 
     @reporter.step("Restore interface")
     def restore_interfaces(self):
         for node in self.nodes_with_modified_interface:
-            if_up_down_helper.up_all_interface(node)
+            dict_interfaces = node.host.config.interfaces.keys()
+            for name_interface in dict_interfaces:
+                if "mgmt" not in name_interface:
+                    node.host.up_interface(interface=name_interface)
 
     @reporter.step("Get node time")
     def get_node_date(self, node: ClusterNode) -> datetime:
@@ -523,15 +493,14 @@ class ClusterStateController:
         return disk_controller
 
     def _restore_traffic_to_node(self, node):
-        IpTablesHelper.restore_input_traffic_to_port(node)
-        IpTablesHelper.restore_input_traffic_to_node(node)
+        IpHelper.restore_input_traffic_to_node(node)
 
-    def _parse_intefaces(self, nodes: list[ClusterNode]):
+    def _parse_interfaces(self, nodes: list[ClusterNode], name_interface: str):
         interfaces = []
         for node in nodes:
             dict_interfaces = node.host.config.interfaces
             for type, ip in dict_interfaces.items():
-                if "mgmt" not in type:
+                if name_interface in type:
                     interfaces.append(ip)
         return interfaces