olefirenque/frostfs-sdk-go
1
0
Fork 0
forked from TrueCloudLab/frostfs-sdk-go
Code Pull requests Activity

[#227] netmap/test: Assert source placement builder is pure for nodes

Browse source 
`GetContainerNodes` / `GetPlacementVectors` must not mutate source slice
of nodes.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
Leonard Lyubich 2022-06-07 04:59:21 +03:00 committed by LeL
parent 9c47fca7c2
commit 2b21146185
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
netmap/json_test.go
View file

@ -52,6 +52,9 @@ func TestPlacementPolicy_Interopability(t *testing.T) {
var tc TestCase var tc TestCase
require.NoError(t, json.Unmarshal(bs, &tc), "cannot unmarshal %s", ds[i].Name()) require.NoError(t, json.Unmarshal(bs, &tc), "cannot unmarshal %s", ds[i].Name())
srcNodes := make([]NodeInfo, len(tc.Nodes))
copy(srcNodes, tc.Nodes)
t.Run(tc.Name, func(t *testing.T) { t.Run(tc.Name, func(t *testing.T) {
nodes := NodesFromInfo(tc.Nodes) nodes := NodesFromInfo(tc.Nodes)
nm, err := NewNetmap(nodes) nm, err := NewNetmap(nodes)
@ -65,6 +68,7 @@ func TestPlacementPolicy_Interopability(t *testing.T) {
require.Contains(t, err.Error(), tt.Error) require.Contains(t, err.Error(), tt.Error)
} else { } else {
require.NoError(t, err) require.NoError(t, err)
require.Equal(t, srcNodes, tc.Nodes)
res := v.Replicas() res := v.Replicas()
compareNodes(t, tt.Result, nodes, res) compareNodes(t, tt.Result, nodes, res)
@ -73,6 +77,7 @@ func TestPlacementPolicy_Interopability(t *testing.T) {
res, err := nm.GetPlacementVectors(v, tt.Placement.Pivot) res, err := nm.GetPlacementVectors(v, tt.Placement.Pivot)
require.NoError(t, err) require.NoError(t, err)
compareNodes(t, tt.Placement.Result, nodes, res) compareNodes(t, tt.Placement.Result, nodes, res)
require.Equal(t, srcNodes, tc.Nodes)
} }
} }
}) })