olefirenque/frostfs-sdk-go
1
0
Fork 0
forked from TrueCloudLab/frostfs-sdk-go
Code Pull requests Activity

[#264] storagegroup: Fix out of range

Browse source 
It panicked when the previous members slice had capacity more than a new one
because of incorrect slicing that led to `out of range`.

Signed-off-by: Pavel Karpy <carpawell@nspcc.ru>
This commit is contained in:
Pavel Karpy 2022-06-07 20:34:46 +03:00 committed by fyrchik
parent 5518b63432
commit 6ac9deabb8
2 changed files with 14 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
storagegroup/storagegroup.go
View file

@ -138,14 +138,14 @@ func (sg *StorageGroup) SetMembers(members []oid.ID) {
if cap(mV2) >= ln { if cap(mV2) >= ln {
mV2 = mV2[:0] mV2 = mV2[:0]
} else { } else {
mV2 = make([]refs.ObjectID, ln) mV2 = make([]refs.ObjectID, 0, ln)
} }
var oidV2 refs.ObjectID var oidV2 refs.ObjectID
for i := 0; i < ln; i++ { for i := 0; i < ln; i++ {
members[i].WriteToV2(&oidV2) members[i].WriteToV2(&oidV2)
mV2[i] = oidV2 mV2 = append(mV2, oidV2)
} }
} }

12
storagegroup/storagegroup_test.go
View file

@ -181,3 +181,15 @@ func generateOIDList() []refs.ObjectID {
return mmV2 return mmV2
} }
func TestStorageGroup_SetMembers_DoubleSetting(t *testing.T) {
var sg storagegroup.StorageGroup
mm := []oid.ID{oidtest.ID(), oidtest.ID(), oidtest.ID()} // cap is 3 at least
sg.SetMembers(mm)
// the previous cap is more that a new length;
// slicing should not lead to `out of range`
// and apply update correctly
sg.SetMembers(mm[:1])
}