diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index f5938c9a..d7e53477 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -13,7 +13,7 @@ jobs: runs-on: ubuntu-latest env: GO_VERSION: 1.19 - GOLANGCI_LINT_VERSION: v1.49.0 + GOLANGCI_LINT_VERSION: v1.50.1 HUGO_VERSION: 0.54.0 CGO_ENABLED: 0 LEGO_E2E_TESTS: CI diff --git a/.golangci.toml b/.golangci.toml index e7e21518..a348a651 100644 --- a/.golangci.toml +++ b/.golangci.toml @@ -204,3 +204,7 @@ [[issues.exclude-rules]] path = "providers/dns/sakuracloud/client.go" text = "mu is a global variable" + + [[issues.exclude-rules]] + path = "providers/dns/hosttech/internal/client_test.go" + text = "Duplicate words \\(0\\) found" diff --git a/challenge/resolver/solver_manager.go b/challenge/resolver/solver_manager.go index 9709e891..138060bc 100644 --- a/challenge/resolver/solver_manager.go +++ b/challenge/resolver/solver_manager.go @@ -53,7 +53,7 @@ func (c *SolverManager) SetDNS01Provider(p challenge.Provider, opts ...dns01.Cha return nil } -// Remove Remove a challenge type from the available solvers. +// Remove removes a challenge type from the available solvers. func (c *SolverManager) Remove(chlgType challenge.Type) { delete(c.solvers, chlgType) } diff --git a/providers/dns/constellix/internal/auth.go b/providers/dns/constellix/internal/auth.go index 16c49b1a..8be4f845 100644 --- a/providers/dns/constellix/internal/auth.go +++ b/providers/dns/constellix/internal/auth.go @@ -65,7 +65,7 @@ func (t *TokenTransport) Client() *http.Client { return &http.Client{Transport: t} } -// Wrap Wrap a HTTP client Transport with the TokenTransport. +// Wrap wraps an HTTP client Transport with the TokenTransport. func (t *TokenTransport) Wrap(client *http.Client) *http.Client { backup := client.Transport t.Transport = backup diff --git a/providers/dns/dynu/internal/auth.go b/providers/dns/dynu/internal/auth.go index 9409e049..72d15a81 100644 --- a/providers/dns/dynu/internal/auth.go +++ b/providers/dns/dynu/internal/auth.go @@ -54,7 +54,7 @@ func (t *TokenTransport) Client() *http.Client { return &http.Client{Transport: t} } -// Wrap Wrap a HTTP client Transport with the TokenTransport. +// Wrap wraps an HTTP client Transport with the TokenTransport. func (t *TokenTransport) Wrap(client *http.Client) *http.Client { backup := client.Transport t.Transport = backup diff --git a/providers/dns/iij/iij_test.go b/providers/dns/iij/iij_test.go index 73a0ba64..39547cdd 100644 --- a/providers/dns/iij/iij_test.go +++ b/providers/dns/iij/iij_test.go @@ -167,21 +167,21 @@ func TestSplitDomain(t *testing.T) { expectedZone: "domain.com", }, { - desc: "with a sub domain", + desc: "with a subdomain", domain: "my.domain.com", zones: []string{"domain.com"}, expectedOwner: "_acme-challenge.my", expectedZone: "domain.com", }, { - desc: "with a sub domain in a zone", + desc: "with a subdomain in a zone", domain: "my.sub.domain.com", zones: []string{"sub.domain.com", "domain.com"}, expectedOwner: "_acme-challenge.my", expectedZone: "sub.domain.com", }, { - desc: "with a sub sub domain", + desc: "with a sub-subdomain", domain: "my.sub.domain.com", zones: []string{"domain1.com", "domain.com"}, expectedOwner: "_acme-challenge.my.sub",