golint fixes.

- dynRequest should be private to dyn package
- Fix JobID name
This commit is contained in:
Andrew E. Bruno 2016-03-19 16:14:23 -04:00
parent 9f8d5e4076
commit b10c35bba1

View file

@ -14,7 +14,7 @@ import (
var dynBaseURL = "https://api.dynect.net/REST" var dynBaseURL = "https://api.dynect.net/REST"
type DynResponse struct { type dynResponse struct {
// One of 'success', 'failure', or 'incomplete' // One of 'success', 'failure', or 'incomplete'
Status string `json:"status"` Status string `json:"status"`
@ -22,7 +22,7 @@ type DynResponse struct {
Data json.RawMessage `json:"data"` Data json.RawMessage `json:"data"`
// The ID of the job that was created in response to a request. // The ID of the job that was created in response to a request.
JobId int `json:"job_id"` JobID int `json:"job_id"`
// A list of zero or more messages // A list of zero or more messages
Messages json.RawMessage `json:"msgs"` Messages json.RawMessage `json:"msgs"`
@ -48,7 +48,7 @@ func NewDNSProvider(customerName, userName, password string) (*DNSProvider, erro
}, nil }, nil
} }
func (d *DNSProvider) sendRequest(method, resource string, payload interface{}) (*DynResponse, error) { func (d *DNSProvider) sendRequest(method, resource string, payload interface{}) (*dynResponse, error) {
url := fmt.Sprintf("%s/%s", dynBaseURL, resource) url := fmt.Sprintf("%s/%s", dynBaseURL, resource)
body, err := json.Marshal(payload) body, err := json.Marshal(payload)
@ -79,7 +79,7 @@ func (d *DNSProvider) sendRequest(method, resource string, payload interface{})
return nil, fmt.Errorf("Dyn API request returned HTTP 307. This is currently unsupported") return nil, fmt.Errorf("Dyn API request returned HTTP 307. This is currently unsupported")
} }
var dynRes DynResponse var dynRes dynResponse
err = json.NewDecoder(resp.Body).Decode(&dynRes) err = json.NewDecoder(resp.Body).Decode(&dynRes)
if err != nil { if err != nil {
return nil, err return nil, err