pogpp/lego
1
0
Fork 0
forked from TrueCloudLab/lego
Code Pull requests Activity

Couple more tests to ensure right method is being used

Browse source
This commit is contained in:
Matthew Holt 2016-01-13 18:49:25 -07:00
parent c590b724c7
commit db3a956d52
1 changed files with 15 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
acme/http_test.go
View file

@ -8,9 +8,10 @@ import (
) )
func TestHTTPHeadUserAgent(t *testing.T) { func TestHTTPHeadUserAgent(t *testing.T) {
var ua string var ua, method string
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
ua = r.Header.Get("User-Agent") ua = r.Header.Get("User-Agent")
method = r.Method
})) }))
defer ts.Close() defer ts.Close()
@ -19,15 +20,19 @@ func TestHTTPHeadUserAgent(t *testing.T) {
t.Fatal(err) t.Fatal(err)
} }
if method != "HEAD" {
t.Errorf("Expected method to be HEAD, got %s", method)
}
if !strings.Contains(ua, ourUserAgent) { if !strings.Contains(ua, ourUserAgent) {
t.Errorf("Expected User-Agent to contain '%s', got: '%s'", ourUserAgent, ua) t.Errorf("Expected User-Agent to contain '%s', got: '%s'", ourUserAgent, ua)
} }
} }
func TestHTTPGetUserAgent(t *testing.T) { func TestHTTPGetUserAgent(t *testing.T) {
var ua string var ua, method string
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
ua = r.Header.Get("User-Agent") ua = r.Header.Get("User-Agent")
method = r.Method
})) }))
defer ts.Close() defer ts.Close()
@ -37,15 +42,19 @@ func TestHTTPGetUserAgent(t *testing.T) {
} }
res.Body.Close() res.Body.Close()
if method != "GET" {
t.Errorf("Expected method to be GET, got %s", method)
}
if !strings.Contains(ua, ourUserAgent) { if !strings.Contains(ua, ourUserAgent) {
t.Errorf("Expected User-Agent to contain '%s', got: '%s'", ourUserAgent, ua) t.Errorf("Expected User-Agent to contain '%s', got: '%s'", ourUserAgent, ua)
} }
} }
func TestHTTPPostUserAgent(t *testing.T) { func TestHTTPPostUserAgent(t *testing.T) {
var ua string var ua, method string
ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
ua = r.Header.Get("User-Agent") ua = r.Header.Get("User-Agent")
method = r.Method
})) }))
defer ts.Close() defer ts.Close()
@ -55,6 +64,9 @@ func TestHTTPPostUserAgent(t *testing.T) {
} }
res.Body.Close() res.Body.Close()
if method != "POST" {
t.Errorf("Expected method to be POST, got %s", method)
}
if !strings.Contains(ua, ourUserAgent) { if !strings.Contains(ua, ourUserAgent) {
t.Errorf("Expected User-Agent to contain '%s', got: '%s'", ourUserAgent, ua) t.Errorf("Expected User-Agent to contain '%s', got: '%s'", ourUserAgent, ua)
} }