potyarkin/forgejo-runner-act
1
0
Fork 0
Code Issues Pull requests Activity

Stop current execution if there is the invalid syntax in the workflow (#495)

Browse source
This commit is contained in:
KADOTA, Kyohei 2021-01-21 23:00:33 +09:00 committed by GitHub
parent b424a785e3
commit 719a077b7c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
pkg/runner/step_context.go
View file

@ -57,6 +57,15 @@ func (sc *StepContext) Executor() common.Executor {
) )
case model.StepTypeUsesActionRemote: case model.StepTypeUsesActionRemote:
remoteAction := newRemoteAction(step.Uses) remoteAction := newRemoteAction(step.Uses)
if remoteAction.Ref == "" {
// GitHub's document[^] describes:
// > We strongly recommend that you include the version of
// > the action you are using by specifying a Git ref, SHA, or Docker tag number.
// Actually, the workflow stops if there is the uses directive that hasn't @ref.
// [^]: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions
msg := fmt.Sprintf("Expected format {org}/{repo}[/path]@ref. Actual '%s' Input string was not in a correct format.", step.Uses)
return common.NewErrorExecutor(fmt.Errorf("%s", msg))
}
if remoteAction.IsCheckout() && rc.getGithubContext().isLocalCheckout(step) { if remoteAction.IsCheckout() && rc.getGithubContext().isLocalCheckout(step) {
return func(ctx context.Context) error { return func(ctx context.Context) error {
common.Logger(ctx).Debugf("Skipping actions/checkout") common.Logger(ctx).Debugf("Skipping actions/checkout")
@ -398,8 +407,6 @@ func newRemoteAction(action string) *remoteAction {
ra := new(remoteAction) ra := new(remoteAction)
ra.Org = matches[1] ra.Org = matches[1]
ra.Repo = matches[2] ra.Repo = matches[2]
ra.Path = ""
ra.Ref = "master"
if len(matches) >= 5 { if len(matches) >= 5 {
ra.Path = matches[4] ra.Path = matches[4]
} }