Report error when if expression is invalid (#485)

Co-authored-by: Ed Tan <edtan@users.noreply.github.com>
Co-authored-by: Casey Lee <cplee@nektos.com>

pkg/runner/run_context.go

@@ -314,7 +314,7 @@ func (rc *RunContext) EvalBool(expr string) (bool, error) {
 		joined := strings.Join(evaluatedParts, " ")
 		v, _, err := rc.ExprEval.Evaluate(fmt.Sprintf("Boolean(%s)", joined))
 		if err != nil {
-			return false, nil
+			return false, err
 		}
 		log.Debugf("expression '%s' evaluated to '%s'", expr, v)
 		return v == "true", nil

pkg/runner/run_context_test.go

@@ -2,13 +2,14 @@ package runner
 
 import (
 	"fmt"
-	"github.com/nektos/act/pkg/model"
-	a "github.com/stretchr/testify/assert"
 	"os"
 	"regexp"
 	"strings"
 	"testing"
 
+	"github.com/nektos/act/pkg/model"
+	a "github.com/stretchr/testify/assert"
+
 	"github.com/sirupsen/logrus/hooks/test"
 )
 
@@ -129,6 +130,8 @@ func TestRunContext_EvalBool(t *testing.T) {
 		// The special ACT flag
 		{in: "${{ env.ACT }}", out: true},
 		{in: "${{ !env.ACT }}", out: false},
+		// Invalid expressions should be reported
+		{in: "INVALID_EXPRESSION", wantErr: true},
 	}
 
 	updateTestIfWorkflow(t, tables, rc)