9868e13772
* Feature: uses in composite * Negate logic * Reduce complexity * Update step_context.go * Update step_context.go * Update step_context.go * Fix syntax error in test * Bump * Disable usage of actions/setup-node@v2 * Bump * Fix step id collision * Fix output command workaround * Make secrets context inaccessible in composite * Fix order after adding a workaround (needs tests) Fixes https://github.com/nektos/act/pull/793#issuecomment-922329838 * Evaluate env before passing one step deeper If env would contain any inputs, steps ctx or secrets there was undefined behaviour * [no ci] prepare secret test * Initial test pass inputs as env * Fix syntax error * extend test also for direct invoke * Fix passing provided env as composite output * Fix syntax error * toUpper 'no such secret', act has a bug * fix indent * Fix env outputs in composite * Test env outputs of composite * Fix inputs not defined in docker actions * Fix interpolate args input of docker actions * Fix lint * AllowCompositeIf now defaults to true see https://github.com/actions/runner/releases/tag/v2.284.0 * Fix lint * Fix env of docker action.yml * Test calling a local docker action from composite With input context hirachy * local-action-dockerfile Test pass on action/runner It seems action/runner ignores overrides of args, if the target docker action has the args property set. * Fix exec permissions of docker-local-noargs * Revert getStepsContext change * fix: handle composite action on error and continue This change is a follow up of https://github.com/nektos/act/pull/840 and integrates with https://github.com/nektos/act/pull/793 There are two things included here: - The default value for a step.if in an action need to be 'success()' - We need to hand the error from a composite action back to the calling executor Co-authored-by: Björn Brauer <bjoern.brauer@new-work.se> * Patch inputs can be bool, float64 and string for workflow_call Also inputs is now always defined, but may be null * Simplify cherry-picked commit * Minor style adjustments * Remove chmod +x from tests now fails on windows like before * Fix GITHUB_ACTION_PATH some action env vars Fixes GITHUB_ACTION_REPOSITORY, GITHUB_ACTION_REF. * Add comment to CompositeRestrictions Co-authored-by: Markus Wolf <markus.wolf@new-work.se> Co-authored-by: Björn Brauer <bjoern.brauer@new-work.se> Co-authored-by: Ryan <me@hackerc.at> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
281 lines
8.8 KiB
Go
281 lines
8.8 KiB
Go
package runner
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"runtime"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/joho/godotenv"
|
|
log "github.com/sirupsen/logrus"
|
|
assert "github.com/stretchr/testify/assert"
|
|
|
|
"github.com/nektos/act/pkg/model"
|
|
)
|
|
|
|
var baseImage = "node:12-buster-slim"
|
|
|
|
func init() {
|
|
if p := os.Getenv("ACT_TEST_IMAGE"); p != "" {
|
|
baseImage = p
|
|
}
|
|
}
|
|
|
|
func TestGraphEvent(t *testing.T) {
|
|
planner, err := model.NewWorkflowPlanner("testdata/basic", true)
|
|
assert.Nil(t, err)
|
|
|
|
plan := planner.PlanEvent("push")
|
|
assert.Nil(t, err)
|
|
assert.Equal(t, len(plan.Stages), 3, "stages")
|
|
assert.Equal(t, len(plan.Stages[0].Runs), 1, "stage0.runs")
|
|
assert.Equal(t, len(plan.Stages[1].Runs), 1, "stage1.runs")
|
|
assert.Equal(t, len(plan.Stages[2].Runs), 1, "stage2.runs")
|
|
assert.Equal(t, plan.Stages[0].Runs[0].JobID, "check", "jobid")
|
|
assert.Equal(t, plan.Stages[1].Runs[0].JobID, "build", "jobid")
|
|
assert.Equal(t, plan.Stages[2].Runs[0].JobID, "test", "jobid")
|
|
|
|
plan = planner.PlanEvent("release")
|
|
assert.Equal(t, len(plan.Stages), 0, "stages")
|
|
}
|
|
|
|
type TestJobFileInfo struct {
|
|
workdir string
|
|
workflowPath string
|
|
eventName string
|
|
errorMessage string
|
|
platforms map[string]string
|
|
containerArchitecture string
|
|
}
|
|
|
|
func runTestJobFile(ctx context.Context, t *testing.T, tjfi TestJobFileInfo) {
|
|
t.Run(tjfi.workflowPath, func(t *testing.T) {
|
|
workdir, err := filepath.Abs(tjfi.workdir)
|
|
assert.Nil(t, err, workdir)
|
|
fullWorkflowPath := filepath.Join(workdir, tjfi.workflowPath)
|
|
runnerConfig := &Config{
|
|
Workdir: workdir,
|
|
BindWorkdir: false,
|
|
EventName: tjfi.eventName,
|
|
Platforms: tjfi.platforms,
|
|
ReuseContainers: false,
|
|
ContainerArchitecture: tjfi.containerArchitecture,
|
|
GitHubInstance: "github.com",
|
|
}
|
|
|
|
runner, err := New(runnerConfig)
|
|
assert.Nil(t, err, tjfi.workflowPath)
|
|
|
|
planner, err := model.NewWorkflowPlanner(fullWorkflowPath, true)
|
|
assert.Nil(t, err, fullWorkflowPath)
|
|
|
|
plan := planner.PlanEvent(tjfi.eventName)
|
|
|
|
err = runner.NewPlanExecutor(plan)(ctx)
|
|
if tjfi.errorMessage == "" {
|
|
assert.Nil(t, err, fullWorkflowPath)
|
|
} else {
|
|
assert.Error(t, err, tjfi.errorMessage)
|
|
}
|
|
})
|
|
}
|
|
|
|
func TestRunEvent(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping integration test")
|
|
}
|
|
|
|
platforms := map[string]string{
|
|
"ubuntu-latest": baseImage,
|
|
}
|
|
|
|
tables := []TestJobFileInfo{
|
|
{"testdata", "basic", "push", "", platforms, ""},
|
|
{"testdata", "fail", "push", "exit with `FAILURE`: 1", platforms, ""},
|
|
{"testdata", "runs-on", "push", "", platforms, ""},
|
|
{"testdata", "checkout", "push", "", platforms, ""},
|
|
{"testdata", "shells/defaults", "push", "", platforms, ""},
|
|
// TODO: figure out why it fails
|
|
// {"testdata", "shells/custom", "push", "", map[string]string{"ubuntu-latest": "ghcr.io/justingrote/act-pwsh:latest"}, ""}, // custom image with pwsh
|
|
{"testdata", "shells/pwsh", "push", "", map[string]string{"ubuntu-latest": "ghcr.io/justingrote/act-pwsh:latest"}, ""}, // custom image with pwsh
|
|
{"testdata", "shells/bash", "push", "", platforms, ""},
|
|
{"testdata", "shells/python", "push", "", map[string]string{"ubuntu-latest": "node:12-buster"}, ""}, // slim doesn't have python
|
|
{"testdata", "shells/sh", "push", "", platforms, ""},
|
|
{"testdata", "job-container", "push", "", platforms, ""},
|
|
{"testdata", "job-container-non-root", "push", "", platforms, ""},
|
|
{"testdata", "container-hostname", "push", "", platforms, ""},
|
|
{"testdata", "uses-docker-url", "push", "", platforms, ""},
|
|
{"testdata", "remote-action-docker", "push", "", platforms, ""},
|
|
{"testdata", "remote-action-js", "push", "", platforms, ""},
|
|
{"testdata", "local-action-docker-url", "push", "", platforms, ""},
|
|
{"testdata", "local-action-dockerfile", "push", "", platforms, ""},
|
|
{"testdata", "local-action-via-composite-dockerfile", "push", "", platforms, ""},
|
|
{"testdata", "local-action-js", "push", "", platforms, ""},
|
|
{"testdata", "matrix", "push", "", platforms, ""},
|
|
{"testdata", "matrix-include-exclude", "push", "", platforms, ""},
|
|
{"testdata", "commands", "push", "", platforms, ""},
|
|
{"testdata", "workdir", "push", "", platforms, ""},
|
|
{"testdata", "defaults-run", "push", "", platforms, ""},
|
|
{"testdata", "uses-composite", "push", "", platforms, ""},
|
|
{"testdata", "uses-composite-with-error", "push", "Job 'failing-composite-action' failed", platforms, ""},
|
|
{"testdata", "uses-nested-composite", "push", "", platforms, ""},
|
|
{"testdata", "issue-597", "push", "", platforms, ""},
|
|
{"testdata", "issue-598", "push", "", platforms, ""},
|
|
{"testdata", "env-and-path", "push", "", platforms, ""},
|
|
{"testdata", "outputs", "push", "", platforms, ""},
|
|
{"testdata", "steps-context/conclusion", "push", "", platforms, ""},
|
|
{"testdata", "steps-context/outcome", "push", "", platforms, ""},
|
|
{"testdata", "job-status-check", "push", "job 'fail' failed", platforms, ""},
|
|
{"testdata", "if-expressions", "push", "Job 'mytest' failed", platforms, ""},
|
|
{"../model/testdata", "strategy", "push", "", platforms, ""}, // TODO: move all testdata into pkg so we can validate it with planner and runner
|
|
// {"testdata", "issue-228", "push", "", platforms, ""}, // TODO [igni]: Remove this once everything passes
|
|
|
|
// single test for different architecture: linux/arm64
|
|
{"testdata", "basic", "push", "", platforms, "linux/arm64"},
|
|
}
|
|
log.SetLevel(log.DebugLevel)
|
|
|
|
ctx := context.Background()
|
|
|
|
for _, table := range tables {
|
|
runTestJobFile(ctx, t, table)
|
|
}
|
|
}
|
|
|
|
func TestRunEventSecrets(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping integration test")
|
|
}
|
|
|
|
log.SetLevel(log.DebugLevel)
|
|
ctx := context.Background()
|
|
|
|
platforms := map[string]string{
|
|
"ubuntu-latest": baseImage,
|
|
}
|
|
|
|
workflowPath := "secrets"
|
|
eventName := "push"
|
|
|
|
workdir, err := filepath.Abs("testdata")
|
|
assert.Nil(t, err, workflowPath)
|
|
|
|
env, _ := godotenv.Read(filepath.Join(workdir, workflowPath, ".env"))
|
|
secrets, _ := godotenv.Read(filepath.Join(workdir, workflowPath, ".secrets"))
|
|
|
|
runnerConfig := &Config{
|
|
Workdir: workdir,
|
|
EventName: eventName,
|
|
Platforms: platforms,
|
|
ReuseContainers: false,
|
|
Secrets: secrets,
|
|
Env: env,
|
|
}
|
|
runner, err := New(runnerConfig)
|
|
assert.Nil(t, err, workflowPath)
|
|
|
|
planner, err := model.NewWorkflowPlanner(fmt.Sprintf("testdata/%s", workflowPath), true)
|
|
assert.Nil(t, err, workflowPath)
|
|
|
|
plan := planner.PlanEvent(eventName)
|
|
|
|
err = runner.NewPlanExecutor(plan)(ctx)
|
|
assert.Nil(t, err, workflowPath)
|
|
}
|
|
|
|
func TestRunEventPullRequest(t *testing.T) {
|
|
if testing.Short() {
|
|
t.Skip("skipping integration test")
|
|
}
|
|
|
|
log.SetLevel(log.DebugLevel)
|
|
ctx := context.Background()
|
|
|
|
platforms := map[string]string{
|
|
"ubuntu-latest": baseImage,
|
|
}
|
|
|
|
workflowPath := "pull-request"
|
|
eventName := "pull_request"
|
|
|
|
workdir, err := filepath.Abs("testdata")
|
|
assert.Nil(t, err, workflowPath)
|
|
|
|
runnerConfig := &Config{
|
|
Workdir: workdir,
|
|
EventName: eventName,
|
|
EventPath: filepath.Join(workdir, workflowPath, "event.json"),
|
|
Platforms: platforms,
|
|
ReuseContainers: false,
|
|
}
|
|
runner, err := New(runnerConfig)
|
|
assert.Nil(t, err, workflowPath)
|
|
|
|
planner, err := model.NewWorkflowPlanner(fmt.Sprintf("testdata/%s", workflowPath), true)
|
|
assert.Nil(t, err, workflowPath)
|
|
|
|
plan := planner.PlanEvent(eventName)
|
|
|
|
err = runner.NewPlanExecutor(plan)(ctx)
|
|
assert.Nil(t, err, workflowPath)
|
|
}
|
|
|
|
func TestContainerPath(t *testing.T) {
|
|
type containerPathJob struct {
|
|
destinationPath string
|
|
sourcePath string
|
|
workDir string
|
|
}
|
|
|
|
if runtime.GOOS == "windows" {
|
|
cwd, err := os.Getwd()
|
|
if err != nil {
|
|
log.Error(err)
|
|
}
|
|
|
|
rootDrive := os.Getenv("SystemDrive")
|
|
rootDriveLetter := strings.ReplaceAll(strings.ToLower(rootDrive), `:`, "")
|
|
for _, v := range []containerPathJob{
|
|
{"/mnt/c/Users/act/go/src/github.com/nektos/act", "C:\\Users\\act\\go\\src\\github.com\\nektos\\act\\", ""},
|
|
{"/mnt/f/work/dir", `F:\work\dir`, ""},
|
|
{"/mnt/c/windows/to/unix", "windows\\to\\unix", fmt.Sprintf("%s\\", rootDrive)},
|
|
{fmt.Sprintf("/mnt/%v/act", rootDriveLetter), "act", fmt.Sprintf("%s\\", rootDrive)},
|
|
} {
|
|
if v.workDir != "" {
|
|
if err := os.Chdir(v.workDir); err != nil {
|
|
log.Error(err)
|
|
t.Fail()
|
|
}
|
|
}
|
|
|
|
runnerConfig := &Config{
|
|
Workdir: v.sourcePath,
|
|
}
|
|
|
|
assert.Equal(t, v.destinationPath, runnerConfig.containerPath(runnerConfig.Workdir))
|
|
}
|
|
|
|
if err := os.Chdir(cwd); err != nil {
|
|
log.Error(err)
|
|
}
|
|
} else {
|
|
cwd, err := os.Getwd()
|
|
if err != nil {
|
|
log.Error(err)
|
|
}
|
|
for _, v := range []containerPathJob{
|
|
{"/home/act/go/src/github.com/nektos/act", "/home/act/go/src/github.com/nektos/act", ""},
|
|
{"/home/act", `/home/act/`, ""},
|
|
{cwd, ".", ""},
|
|
} {
|
|
runnerConfig := &Config{
|
|
Workdir: v.sourcePath,
|
|
}
|
|
|
|
assert.Equal(t, v.destinationPath, runnerConfig.containerPath(runnerConfig.Workdir))
|
|
}
|
|
}
|
|
}
|