potyarkin/frostfs-api-go
1
0
Fork 0
forked from TrueCloudLab/frostfs-api-go
Code Pull requests Activity

[#209] Support nil value in SplitID

Browse source 
SplitID is not set on non-split and virtual
objects, so we should support this state in
library.

Signed-off-by: Alex Vanin <alexey@nspcc.ru>
This commit is contained in:
Alex Vanin 2020-11-26 13:00:03 +03:00 committed by Alex Vanin
parent 3d08d8140f
commit 2a94fdc5e7
2 changed files with 22 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
pkg/object/splitid.go
View file

@ -42,17 +42,27 @@ func (id *SplitID) Parse(s string) (err error) {
} }
// String returns UUIDv4 string representation of SplitID. // String returns UUIDv4 string representation of SplitID.
func (id SplitID) String() string { func (id *SplitID) String() string {
if id == nil {
return ""
}
return id.uuid.String() return id.uuid.String()
} }
// SetUUID sets pre created UUID structure as SplitID. // SetUUID sets pre created UUID structure as SplitID.
func (id *SplitID) SetUUID(v uuid.UUID) { func (id *SplitID) SetUUID(v uuid.UUID) {
if id != nil {
id.uuid = v id.uuid = v
}
} }
// ToV2 converts SplitID to a representation of SplitID in neofs-api v2. // ToV2 converts SplitID to a representation of SplitID in neofs-api v2.
func (id SplitID) ToV2() []byte { func (id *SplitID) ToV2() []byte {
if id == nil {
return nil
}
data, _ := id.uuid.MarshalBinary() // err is always nil data, _ := id.uuid.MarshalBinary() // err is always nil
return data return data

9
pkg/object/splitid_test.go
View file

@ -35,4 +35,13 @@ func TestSplitID(t *testing.T) {
require.Equal(t, newUUID.String(), id.String()) require.Equal(t, newUUID.String(), id.String())
}) })
t.Run("nil value", func(t *testing.T) {
var newID *object.SplitID
require.NotPanics(t, func() {
require.Nil(t, newID.ToV2())
require.Equal(t, "", newID.String())
})
})
} }