[#180] node: Refactor panics in unit test

* Replace panics in unit tests by require.NoError and t.Fatalf

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>

cmd/frostfs-node/config/apiclient/config_test.go

@@ -32,6 +32,6 @@ func TestApiclientSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/contracts/config_test.go

@@ -56,6 +56,6 @@ func TestContractsSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/control/config_test.go

@@ -32,6 +32,6 @@ func TestControlSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/engine/config_test.go

@@ -167,6 +167,6 @@ func TestEngineSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/grpc/config_test.go

@@ -49,6 +49,6 @@ func TestGRPCSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/logger/config_test.go

@@ -25,6 +25,6 @@ func TestLoggerSection_Level(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/metrics/config_test.go

@@ -34,6 +34,6 @@ func TestMetricsSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/morph/config_test.go

@@ -40,6 +40,6 @@ func TestMorphSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/node/config_test.go

@@ -162,6 +162,6 @@ func TestNodeSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/object/config_test.go

@@ -29,6 +29,6 @@ func TestObjectSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/policer/config_test.go

@@ -26,6 +26,6 @@ func TestPolicerSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/profiler/config_test.go

@@ -34,6 +34,6 @@ func TestProfilerSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/replicator/config_test.go

@@ -28,6 +28,6 @@ func TestReplicatorSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }

cmd/frostfs-node/config/test/config.go

@@ -4,8 +4,10 @@ import (
 	"bufio"
 	"os"
 	"strings"
+	"testing"
 
 	"git.frostfs.info/TrueCloudLab/frostfs-node/cmd/frostfs-node/config"
+	"github.com/stretchr/testify/require"
 )
 
 func fromFile(path string) *config.Config {
@@ -18,10 +20,10 @@ func fromFile(path string) *config.Config {
 	)
 }
 
-func fromEnvFile(path string) *config.Config {
+func fromEnvFile(t testing.TB, path string) *config.Config {
 	var p config.Prm
 
-	loadEnv(path) // github.com/joho/godotenv can do that as well
+	loadEnv(t, path) // github.com/joho/godotenv can do that as well
 
 	return config.New(p)
 }
@@ -43,8 +45,8 @@ func ForEachFileType(pref string, f func(*config.Config)) {
 }
 
 // ForEnvFileType creates config from `<pref>.env` file.
-func ForEnvFileType(pref string, f func(*config.Config)) {
-	f(fromEnvFile(pref + ".env"))
+func ForEnvFileType(t testing.TB, pref string, f func(*config.Config)) {
+	f(fromEnvFile(t, pref+".env"))
 }
 
 // EmptyConfig returns config without any values and sections.
@@ -55,11 +57,9 @@ func EmptyConfig() *config.Config {
 }
 
 // loadEnv reads .env file, parses `X=Y` records and sets OS ENVs.
-func loadEnv(path string) {
+func loadEnv(t testing.TB, path string) {
 	f, err := os.Open(path)
-	if err != nil {
-		panic("can't open .env file")
-	}
+	require.NoError(t, err, "can't open .env file")
 
 	defer f.Close()
 
@@ -73,8 +73,6 @@ func loadEnv(path string) {
 		v = strings.Trim(v, `"`)
 
 		err = os.Setenv(k, v)
-		if err != nil {
-			panic("can't set environment variable")
-		}
+		require.NoError(t, err, "can't set environment variable")
 	}
 }

cmd/frostfs-node/config/tree/config_test.go

@@ -39,6 +39,6 @@ func TestTreeSection(t *testing.T) {
 	configtest.ForEachFileType(path, fileConfigTest)
 
 	t.Run("ENV", func(t *testing.T) {
-		configtest.ForEnvFileType(path, fileConfigTest)
+		configtest.ForEnvFileType(t, path, fileConfigTest)
 	})
 }