potyarkin/lego
1
0
Fork 0
forked from TrueCloudLab/lego
Code Pull requests Activity

dns_challenge preCheckDNS: let system resolver decide IPv4 ./. IPv6.

Browse source 
We can ask the OS resolver for the IP of Google's public anycast DNS.
No need to "bootstrap" with literal IP address. The OS resolver knows
best about IPv4 ./. IPv6.

Mostly fixes #88.
This commit is contained in:
Den Quixote 2016-01-30 19:39:10 +01:00
parent 316cb44f80
commit 0e53e51ba5
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
acme/dns_challenge.go
View file

@ -73,7 +73,7 @@ func checkDNS(domain, fqdn string) bool {
m := new(dns.Msg) m := new(dns.Msg)
m.SetQuestion(domain+".", dns.TypeSOA) m.SetQuestion(domain+".", dns.TypeSOA)
c := new(dns.Client) c := new(dns.Client)
in, _, err := c.Exchange(m, "8.8.8.8:53") in, _, err := c.Exchange(m, "google-public-dns-a.google.com:53")
if err != nil { if err != nil {
return false return false
} }

6
acme/dns_challenge_test.go
View file

@ -37,3 +37,9 @@ func TestDNSValidServerResponse(t *testing.T) {
t.Errorf("VALID: Expected Solve to return no error but the error was -> %v", err) t.Errorf("VALID: Expected Solve to return no error but the error was -> %v", err)
} }
} }
func TestPreCheckDNS(t *testing.T) {
if !preCheckDNS("api.letsencrypt.org", "acme-staging.api.letsencrypt.org") {
t.Errorf("preCheckDNS failed for acme-staging.api.letsencrypt.org")
}
}