potyarkin/lego
1
0
Fork 0
forked from TrueCloudLab/lego
Code Pull requests Activity

Fix a few golint errors.

Browse source
This commit is contained in:
xenolf 2016-03-19 17:53:16 +01:00
parent d6fb247c29
commit 4562a14383
3 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
providers/dns/googlecloud/googlecloud.go
View file

@ -107,6 +107,8 @@ func (c *DNSProvider) CleanUp(domain, token, keyAuth string) error {
return nil return nil
} }
// Timeout customizes the timeout values used by the ACME package for checking
// DNS record validity.
func (c *DNSProvider) Timeout() (timeout, interval time.Duration) { func (c *DNSProvider) Timeout() (timeout, interval time.Duration) {
return 180 * time.Second, 5 * time.Second return 180 * time.Second, 5 * time.Second
} }

6
providers/dns/namecheap/namecheap.go
View file

@ -31,7 +31,7 @@ import (
var ( var (
debug = false debug = false
defaultBaseURL = "https://api.namecheap.com/xml.response" defaultBaseURL = "https://api.namecheap.com/xml.response"
getIpURL = "https://dynamicdns.park-your-domain.com/getip" getIPURL = "https://dynamicdns.park-your-domain.com/getip"
httpClient = http.Client{Timeout: 60 * time.Second} httpClient = http.Client{Timeout: 60 * time.Second}
) )
@ -68,7 +68,7 @@ func NewDNSProvider(apiUser, apiKey string) (*DNSProvider, error) {
}, nil }, nil
} }
// Namecheap can sometimes take a long time to complete an update, so wait // Timeout : Namecheap can sometimes take a long time to complete an update, so wait
// up to 60 minutes for the update to propagate. // up to 60 minutes for the update to propagate.
func (d *DNSProvider) Timeout() (timeout, interval time.Duration) { func (d *DNSProvider) Timeout() (timeout, interval time.Duration) {
return 60 * time.Minute, 15 * time.Second return 60 * time.Minute, 15 * time.Second
@ -94,7 +94,7 @@ type apierror struct {
// getClientIP returns the client's public IP address. It uses namecheap's // getClientIP returns the client's public IP address. It uses namecheap's
// IP discovery service to perform the lookup. // IP discovery service to perform the lookup.
func getClientIP() (addr string, err error) { func getClientIP() (addr string, err error) {
resp, err := httpClient.Get(getIpURL) resp, err := httpClient.Get(getIPURL)
if err != nil { if err != nil {
return "", err return "", err
} }

4
providers/dns/namecheap/namecheap_test.go
View file

@ -271,7 +271,7 @@ type testcase struct {
setHostsResponse string setHostsResponse string
} }
var testcases []testcase = []testcase{ var testcases = []testcase{
{ {
"Test:Success:1", "Test:Success:1",
"test.example.com", "test.example.com",
@ -374,7 +374,7 @@ var responseSetHostsSuccess2 = `<?xml version="1.0" encoding="utf-8"?>
<ExecutionTime>2.347</ExecutionTime> <ExecutionTime>2.347</ExecutionTime>
</ApiResponse>` </ApiResponse>`
var responseGetHostsErrorBadApiKey1 = `<?xml version="1.0" encoding="utf-8"?> var responseGetHostsErrorBadAPIKey1 = `<?xml version="1.0" encoding="utf-8"?>
<ApiResponse Status="ERROR" xmlns="http://api.namecheap.com/xml.response"> <ApiResponse Status="ERROR" xmlns="http://api.namecheap.com/xml.response">
<Errors> <Errors>
<Error Number="1011102">API Key is invalid or API access has not been enabled</Error> <Error Number="1011102">API Key is invalid or API access has not been enabled</Error>