potyarkin/lego
1
0
Fork 0
forked from TrueCloudLab/lego
Code Pull requests Activity

inwx: Increase propagation timeout to 360s to improve robustness (#1314)

Browse source
This commit is contained in:
Michael G 2020-12-14 22:57:19 +01:00 committed by GitHub
parent 4f7f557a5c
commit af597bac81
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 6 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
cmd/zz_gen_cmd_dnshelp.go
View file

@ -981,7 +981,7 @@ func displayDNSHelp(name string) error {
ew.writeln(`Additional Configuration:`) ew.writeln(`Additional Configuration:`)
ew.writeln(` - "INWX_POLLING_INTERVAL": Time between DNS propagation check`) ew.writeln(` - "INWX_POLLING_INTERVAL": Time between DNS propagation check`)
ew.writeln(` - "INWX_PROPAGATION_TIMEOUT": Maximum waiting time for DNS propagation`) ew.writeln(` - "INWX_PROPAGATION_TIMEOUT": Maximum waiting time for DNS propagation (default 360s)`)
ew.writeln(` - "INWX_SANDBOX": Activate the sandbox (boolean)`) ew.writeln(` - "INWX_SANDBOX": Activate the sandbox (boolean)`)
ew.writeln(` - "INWX_SHARED_SECRET": shared secret related to 2FA`) ew.writeln(` - "INWX_SHARED_SECRET": shared secret related to 2FA`)
ew.writeln(` - "INWX_TTL": The TTL of the TXT record used for the DNS challenge`) ew.writeln(` - "INWX_TTL": The TTL of the TXT record used for the DNS challenge`)

2
docs/content/dns/zz_gen_inwx.md
View file

@ -51,7 +51,7 @@ More information [here](/lego/dns/#configuration-and-credentials).
| Environment Variable Name | Description | | Environment Variable Name | Description |
|--------------------------------|-------------| |--------------------------------|-------------|
| `INWX_POLLING_INTERVAL` | Time between DNS propagation check | | `INWX_POLLING_INTERVAL` | Time between DNS propagation check |
| `INWX_PROPAGATION_TIMEOUT` | Maximum waiting time for DNS propagation | | `INWX_PROPAGATION_TIMEOUT` | Maximum waiting time for DNS propagation (default 360s) |
| `INWX_SANDBOX` | Activate the sandbox (boolean) | | `INWX_SANDBOX` | Activate the sandbox (boolean) |
| `INWX_SHARED_SECRET` | shared secret related to 2FA | | `INWX_SHARED_SECRET` | shared secret related to 2FA |
| `INWX_TTL` | The TTL of the TXT record used for the DNS challenge | | `INWX_TTL` | The TTL of the TXT record used for the DNS challenge |

3
providers/dns/inwx/inwx.go
View file

@ -42,7 +42,8 @@ type Config struct {
func NewDefaultConfig() *Config { func NewDefaultConfig() *Config {
return &Config{ return &Config{
TTL: env.GetOrDefaultInt(EnvTTL, 300), TTL: env.GetOrDefaultInt(EnvTTL, 300),
PropagationTimeout: env.GetOrDefaultSecond(EnvPropagationTimeout, dns01.DefaultPropagationTimeout), // INWX has rather unstable propagation delays, thus using a larger default value
PropagationTimeout: env.GetOrDefaultSecond(EnvPropagationTimeout, 360*time.Second),
PollingInterval: env.GetOrDefaultSecond(EnvPollingInterval, dns01.DefaultPollingInterval), PollingInterval: env.GetOrDefaultSecond(EnvPollingInterval, dns01.DefaultPollingInterval),
Sandbox: env.GetOrDefaultBool(EnvSandbox, false), Sandbox: env.GetOrDefaultBool(EnvSandbox, false),
} }

2
providers/dns/inwx/inwx.toml
View file

@ -23,7 +23,7 @@ lego --email myemail@example.com --dns inwx --domains my.example.org run
[Configuration.Additional] [Configuration.Additional]
INWX_SHARED_SECRET = "shared secret related to 2FA" INWX_SHARED_SECRET = "shared secret related to 2FA"
INWX_POLLING_INTERVAL = "Time between DNS propagation check" INWX_POLLING_INTERVAL = "Time between DNS propagation check"
INWX_PROPAGATION_TIMEOUT = "Maximum waiting time for DNS propagation" INWX_PROPAGATION_TIMEOUT = "Maximum waiting time for DNS propagation (default 360s)"
INWX_TTL = "The TTL of the TXT record used for the DNS challenge" INWX_TTL = "The TTL of the TXT record used for the DNS challenge"
INWX_SANDBOX = "Activate the sandbox (boolean)" INWX_SANDBOX = "Activate the sandbox (boolean)"