potyarkin/rclone
1
0
Fork 0
forked from TrueCloudLab/rclone
Code Pull requests Activity

rcserver: avoid generating default credentials with htpasswd - fixes #4839

Browse source
This commit is contained in:
Kamui 2022-11-14 09:26:44 -06:00 • committed by GitHub
parent 0ac5795f8c
commit efd3c6449b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
fs/rc/rcserver/rcserver.go
View file

@ -97,11 +97,11 @@ func newServer(ctx context.Context, opt *rc.Options, mux *http.ServeMux) *Server
if opt.NoAuth { if opt.NoAuth {
fs.Logf(nil, "It is recommended to use web gui with auth.") fs.Logf(nil, "It is recommended to use web gui with auth.")
} else { } else {
if opt.HTTPOptions.BasicUser == "" { if opt.HTTPOptions.BasicUser == "" && opt.HTTPOptions.HtPasswd == "" {
opt.HTTPOptions.BasicUser = "gui" opt.HTTPOptions.BasicUser = "gui"
fs.Infof(nil, "No username specified. Using default username: %s \n", rcflags.Opt.HTTPOptions.BasicUser) fs.Infof(nil, "No username specified. Using default username: %s \n", rcflags.Opt.HTTPOptions.BasicUser)
} }
if opt.HTTPOptions.BasicPass == "" { if opt.HTTPOptions.BasicPass == "" && opt.HTTPOptions.HtPasswd == "" {
randomPass, err := random.Password(128) randomPass, err := random.Password(128)
if err != nil { if err != nil {
log.Fatalf("Failed to make password: %v", err) log.Fatalf("Failed to make password: %v", err)