forked from TrueCloudLab/restic
Better error reporting for CI tests
This commit is contained in:
parent
2e3c541237
commit
aa43b69651
1 changed files with 95 additions and 72 deletions
|
@ -19,6 +19,7 @@ import (
|
||||||
|
|
||||||
var runCrossCompile = flag.Bool("cross-compile", true, "run cross compilation tests")
|
var runCrossCompile = flag.Bool("cross-compile", true, "run cross compilation tests")
|
||||||
var minioServer = flag.String("minio", "", "path to the minio server binary")
|
var minioServer = flag.String("minio", "", "path to the minio server binary")
|
||||||
|
var debug = flag.Bool("debug", false, "output debug messages")
|
||||||
|
|
||||||
var minioServerEnv = map[string]string{
|
var minioServerEnv = map[string]string{
|
||||||
"MINIO_ACCESS_KEY": "KEBIYDZ87HCIH5D17YCN",
|
"MINIO_ACCESS_KEY": "KEBIYDZ87HCIH5D17YCN",
|
||||||
|
@ -36,9 +37,9 @@ func init() {
|
||||||
}
|
}
|
||||||
|
|
||||||
type CIEnvironment interface {
|
type CIEnvironment interface {
|
||||||
Prepare()
|
Prepare() error
|
||||||
RunTests()
|
RunTests() error
|
||||||
Teardown()
|
Teardown() error
|
||||||
}
|
}
|
||||||
|
|
||||||
type TravisEnvironment struct {
|
type TravisEnvironment struct {
|
||||||
|
@ -52,17 +53,16 @@ type TravisEnvironment struct {
|
||||||
env map[string]string
|
env map[string]string
|
||||||
}
|
}
|
||||||
|
|
||||||
func (env *TravisEnvironment) getMinio() {
|
func (env *TravisEnvironment) getMinio() error {
|
||||||
if *minioServer != "" {
|
if *minioServer != "" {
|
||||||
msg("using minio server at %q\n", *minioServer)
|
msg("using minio server at %q\n", *minioServer)
|
||||||
env.minio = *minioServer
|
env.minio = *minioServer
|
||||||
return
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
tempfile, err := ioutil.TempFile("", "minio-server-")
|
tempfile, err := ioutil.TempFile("", "minio-server-")
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Fprintf(os.Stderr, "create tempfile failed: %v\n", err)
|
return fmt.Errorf("create tempfile for minio download failed: %v\n", err)
|
||||||
os.Exit(10)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
url := fmt.Sprintf("https://dl.minio.io/server/minio/release/%s-%s/minio",
|
url := fmt.Sprintf("https://dl.minio.io/server/minio/release/%s-%s/minio",
|
||||||
|
@ -70,66 +70,70 @@ func (env *TravisEnvironment) getMinio() {
|
||||||
msg("downloading %v\n", url)
|
msg("downloading %v\n", url)
|
||||||
res, err := http.Get(url)
|
res, err := http.Get(url)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
msg("downloading minio failed: %v\n", err)
|
return fmt.Errorf("error downloading minio server: %v\n", err)
|
||||||
return
|
|
||||||
}
|
}
|
||||||
|
|
||||||
_, err = io.Copy(tempfile, res.Body)
|
_, err = io.Copy(tempfile, res.Body)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
msg("downloading minio failed: %v\n", err)
|
return fmt.Errorf("error saving minio server to file: %v\n", err)
|
||||||
return
|
|
||||||
}
|
}
|
||||||
|
|
||||||
err = res.Body.Close()
|
err = res.Body.Close()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
msg("saving minio failed: %v\n", err)
|
return fmt.Errorf("error closing HTTP download: %v\n", err)
|
||||||
return
|
|
||||||
}
|
}
|
||||||
|
|
||||||
err = tempfile.Close()
|
err = tempfile.Close()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
msg("closing tempfile failed: %v\n", err)
|
msg("closing tempfile failed: %v\n", err)
|
||||||
return
|
return fmt.Errorf("error closing minio server file: %v\n", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
err = os.Chmod(tempfile.Name(), 0755)
|
err = os.Chmod(tempfile.Name(), 0755)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
msg("making minio server executable failed: %v\n", err)
|
return fmt.Errorf("chmod(minio-server) failed: %v", err)
|
||||||
return
|
|
||||||
}
|
}
|
||||||
|
|
||||||
msg("downloaded minio server to %v\n", tempfile.Name())
|
msg("downloaded minio server to %v\n", tempfile.Name())
|
||||||
env.minio = tempfile.Name()
|
env.minio = tempfile.Name()
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (env *TravisEnvironment) runMinio() {
|
func (env *TravisEnvironment) runMinio() error {
|
||||||
// start minio server
|
if env.minio == "" {
|
||||||
if env.minio != "" {
|
return nil
|
||||||
msg("starting minio server at %s", env.minio)
|
|
||||||
|
|
||||||
dir, err := ioutil.TempDir("", "minio-root")
|
|
||||||
if err != nil {
|
|
||||||
os.Exit(80)
|
|
||||||
}
|
|
||||||
|
|
||||||
env.minioSrv, err = StartBackgroundCommand(minioServerEnv, env.minio,
|
|
||||||
"server",
|
|
||||||
"--address", "127.0.0.1:9000",
|
|
||||||
dir)
|
|
||||||
if err != nil {
|
|
||||||
fmt.Fprintf(os.Stderr, "error running minio server: %v", err)
|
|
||||||
os.Exit(80)
|
|
||||||
}
|
|
||||||
|
|
||||||
for k, v := range minioEnv {
|
|
||||||
env.env[k] = v
|
|
||||||
}
|
|
||||||
|
|
||||||
env.minioTempdir = dir
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// start minio server
|
||||||
|
msg("starting minio server at %s", env.minio)
|
||||||
|
|
||||||
|
dir, err := ioutil.TempDir("", "minio-root")
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("running minio server failed: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
env.minioSrv, err = StartBackgroundCommand(minioServerEnv, env.minio,
|
||||||
|
"server",
|
||||||
|
"--address", "127.0.0.1:9000",
|
||||||
|
dir)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("error running minio server: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// go func() {
|
||||||
|
// time.Sleep(300 * time.Millisecond)
|
||||||
|
// env.minioSrv.Cmd.Process.Kill()
|
||||||
|
// }()
|
||||||
|
|
||||||
|
for k, v := range minioEnv {
|
||||||
|
env.env[k] = v
|
||||||
|
}
|
||||||
|
|
||||||
|
env.minioTempdir = dir
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (env *TravisEnvironment) Prepare() {
|
func (env *TravisEnvironment) Prepare() error {
|
||||||
env.env = make(map[string]string)
|
env.env = make(map[string]string)
|
||||||
|
|
||||||
msg("preparing environment for Travis CI\n")
|
msg("preparing environment for Travis CI\n")
|
||||||
|
@ -170,17 +174,27 @@ func (env *TravisEnvironment) Prepare() {
|
||||||
"-arch", strings.Join(env.goxArch, " "))
|
"-arch", strings.Join(env.goxArch, " "))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (env *TravisEnvironment) Teardown() {
|
func (env *TravisEnvironment) Teardown() error {
|
||||||
msg("run travis teardown\n")
|
msg("run travis teardown\n")
|
||||||
if env.minioSrv != nil {
|
if env.minioSrv != nil {
|
||||||
msg("stopping minio server\n")
|
msg("stopping minio server\n")
|
||||||
result := <-env.minioSrv.Result
|
|
||||||
if result.Error != nil {
|
if env.minioSrv.Cmd.ProcessState == nil {
|
||||||
msg("minio server returned error: %v\n", result.Error)
|
err := env.minioSrv.Cmd.Process.Kill()
|
||||||
msg("stdout: %s\n", result.Stdout)
|
if err != nil {
|
||||||
msg("stderr: %s\n", result.Stderr)
|
fmt.Fprintf(os.Stderr, "error killing minio server process: %v", err)
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
result := <-env.minioSrv.Result
|
||||||
|
if result.Error != nil {
|
||||||
|
msg("minio server returned error: %v\n", result.Error)
|
||||||
|
msg("stdout: %s\n", result.Stdout)
|
||||||
|
msg("stderr: %s\n", result.Stderr)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
err := os.RemoveAll(env.minioTempdir)
|
err := os.RemoveAll(env.minioTempdir)
|
||||||
|
@ -188,6 +202,8 @@ func (env *TravisEnvironment) Teardown() {
|
||||||
msg("error removing minio tempdir %v: %v\n", env.minioTempdir, err)
|
msg("error removing minio tempdir %v: %v\n", env.minioTempdir, err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func goVersionAtLeast151() bool {
|
func goVersionAtLeast151() bool {
|
||||||
|
@ -206,7 +222,6 @@ func goVersionAtLeast151() bool {
|
||||||
|
|
||||||
type Background struct {
|
type Background struct {
|
||||||
Cmd *exec.Cmd
|
Cmd *exec.Cmd
|
||||||
Done chan struct{}
|
|
||||||
Result chan Result
|
Result chan Result
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -218,7 +233,6 @@ type Result struct {
|
||||||
func StartBackgroundCommand(env map[string]string, cmd string, args ...string) (*Background, error) {
|
func StartBackgroundCommand(env map[string]string, cmd string, args ...string) (*Background, error) {
|
||||||
msg("running background command %v %v\n", cmd, args)
|
msg("running background command %v %v\n", cmd, args)
|
||||||
b := Background{
|
b := Background{
|
||||||
Done: make(chan struct{}),
|
|
||||||
Result: make(chan Result, 1),
|
Result: make(chan Result, 1),
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -228,6 +242,11 @@ func StartBackgroundCommand(env map[string]string, cmd string, args ...string) (
|
||||||
c := exec.Command(cmd, args...)
|
c := exec.Command(cmd, args...)
|
||||||
c.Stdout = stdout
|
c.Stdout = stdout
|
||||||
c.Stderr = stderr
|
c.Stderr = stderr
|
||||||
|
|
||||||
|
if *debug {
|
||||||
|
c.Stdout = io.MultiWriter(c.Stdout, os.Stdout)
|
||||||
|
c.Stderr = io.MultiWriter(c.Stderr, os.Stderr)
|
||||||
|
}
|
||||||
c.Env = updateEnv(os.Environ(), env)
|
c.Env = updateEnv(os.Environ(), env)
|
||||||
|
|
||||||
b.Cmd = c
|
b.Cmd = c
|
||||||
|
@ -241,6 +260,8 @@ func StartBackgroundCommand(env map[string]string, cmd string, args ...string) (
|
||||||
go func() {
|
go func() {
|
||||||
err := b.Cmd.Wait()
|
err := b.Cmd.Wait()
|
||||||
msg("background job %v returned: %v\n", cmd, err)
|
msg("background job %v returned: %v\n", cmd, err)
|
||||||
|
msg("stdout: %s\n", stdout.Bytes())
|
||||||
|
msg("stderr: %s\n", stderr.Bytes())
|
||||||
b.Result <- Result{
|
b.Result <- Result{
|
||||||
Stdout: string(stdout.Bytes()),
|
Stdout: string(stdout.Bytes()),
|
||||||
Stderr: string(stderr.Bytes()),
|
Stderr: string(stderr.Bytes()),
|
||||||
|
@ -251,7 +272,7 @@ func StartBackgroundCommand(env map[string]string, cmd string, args ...string) (
|
||||||
return &b, nil
|
return &b, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (env *TravisEnvironment) RunTests() {
|
func (env *TravisEnvironment) RunTests() error {
|
||||||
// run fuse tests on darwin
|
// run fuse tests on darwin
|
||||||
if runtime.GOOS != "darwin" {
|
if runtime.GOOS != "darwin" {
|
||||||
msg("skip fuse integration tests on %v\n", runtime.GOOS)
|
msg("skip fuse integration tests on %v\n", runtime.GOOS)
|
||||||
|
@ -260,8 +281,7 @@ func (env *TravisEnvironment) RunTests() {
|
||||||
|
|
||||||
cwd, err := os.Getwd()
|
cwd, err := os.Getwd()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Fprintf(os.Stderr, "Getwd() returned error: %v", err)
|
return fmt.Errorf("Getwd() returned error: %v", err)
|
||||||
os.Exit(9)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
env.env["GOPATH"] = cwd + ":" + filepath.Join(cwd, "vendor")
|
env.env["GOPATH"] = cwd + ":" + filepath.Join(cwd, "vendor")
|
||||||
|
@ -284,20 +304,24 @@ func (env *TravisEnvironment) RunTests() {
|
||||||
// run the tests and gather coverage information
|
// run the tests and gather coverage information
|
||||||
runWithEnv(env.env, "gotestcover", "-coverprofile", "all.cov", "cmds/...", "restic/...")
|
runWithEnv(env.env, "gotestcover", "-coverprofile", "all.cov", "cmds/...", "restic/...")
|
||||||
|
|
||||||
runGofmt()
|
return runGofmt()
|
||||||
}
|
}
|
||||||
|
|
||||||
type AppveyorEnvironment struct{}
|
type AppveyorEnvironment struct{}
|
||||||
|
|
||||||
func (env *AppveyorEnvironment) Prepare() {
|
func (env *AppveyorEnvironment) Prepare() error {
|
||||||
msg("preparing environment for Appveyor CI\n")
|
msg("preparing environment for Appveyor CI\n")
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (env *AppveyorEnvironment) RunTests() {
|
func (env *AppveyorEnvironment) RunTests() error {
|
||||||
run("go", "run", "build.go", "-v", "-T")
|
run("go", "run", "build.go", "-v", "-T")
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (env *AppveyorEnvironment) Teardown() {}
|
func (env *AppveyorEnvironment) Teardown() error {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
// findGoFiles returns a list of go source code file names below dir.
|
// findGoFiles returns a list of go source code file names below dir.
|
||||||
func findGoFiles(dir string) (list []string, err error) {
|
func findGoFiles(dir string) (list []string, err error) {
|
||||||
|
@ -345,17 +369,15 @@ func updateEnv(env []string, override map[string]string) []string {
|
||||||
return newEnv
|
return newEnv
|
||||||
}
|
}
|
||||||
|
|
||||||
func runGofmt() {
|
func runGofmt() error {
|
||||||
dir, err := os.Getwd()
|
dir, err := os.Getwd()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Fprintf(os.Stderr, "Getwd(): %v\n", err)
|
return fmt.Errorf("Getwd(): %v\n", err)
|
||||||
os.Exit(5)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
files, err := findGoFiles(dir)
|
files, err := findGoFiles(dir)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Fprintf(os.Stderr, "error finding Go files: %v\n", err)
|
return fmt.Errorf("error finding Go files: %v\n", err)
|
||||||
os.Exit(4)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
msg("runGofmt() with %d files\n", len(files))
|
msg("runGofmt() with %d files\n", len(files))
|
||||||
|
@ -365,16 +387,14 @@ func runGofmt() {
|
||||||
|
|
||||||
buf, err := cmd.Output()
|
buf, err := cmd.Output()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Fprintf(os.Stderr, "error running gofmt: %v", err)
|
return fmt.Errorf("error running gofmt: %v\noutput: %s\n", err, buf)
|
||||||
fmt.Fprintf(os.Stderr, "output:\n%s\n", buf)
|
|
||||||
os.Exit(3)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
if len(buf) > 0 {
|
if len(buf) > 0 {
|
||||||
fmt.Fprintf(os.Stderr, "not formatted with `gofmt`:\n")
|
return fmt.Errorf("not formatted with `gofmt`:\n%s\n", buf)
|
||||||
fmt.Fprintln(os.Stderr, string(buf))
|
|
||||||
os.Exit(6)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func run(command string, args ...string) {
|
func run(command string, args ...string) {
|
||||||
|
@ -384,7 +404,7 @@ func run(command string, args ...string) {
|
||||||
|
|
||||||
// runWithEnv calls a command with the current environment, except the entries
|
// runWithEnv calls a command with the current environment, except the entries
|
||||||
// of the env map are set additionally.
|
// of the env map are set additionally.
|
||||||
func runWithEnv(env map[string]string, command string, args ...string) {
|
func runWithEnv(env map[string]string, command string, args ...string) error {
|
||||||
msg("runWithEnv %v %v\n", command, strings.Join(args, " "))
|
msg("runWithEnv %v %v\n", command, strings.Join(args, " "))
|
||||||
cmd := exec.Command(command, args...)
|
cmd := exec.Command(command, args...)
|
||||||
cmd.Stdout = os.Stdout
|
cmd.Stdout = os.Stdout
|
||||||
|
@ -395,10 +415,10 @@ func runWithEnv(env map[string]string, command string, args ...string) {
|
||||||
err := cmd.Run()
|
err := cmd.Run()
|
||||||
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
fmt.Fprintf(os.Stderr, "error running %v %v: %v",
|
return fmt.Errorf("error running %v %v: %v",
|
||||||
command, strings.Join(args, " "), err)
|
command, strings.Join(args, " "), err)
|
||||||
os.Exit(3)
|
|
||||||
}
|
}
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func isTravis() bool {
|
func isTravis() bool {
|
||||||
|
@ -422,7 +442,10 @@ func main() {
|
||||||
os.Exit(1)
|
os.Exit(1)
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, f := range []func(){env.Prepare, env.RunTests, env.Teardown} {
|
for _, f := range []func() error{env.Prepare, env.RunTests, env.Teardown} {
|
||||||
f()
|
err := f()
|
||||||
|
if err != nil {
|
||||||
|
fmt.Fprintf(os.Stderr, "error: %v\n", err)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
Loading…
Add table
Reference in a new issue