distribution/dockerfiles/lint.Dockerfile

# syntax=docker/dockerfile:1

ARG GO_VERSION=1.20.9
ARG ALPINE_VERSION=3.18
ARG GOLANGCI_LINT_VERSION=v1.54.2
ARG BUILDTAGS="include_gcs"

FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint

FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS base
RUN apk add --no-cache gcc musl-dev
WORKDIR /src

FROM base
ENV GOFLAGS="-buildvcs=false"
RUN --mount=type=bind,target=. \
    --mount=type=cache,target=/root/.cache \
    --mount=from=golangci-lint,source=/usr/bin/golangci-lint,target=/usr/bin/golangci-lint \
      golangci-lint --build-tags "${BUILDTAGS}" run
lint target and workflow job Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-05-03 10:51:31 +00:00			`# syntax=docker/dockerfile:1`

update to go1.20.9, test go1.21.2 go1.20.9 (released 2023-10-05) includes one security fixes to the cmd/go package, as well as bug fixes to the go command and the linker. See the Go 1.20.9 milestone on our issue tracker for details: https://github.com/golang/go/issues?q=milestone%3AGo1.20.9+label%3ACherryPickApproved full diff: https://github.com/golang/go/compare/go1.20.8...go1.20.9 From the security mailing: [security] Go 1.21.2 and Go 1.20.9 are released Hello gophers, We have just released Go versions 1.21.2 and 1.20.9, minor point releases. These minor releases include 1 security fixes following the security policy: - cmd/go: line directives allows arbitrary execution during build "//line" directives can be used to bypass the restrictions on "//go:cgo_" directives, allowing blocked linker and compiler flags to be passed during compliation. This can result in unexpected execution of arbitrary code when running "go build". The line directive requires the absolute path of the file in which the directive lives, which makes exploting this issue significantly more complex. This is CVE-2023-39323 and Go issue https://go.dev/issue/63211. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2023-10-19 08:13:32 +00:00			`ARG GO_VERSION=1.20.9`
Update to golang 1.19.10 This addresses CVE-2023-29402, CVE-2023-29403, CVE-2023-29404, CVE-2023-29405 which were patched in 1.19.10. Signed-off-by: Ben Manuel <ben.manuel@procore.com> 2023-06-29 20:34:00 +00:00			`ARG ALPINE_VERSION=3.18`
Handle rand deprecations in go 1.20 Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com> 2023-08-27 10:06:16 +00:00			`ARG GOLANGCI_LINT_VERSION=v1.54.2`
Remove oss storage driver and alicdn storage driver middleware This commit removes `oss` storage driver from distribution as well as `alicdn` storage middleware which only works with the `oss` driver. There are several reasons for it: * no real-life expertise among the maintainers * oss is compatible with S3 API operations required by S3 storage driver Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com> 2023-08-16 07:39:20 +00:00			`ARG BUILDTAGS="include_gcs"`
lint target and workflow job Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-05-03 10:51:31 +00:00
			`FROM golangci/golangci-lint:${GOLANGCI_LINT_VERSION}-alpine AS golangci-lint`

dockerfiles: set ALPINE_VERSION Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-07-20 12:19:39 +00:00			`FROM golang:${GO_VERSION}-alpine${ALPINE_VERSION} AS base`
lint target and workflow job Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-05-03 10:51:31 +00:00			`RUN apk add --no-cache gcc musl-dev`
			`WORKDIR /src`

			`FROM base`
update to go 1.18 (continue testing against 1.17) Go 1.16 reached end of life, so update to the current version of Go, but also run CI on the previous version (which is still supported). We should probably also decide wether or not we want the Dockerfiles to pin to a specific minor version; this makes the releases more deterministic. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> 2022-05-05 08:20:56 +00:00			`ENV GOFLAGS="-buildvcs=false"`
lint target and workflow job Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-05-03 10:51:31 +00:00			`RUN --mount=type=bind,target=. \`
dockerfiles: formatting Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com> 2022-07-20 14:44:31 +00:00			`--mount=type=cache,target=/root/.cache \`
			`--mount=from=golangci-lint,source=/usr/bin/golangci-lint,target=/usr/bin/golangci-lint \`
Enable Go build tags This enables go build tags so the GCS and OSS driver support is available in the binary distributed via the image build by Dockerfile. This led to quite a few fixes in the GCS and OSS packages raised as warning by golang-ci linter. Signed-off-by: Milos Gajdos <milosthegajdos@gmail.com> 2023-06-28 10:41:22 +00:00			`golangci-lint --build-tags "${BUILDTAGS}" run`