forked from TrueCloudLab/distribution
671184e910
Defining an interface on the implementer side is generally not best practice in Go code. There is no code in the distribution module which consumes a ManifestBuilder value so there is no need to define the interface in the distribution module. Export the concrete ManifestBuilder types and modify the constructors to return concrete values. Co-authored-by: Sebastiaan van Stijn <github@gone.nl> Signed-off-by: Cory Snider <csnider@mirantis.com>
57 lines
1.6 KiB
Go
57 lines
1.6 KiB
Go
package schema2
|
|
|
|
import (
|
|
"context"
|
|
|
|
"github.com/distribution/distribution/v3"
|
|
)
|
|
|
|
// Builder is a type for constructing manifests.
|
|
type Builder struct {
|
|
// configDescriptor is used to describe configuration
|
|
configDescriptor distribution.Descriptor
|
|
|
|
// configJSON references
|
|
configJSON []byte
|
|
|
|
// dependencies is a list of descriptors that gets built by successive
|
|
// calls to AppendReference. In case of image configuration these are layers.
|
|
dependencies []distribution.Descriptor
|
|
}
|
|
|
|
// NewManifestBuilder is used to build new manifests for the current schema
|
|
// version. It takes a BlobService so it can publish the configuration blob
|
|
// as part of the Build process.
|
|
func NewManifestBuilder(configDescriptor distribution.Descriptor, configJSON []byte) *Builder {
|
|
mb := &Builder{
|
|
configDescriptor: configDescriptor,
|
|
configJSON: make([]byte, len(configJSON)),
|
|
}
|
|
copy(mb.configJSON, configJSON)
|
|
|
|
return mb
|
|
}
|
|
|
|
// Build produces a final manifest from the given references.
|
|
func (mb *Builder) Build(ctx context.Context) (distribution.Manifest, error) {
|
|
m := Manifest{
|
|
Versioned: SchemaVersion,
|
|
Layers: make([]distribution.Descriptor, len(mb.dependencies)),
|
|
}
|
|
copy(m.Layers, mb.dependencies)
|
|
|
|
m.Config = mb.configDescriptor
|
|
|
|
return FromStruct(m)
|
|
}
|
|
|
|
// AppendReference adds a reference to the current ManifestBuilder.
|
|
func (mb *Builder) AppendReference(d distribution.Describable) error {
|
|
mb.dependencies = append(mb.dependencies, d.Descriptor())
|
|
return nil
|
|
}
|
|
|
|
// References returns the current references added to this builder.
|
|
func (mb *Builder) References() []distribution.Descriptor {
|
|
return mb.dependencies
|
|
}
|