From 1ced82a71475ae8c6dac9f78185294af1985b05e Mon Sep 17 00:00:00 2001 From: Denis Kirillov Date: Fri, 6 Oct 2023 16:14:09 +0300 Subject: [PATCH] [#70] Fix log messages (move to constants) Signed-off-by: Denis Kirillov --- cmd/http-gw/settings.go | 4 ++-- internal/logs/logs.go | 3 +++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/cmd/http-gw/settings.go b/cmd/http-gw/settings.go index cb309b7..7e53158 100644 --- a/cmd/http-gw/settings.go +++ b/cmd/http-gw/settings.go @@ -560,7 +560,7 @@ func fetchCacheLifetime(v *viper.Viper, l *zap.Logger, cfgEntry string, defaultV if v.IsSet(cfgEntry) { lifetime := v.GetDuration(cfgEntry) if lifetime <= 0 { - l.Error("invalid lifetime, using default value (in seconds)", + l.Error(logs.InvalidLifetimeUsingDefaultValue, zap.String("parameter", cfgEntry), zap.Duration("value in config", lifetime), zap.Duration("default", defaultValue)) @@ -576,7 +576,7 @@ func fetchCacheSize(v *viper.Viper, l *zap.Logger, cfgEntry string, defaultValue if v.IsSet(cfgEntry) { size := v.GetInt(cfgEntry) if size <= 0 { - l.Error("invalid cache size, using default value", + l.Error(logs.InvalidCacheSizeUsingDefaultValue, zap.String("parameter", cfgEntry), zap.Int("value in config", size), zap.Int("default", defaultValue)) diff --git a/internal/logs/logs.go b/internal/logs/logs.go index 0534ebc..9d464c3 100644 --- a/internal/logs/logs.go +++ b/internal/logs/logs.go @@ -70,4 +70,7 @@ const ( CouldntGetBucket = "could not get bucket" // Error in ../handler/utils.go CouldntPutBucketIntoCache = "couldn't put bucket info into cache" // Warn in ../handler/handler.go InvalidCacheEntryType = "invalid cache entry type" // Warn in ../cache/buckets.go + InvalidLifetimeUsingDefaultValue = "invalid lifetime, using default value (in seconds)" // Error in ../../cmd/http-gw/settings.go + InvalidCacheSizeUsingDefaultValue = "invalid cache size, using default value" // Error in ../../cmd/http-gw/settings.go + )