realloc/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Releases Packages Activity

[#580] v2/object/put: Check payload size of the relayed objects

Browse source 
NeoFS network dictates the limitation of the maximum size of the "finished"
objects. The payload size of an object is recorded in its header. When
writing finished objects, the nodes must check:

  * satisfying the constraint;
  * matching the value in the header to the number of payload bytes.

Provide value returned by `MaxSizeSource` component to `validatingTarget`.
Check max size value during the stream of the "finished" objects. Check
header value during the streaming and on-close. Check payload size in v2
relay scenario.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
Leonard Lyubich 2021-06-07 12:29:38 +03:00 • committed by Alex Vanin
parent 2f38fef31a
commit 096acb2a44
3 changed files with 119 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

23
pkg/services/object/put/streamer.go
View file

@ -21,6 +21,8 @@ type Streamer struct {
target transformer.ObjectTarget
relay func(client.Client) error
maxPayloadSz uint64 // network config
}
var errNotInit = errors.New("stream not initialized")
@ -39,6 +41,13 @@ func (p *Streamer) Init(prm *PutInitPrm) error {
return nil
}
// MaxObjectSize returns maximum payload size for the streaming session.
//
// Must be called after the successful Init.
func (p *Streamer) MaxObjectSize() uint64 {
return p.maxPayloadSz
}
func (p *Streamer) initTarget(prm *PutInitPrm) error {
// prevent re-calling
if p.target != nil {
@ -50,6 +59,11 @@ func (p *Streamer) initTarget(prm *PutInitPrm) error {
return fmt.Errorf("(%T) could not prepare put parameters: %w", p, err)
}
p.maxPayloadSz = p.maxSizeSrc.MaxObjectSize()
if p.maxPayloadSz == 0 {
return fmt.Errorf("(%T) could not obtain max object size parameter", p)
}
if prm.hdr.Signature() != nil {
p.relay = prm.relay
@ -57,6 +71,8 @@ func (p *Streamer) initTarget(prm *PutInitPrm) error {
p.target = &validatingTarget{
nextTarget: p.newCommonTarget(prm),
fmt: p.fmtValidator,
maxPayloadSz: p.maxPayloadSz,
}
return nil
@ -72,13 +88,8 @@ func (p *Streamer) initTarget(prm *PutInitPrm) error {
return fmt.Errorf("(%T) could not receive session key: %w", p, err)
}
maxSz := p.maxSizeSrc.MaxObjectSize()
if maxSz == 0 {
return fmt.Errorf("(%T) could not obtain max object size parameter", p)
}
p.target = transformer.NewPayloadSizeLimiter(
maxSz,
p.maxPayloadSz,
func() transformer.ObjectTarget {
return transformer.NewFormatTarget(&transformer.FormatterParams{
Key: sessionKey,