[#1349] node: Evacuate objects without setting mode to MAINTENANCE

Signed-off-by: Anton Nikiforov <an.nikiforov@yadro.com>

pkg/local_object_storage/engine/evacuate.go

@@ -366,6 +366,7 @@ func (e *StorageEngine) evacuateShardObjects(ctx context.Context, shardID string
 	listPrm.WithCount(defaultEvacuateBatchSize)
 
 	sh := shardsToEvacuate[shardID]
+	sh.SetEvacuationInProgress(true)
 
 	var c *meta.Cursor
 	for {
@@ -655,6 +656,7 @@ func (e *StorageEngine) evacuateObjects(ctx context.Context, sh *shard.Shard, to
 
 		var getPrm shard.GetPrm
 		getPrm.SetAddress(addr)
+		getPrm.SkipEvacCheck(true)
 
 		getRes, err := sh.Get(ctx, getPrm)
 		if err != nil {
@@ -765,3 +767,11 @@ func (e *StorageEngine) ResetEvacuationStatus(ctx context.Context) error {
 
 	return e.evacuateLimiter.ResetEvacuationStatus()
 }
+
+func (e *StorageEngine) ResetEvacuationStatusForShards() {
+	e.mtx.RLock()
+	defer e.mtx.RUnlock()
+	for _, sh := range e.shards {
+		sh.SetEvacuationInProgress(false)
+	}
+}

pkg/local_object_storage/engine/evacuate_test.go

@@ -125,6 +125,34 @@ func TestEvacuateShardObjects(t *testing.T) {
 	// Second case ensures that all objects are indeed moved and available.
 	checkHasObjects(t)
 
+	// Objects on evacuated shards should be logically unavailable, but persisted on disk.
+	// This is necessary to prevent removing it by policer in case of `REP 1` policy.
+	for _, obj := range objects[len(objects)-objPerShard:] {
+		var prmGet shard.GetPrm
+		prmGet.SetAddress(objectCore.AddressOf(obj))
+		_, err = e.shards[evacuateShardID].Get(context.Background(), prmGet)
+		require.Error(t, err)
+
+		prmGet.SkipEvacCheck(true)
+		_, err = e.shards[evacuateShardID].Get(context.Background(), prmGet)
+		require.NoError(t, err)
+
+		var prmHead shard.HeadPrm
+		prmHead.SetAddress(objectCore.AddressOf(obj))
+		_, err = e.shards[evacuateShardID].Head(context.Background(), prmHead)
+		require.Error(t, err)
+
+		var existsPrm shard.ExistsPrm
+		existsPrm.Address = objectCore.AddressOf(obj)
+		_, err = e.shards[evacuateShardID].Exists(context.Background(), existsPrm)
+		require.Error(t, err)
+
+		var rngPrm shard.RngPrm
+		rngPrm.SetAddress(objectCore.AddressOf(obj))
+		_, err = e.shards[evacuateShardID].GetRange(context.Background(), rngPrm)
+		require.Error(t, err)
+	}
+
 	// Calling it again is OK, but all objects are already moved, so no new PUTs should be done.
 	res, err = e.Evacuate(context.Background(), prm)
 	require.NoError(t, err)

pkg/local_object_storage/engine/metrics.go

@@ -30,6 +30,7 @@ type MetricRegister interface {
 	IncRefillObjectsCount(shardID, path string, size int, success bool)
 	SetRefillPercent(shardID, path string, percent uint32)
 	SetRefillStatus(shardID, path, status string)
+	SetEvacuationInProgress(shardID string, value bool)
 
 	WriteCache() metrics.WriteCacheMetrics
 	GC() metrics.GCMetrics

pkg/local_object_storage/engine/shards.go

@@ -97,6 +97,10 @@ func (m *metricsWithID) SetRefillStatus(path string, status string) {
 	m.mw.SetRefillStatus(m.id, path, status)
 }
 
+func (m *metricsWithID) SetEvacuationInProgress(value bool) {
+	m.mw.SetEvacuationInProgress(m.id, value)
+}
+
 // AddShard adds a new shard to the storage engine.
 //
 // Returns any error encountered that did not allow adding a shard.