realloc/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Releases Packages Activity

[#180] node: Refactor panics in unit test

Browse source 
* Replace panics in unit tests by require.NoError and t.Fatalf

Signed-off-by: Airat Arifullin <a.arifullin@yadro.com>
This commit is contained in:
Airat Arifullin 2023-03-28 17:16:03 +03:00
parent 91717d4b98
commit 221203beeb
30 changed files with 76 additions and 79 deletions
Download patch file Download diff file Expand all files Collapse all files

9
pkg/services/tree/getsubtree_test.go
View file

@ -118,7 +118,10 @@ func TestGetSubTree(t *testing.T) {
})
}
var errSubTreeSend = errors.New("test error")
var (
errSubTreeSend = errors.New("send finished with error")
errSubTreeSendAfterError = errors.New("send was invoked after an error occurred")
)
type subTreeAcc struct {
grpc.ServerStream // to satisfy the interface
@ -127,6 +130,8 @@ type subTreeAcc struct {
errIndex int
}
var _ TreeService_GetSubTreeServer = &subTreeAcc{}
func (s *subTreeAcc) Send(r *GetSubTreeResponse) error {
s.seen = append(s.seen, r)
if s.errIndex >= 0 {
@ -134,7 +139,7 @@ func (s *subTreeAcc) Send(r *GetSubTreeResponse) error {
return errSubTreeSend
}
if s.errIndex >= 0 && len(s.seen) > s.errIndex {
panic("called Send after an error was returned")
return errSubTreeSendAfterError
}
}
return nil