realloc/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Releases Packages Activity

[#1916] control: Check maintenance allowance on Control server

Browse source 
In previous implementation turning to maintenance mode using NeoFS CLI
required NeoFS API endpoint. This was not convenient from the user
perspective. It's worth to move networks settings' check to the server
side.

Add `force_maintenance` field to `SetNetmapStatusRequest.Body` message
of Control API. Add `force` flag to `neofs-cli control set-status`
command which sets corresponding field in the requests body if status is
`maintenance`. Force flag is ignored for any other status.

Signed-off-by: Leonard Lyubich <ctulhurider@gmail.com>
This commit is contained in:
Leonard Lyubich 2022-10-18 19:42:14 +04:00 • committed by LeL
parent c50603494b
commit 60e9de8d63
10 changed files with 346 additions and 272 deletions
Download patch file Download diff file Expand all files Collapse all files

51
cmd/neofs-cli/modules/control/set_netmap_status.go
View file

@ -4,13 +4,11 @@ import (
"fmt"
rawclient "github.com/nspcc-dev/neofs-api-go/v2/rpc/client"
internalclient "github.com/nspcc-dev/neofs-node/cmd/neofs-cli/internal/client"
"github.com/nspcc-dev/neofs-node/cmd/neofs-cli/internal/common"
"github.com/nspcc-dev/neofs-node/cmd/neofs-cli/internal/commonflags"
"github.com/nspcc-dev/neofs-node/cmd/neofs-cli/internal/key"
"github.com/nspcc-dev/neofs-node/pkg/services/control"
"github.com/spf13/cobra"
"github.com/spf13/viper"
)
const (
@ -41,53 +39,40 @@ func initControlSetNetmapStatusCmd() {
)
_ = setNetmapStatusCmd.MarkFlagRequired(netmapStatusFlag)
flags.BoolP(commonflags.ForceFlag, commonflags.ForceFlagShorthand, false,
"Force turning to local maintenance")
}
func setNetmapStatus(cmd *cobra.Command, _ []string) {
pk := key.Get(cmd)
body := new(control.SetNetmapStatusRequest_Body)
force, _ := cmd.Flags().GetBool(commonflags.ForceFlag)
var status control.NetmapStatus
printIgnoreForce := func(st control.NetmapStatus) {
if force {
common.PrintVerbose("Ignore --%s flag for %s state.", commonflags.ForceFlag, st)
}
}
switch st, _ := cmd.Flags().GetString(netmapStatusFlag); st {
default:
common.ExitOnErr(cmd, "", fmt.Errorf("unsupported status %s", st))
case netmapStatusOnline:
status = control.NetmapStatus_ONLINE
body.SetStatus(control.NetmapStatus_ONLINE)
printIgnoreForce(control.NetmapStatus_ONLINE)
case netmapStatusOffline:
status = control.NetmapStatus_OFFLINE
body.SetStatus(control.NetmapStatus_OFFLINE)
printIgnoreForce(control.NetmapStatus_OFFLINE)
case netmapStatusMaintenance:
status = control.NetmapStatus_MAINTENANCE
body.SetStatus(control.NetmapStatus_MAINTENANCE)
common.PrintVerbose("Reading network settings to check allowance of \"%s\" mode...", st)
if !viper.IsSet(commonflags.RPC) {
common.ExitOnErr(cmd, "",
fmt.Errorf("flag --%s (-%s) is not set, you must specify it for \"%s\" mode",
commonflags.RPC,
commonflags.RPCShorthand,
st,
),
)
if force {
body.SetForceMaintenance()
common.PrintVerbose("Local maintenance will be forced.")
}
cli := internalclient.GetSDKClientByFlag(cmd, pk, commonflags.RPC)
var prm internalclient.NetworkInfoPrm
prm.SetClient(cli)
res, err := internalclient.NetworkInfo(prm)
common.ExitOnErr(cmd, "receive network info: %v", err)
if !res.NetworkInfo().MaintenanceModeAllowed() {
common.ExitOnErr(cmd, "", fmt.Errorf("\"%s\" mode is not allowed by the network", st))
}
common.PrintVerbose("\"%s\" mode is allowed, continue processing...", st)
}
body := new(control.SetNetmapStatusRequest_Body)
body.SetStatus(status)
req := new(control.SetNetmapStatusRequest)
req.SetBody(body)