realloc/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Releases Packages Activity

[#1492] metabase: Ensure Unmarshal() is called on a cloned slice

Browse source 
The slice returned from bucket.Get() is only valid during the tx
lifetime. Cloning it is not necessary everywhere, but better safe than
sorry.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>
This commit is contained in:
Evgenii Stratonikov 2024-11-13 10:07:32 +03:00 • committed by Evgenii Stratonikov
parent b451de94c8
commit 8ed7a676d5
5 changed files with 10 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
pkg/local_object_storage/metabase/put.go
View file

@ -1,6 +1,7 @@
package meta
import (
"bytes"
"context"
"encoding/binary"
"errors"
@ -313,7 +314,7 @@ func updateSplitInfoIndex(tx *bbolt.Tx, objKey []byte, cnr cid.ID, bucketName []
return si.Marshal()
default:
oldSI := objectSDK.NewSplitInfo()
if err := oldSI.Unmarshal(old); err != nil {
if err := oldSI.Unmarshal(bytes.Clone(old)); err != nil {
return nil, err
}
si = util.MergeSplitInfo(si, oldSI)