realloc/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Releases Packages Activity

[#505] morph/container: Do not parse public key in Put event parser

Browse source 
Morph event structures defined in `pkg/morph/event`  should only carry
notification values without any additional interpretation. All logical work
should be concentrated on app-side.

Change data type of `Put.PublicKey` return to byte slice. `ParsePut` doesn't
unmarshal public key from now.

Signed-off-by: Leonard Lyubich <leonard@nspcc.ru>
This commit is contained in:
Leonard Lyubich 2021-05-19 17:16:48 +03:00 • committed by Alex Vanin
parent a306eb9ce7
commit a3ac294902
3 changed files with 7 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

13
pkg/morph/event/container/put.go
View file

@ -1,10 +1,8 @@
package container
import (
"crypto/elliptic"
"fmt"
"github.com/nspcc-dev/neo-go/pkg/crypto/keys"
"github.com/nspcc-dev/neo-go/pkg/vm/stackitem"
"github.com/nspcc-dev/neofs-node/pkg/morph/client"
"github.com/nspcc-dev/neofs-node/pkg/morph/event"
@ -14,7 +12,7 @@ import (
type Put struct {
rawContainer []byte
signature []byte
publicKey *keys.PublicKey
publicKey []byte
}
// MorphEvent implements Neo:Morph Event interface.
@ -27,7 +25,7 @@ func (p Put) Container() []byte { return p.rawContainer }
func (p Put) Signature() []byte { return p.signature }
// PublicKey of container owner.
func (p Put) PublicKey() *keys.PublicKey { return p.publicKey }
func (p Put) PublicKey() []byte { return p.publicKey }
// ParsePut from notification into container event structure.
func ParsePut(params []stackitem.Item) (event.Event, error) {
@ -53,15 +51,10 @@ func ParsePut(params []stackitem.Item) (event.Event, error) {
}
// parse public key
key, err := client.BytesFromStackItem(params[2])
ev.publicKey, err = client.BytesFromStackItem(params[2])
if err != nil {
return nil, fmt.Errorf("could not get public key: %w", err)
}
ev.publicKey, err = keys.NewPublicKeyFromBytes(key, elliptic.P256())
if err != nil {
return nil, fmt.Errorf("could not parse public key: %w", err)
}
return ev, nil
}