realloc/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Releases Packages Activity

[#839] service/object: Do not use request forwarding when assembling object

Browse source 
Forwarding mechanism resends original request. During split object chain traversal,
storage node performs multiple `object.Head` requests on each child. If request
forwarding happens, then `object.Head` returns object ID of the original request.
This produces infinite assembly loop.

Signed-off-by: Alex Vanin <alexey@nspcc.ru>
This commit is contained in:
Alex Vanin 2021-09-22 17:04:45 +03:00 • committed by Alex Vanin
parent 057d3ac06b
commit b3464e8140
3 changed files with 6 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
pkg/services/object/get/assemble.go
View file

@ -12,7 +12,11 @@ func (exec *execCtx) assemble() {
return
}
exec.assembling = true
// do not use forwarding during assembly stage
// assembly flag is not inherited in produced
// `execCtx`, however `commonPrm` does, so it
// makes sense to nil it there
exec.prm.SetRequestForwarder(nil)
exec.log.Debug("trying to assemble the object...")