[#217] Refactor system objects

Moved into a separate file
getSystemObject renamed to headSystemObject, implemented getSystemObject
for system objects with payload
Refactor putSystemObjects
Moved systemCacheKey from data system_object

Signed-off-by: Angira Kekteeva <kira@nspcc.ru>

api/layer/system_object.go

@@ -0,0 +1,190 @@
+package layer
+
+import (
+	"bytes"
+	"context"
+	"strconv"
+	"time"
+
+	"github.com/nspcc-dev/neofs-api-go/pkg/client"
+	"github.com/nspcc-dev/neofs-api-go/pkg/object"
+	"github.com/nspcc-dev/neofs-s3-gw/api/data"
+	"github.com/nspcc-dev/neofs-s3-gw/api/errors"
+	"go.uber.org/zap"
+)
+
+func (n *layer) putSystemObject(ctx context.Context, p *PutSystemObjectParams) (*object.Object, error) {
+	versions, err := n.headSystemVersions(ctx, p.BktInfo, p.ObjName)
+	if err != nil && !errors.IsS3Error(err, errors.ErrNoSuchKey) {
+		return nil, err
+	}
+	idsToDeleteArr := updateCRDT2PSetHeaders(p.Metadata, versions, false) // false means "last write wins"
+
+	attributes := make([]*object.Attribute, 0, 3)
+
+	filename := object.NewAttribute()
+	filename.SetKey(objectSystemAttributeName)
+	filename.SetValue(p.ObjName)
+
+	createdAt := object.NewAttribute()
+	createdAt.SetKey(object.AttributeTimestamp)
+	createdAt.SetValue(strconv.FormatInt(time.Now().UTC().Unix(), 10))
+
+	versioningIgnore := object.NewAttribute()
+	versioningIgnore.SetKey(attrVersionsIgnore)
+	versioningIgnore.SetValue(strconv.FormatBool(true))
+
+	attributes = append(attributes, filename, createdAt, versioningIgnore)
+
+	for k, v := range p.Metadata {
+		attr := object.NewAttribute()
+		attr.SetKey(p.Prefix + k)
+		if p.Prefix == tagPrefix && v == "" {
+			v = tagEmptyMark
+		}
+		attr.SetValue(v)
+		attributes = append(attributes, attr)
+	}
+
+	raw := object.NewRaw()
+	raw.SetOwnerID(p.BktInfo.Owner)
+	raw.SetContainerID(p.BktInfo.CID)
+	raw.SetAttributes(attributes...)
+
+	ops := new(client.PutObjectParams).WithObject(raw.Object()).WithPayloadReader(bytes.NewReader(p.Payload))
+	oid, err := n.pool.PutObject(ctx, ops, n.BearerOpt(ctx))
+	if err != nil {
+		return nil, err
+	}
+
+	meta, err := n.objectHead(ctx, p.BktInfo.CID, oid)
+	if err != nil {
+		return nil, err
+	}
+
+	if p.Payload != nil {
+		meta.ToV2().SetPayload(p.Payload)
+	}
+
+	if err = n.systemCache.Put(systemObjectKey(p.BktInfo, p.ObjName), meta); err != nil {
+		n.log.Error("couldn't cache system object", zap.Error(err))
+	}
+
+	for _, id := range idsToDeleteArr {
+		if err = n.objectDelete(ctx, p.BktInfo.CID, id); err != nil {
+			n.log.Warn("couldn't delete system object",
+				zap.Stringer("version id", id),
+				zap.String("name", p.ObjName),
+				zap.Error(err))
+		}
+	}
+
+	return meta, nil
+}
+
+func (n *layer) headSystemObject(ctx context.Context, bkt *data.BucketInfo, objName string) (*data.ObjectInfo, error) {
+	if meta := n.systemCache.Get(systemObjectKey(bkt, objName)); meta != nil {
+		return objInfoFromMeta(bkt, meta), nil
+	}
+
+	versions, err := n.headSystemVersions(ctx, bkt, objName)
+	if err != nil {
+		return nil, err
+	}
+
+	return versions.getLast(), nil
+}
+
+func (n *layer) getSystemObject(ctx context.Context, bktInfo *data.BucketInfo, objName string) (*object.Object, error) {
+	if meta := n.systemCache.Get(systemObjectKey(bktInfo, objName)); meta != nil {
+		return meta, nil
+	}
+
+	versions, err := n.headSystemVersions(ctx, bktInfo, objName)
+	if err != nil {
+		return nil, err
+	}
+
+	objInfo := versions.getLast()
+
+	buf := new(bytes.Buffer)
+	p := &getParams{
+		Writer: buf,
+		cid:    bktInfo.CID,
+		oid:    objInfo.ID,
+	}
+
+	obj, err := n.objectGet(ctx, p)
+	if err != nil {
+		return nil, err
+	}
+
+	obj.ToV2().SetPayload(buf.Bytes())
+
+	return obj, nil
+}
+
+func (n *layer) deleteSystemObject(ctx context.Context, bktInfo *data.BucketInfo, name string) error {
+	ids, err := n.objectSearch(ctx, &findParams{cid: bktInfo.CID, attr: objectSystemAttributeName, val: name})
+	if err != nil {
+		return err
+	}
+
+	for _, id := range ids {
+		if err = n.objectDelete(ctx, bktInfo.CID, id); err != nil {
+			return err
+		}
+	}
+
+	n.systemCache.Delete(systemObjectKey(bktInfo, name))
+	return nil
+}
+
+func (n *layer) headSystemVersions(ctx context.Context, bkt *data.BucketInfo, sysName string) (*objectVersions, error) {
+	ids, err := n.objectSearch(ctx, &findParams{cid: bkt.CID, attr: objectSystemAttributeName, val: sysName})
+	if err != nil {
+		return nil, err
+	}
+
+	// should be changed when system cache will store payload instead of meta
+	metas := make(map[string]*object.Object, len(ids))
+
+	versions := newObjectVersions(sysName)
+	for _, id := range ids {
+		meta, err := n.objectHead(ctx, bkt.CID, id)
+		if err != nil {
+			n.log.Warn("couldn't head object",
+				zap.Stringer("object id", id),
+				zap.Stringer("bucket id", bkt.CID),
+				zap.Error(err))
+			continue
+		}
+
+		if oi := objInfoFromMeta(bkt, meta); oi != nil {
+			if !isSystem(oi) {
+				continue
+			}
+			versions.appendVersion(oi)
+			metas[oi.Version()] = meta
+		}
+	}
+
+	lastVersion := versions.getLast()
+	if lastVersion == nil {
+		return nil, errors.GetAPIError(errors.ErrNoSuchKey)
+	}
+
+	if err = n.systemCache.Put(systemObjectKey(bkt, sysName), metas[lastVersion.Version()]); err != nil {
+		n.log.Warn("couldn't put system meta to objects cache",
+			zap.Stringer("object id", lastVersion.ID),
+			zap.Stringer("bucket id", bkt.CID),
+			zap.Error(err))
+	}
+
+	return versions, nil
+}
+
+// systemObjectKey is a key to use in SystemCache.
+func systemObjectKey(bktInfo *data.BucketInfo, obj string) string {
+	return bktInfo.Name + obj
+}