realloc/frostfs-sdk-go
1
0
Fork 0
forked from TrueCloudLab/frostfs-sdk-go
Code Issues Pull requests Projects Releases Packages Wiki Activity

[#243] eacl: Return success flag in CalculateAction

Browse source 
Signed-off-by: Evgenii Stratonikov <evgeniy@nspcc.ru>
This commit is contained in:
Evgenii Stratonikov 2022-05-18 14:46:28 +03:00 • committed by fyrchik
parent 031eac2f48
commit 5518b63432
2 changed files with 37 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

13
eacl/validator.go
View file

@ -21,8 +21,11 @@ func NewValidator() *Validator {
// The action is calculated according to the application of
// eACL table of rules to the request.
//
// If no matching table entry is found, ActionAllow is returned.
func (v *Validator) CalculateAction(unit *ValidationUnit) Action {
// Second return value is true iff the action was produced by a matching entry.
//
// If no matching table entry is found or some filters are missing,
// ActionAllow is returned and the second return value is false.
func (v *Validator) CalculateAction(unit *ValidationUnit) (Action, bool) {
for _, record := range unit.table.Records() {
// check type of operation
if record.Operation() != unit.op {
@ -38,13 +41,13 @@ func (v *Validator) CalculateAction(unit *ValidationUnit) Action {
switch val := matchFilters(unit.hdrSrc, record.Filters()); {
case val < 0:
// headers of some type could not be composed => allow
return ActionAllow
return ActionAllow, false
case val == 0:
return record.Action()
return record.Action(), true
}
}
return ActionAllow
return ActionAllow, false
}
// returns: