s.makhov/frostfs-node
1
0
Fork 0
forked from TrueCloudLab/frostfs-node
Code Pull requests Activity

[#1086] engine: Do not use metabase if shard looks bad

Browse source 
Signed-off-by: Dmitrii Stepanov <d.stepanov@yadro.com>
This commit is contained in:
Dmitrii Stepanov 2024-04-17 14:15:08 +03:00 committed by Evgenii Stratonikov
parent 9d73f9c2c6
commit 6a39c3d15e
2 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
pkg/local_object_storage/engine/head.go
View file

@ -84,6 +84,7 @@ func (e *StorageEngine) head(ctx context.Context, prm HeadPrm) (HeadRes, error)
shPrm.SetRaw(prm.raw) shPrm.SetRaw(prm.raw)
e.iterateOverSortedShards(prm.addr, func(_ int, sh hashedShard) (stop bool) { e.iterateOverSortedShards(prm.addr, func(_ int, sh hashedShard) (stop bool) {
shPrm.ShardLooksBad = sh.errorCount.Load() >= e.errorsThreshold
res, err := sh.Head(ctx, shPrm) res, err := sh.Head(ctx, shPrm)
if err != nil { if err != nil {
switch { switch {

4
pkg/local_object_storage/shard/head.go
View file

@ -15,6 +15,7 @@ import (
type HeadPrm struct { type HeadPrm struct {
addr oid.Address addr oid.Address
raw bool raw bool
ShardLooksBad bool
} }
// HeadRes groups the resulting values of Head operation. // HeadRes groups the resulting values of Head operation.
@ -59,7 +60,8 @@ func (s *Shard) Head(ctx context.Context, prm HeadPrm) (HeadRes, error) {
var obj *objectSDK.Object var obj *objectSDK.Object
var err error var err error
if s.GetMode().NoMetabase() { mode := s.GetMode()
if mode.NoMetabase() || (mode.ReadOnly() && prm.ShardLooksBad) {
var getPrm GetPrm var getPrm GetPrm
getPrm.SetAddress(prm.addr) getPrm.SetAddress(prm.addr)
getPrm.SetIgnoreMeta(true) getPrm.SetIgnoreMeta(true)