client: Disable service config query #342

Merged

fyrchik merged 1 commit from fyrchik/frostfs-sdk-go:disable-service-config into master

2025-03-06 09:24:17 +00:00

fyrchik commented

2025-03-05 12:08:39 +00:00

Owner

By default, gRPC fetches TXT report while resolving a domain.
0914bba6c5/internal/resolver/dns/dns_resolver.go (L336)

This leads to a hanging dial if DNS is unavailable, even though the host
may be specified in /etc/hosts (hello, localhost!).

Use grpc.WithDisableServiceConfig() to override the default.
This option seems impossible to override with WithGRPCDialOpts(),
but we do not use service config anyway.

Signed-off-by: Evgenii Stratonikov e.stratonikov@yadro.com

By default, gRPC fetches TXT report while resolving a domain. https://github.com/grpc/grpc-go/blob/0914bba6c5c5a545d34bd11e5dee0bbb8eaadd3f/internal/resolver/dns/dns_resolver.go#L336 This leads to a hanging dial if DNS is unavailable, even though the host may be specified in `/etc/hosts` (hello, localhost!). Use `grpc.WithDisableServiceConfig()` to override the default. This option seems impossible to override with `WithGRPCDialOpts()`, but we do not use service config anyway. Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

fyrchik added 1 commit 2025-03-05 12:08:39 +00:00

client: Disable service config query

DCO / DCO (pull_request) Failing after 30s

Details

Code generation / Generate proto (pull_request) Successful in 34s

Details

Tests and linters / Tests (pull_request) Successful in 44s

Details

Tests and linters / Lint (pull_request) Successful in 1m30s

Details

eea9678332

By default, gRPC fetches TXT report while resolving a domain.
This leads to a hanging dial if DNS is unavailable, even though the host
may be specified in `/etc/hosts` (hello, localhost!).

This setting seems impossible to override with `WithGRPCDialOpts()`,
but we do not use service config anyway.

Signed-off-by: Evgenii Stratonikov <e.stratonikov@yadro.com>

requested reviews from storage-core-committers, storage-core-developers, storage-services-committers, storage-services-developers

2025-03-05 12:08:39 +00:00

fyrchik force-pushed disable-service-config from eea9678332 to c909cf5f6f

2025-03-05 12:09:54 +00:00

Compare

fyrchik force-pushed disable-service-config from c909cf5f6f to 9a5910b841

2025-03-05 12:10:49 +00:00

Compare