TrueCloudLab/certificates
17
0
Fork 2
Code Issues 1 Pull requests 1 Releases Activity Actions

[#3] Add linters #5

Open
mbiryukova wants to merge 2 commits from mbiryukova/certificates:feature/add_linters into tcl/master
pull from: mbiryukova/certificates:feature/add_linters
merge into: TrueCloudLab:tcl/master
Conversation 2 Commits 2 Files changed 16 +228 -87
mbiryukova commented 2023-08-04 13:17:40 +00:00
Member
Copy link

Closes #3

Closes #3
mbiryukova force-pushed feature/add_linters from 91dc0da06a to 6e5c88ba2b 2023-08-07 12:58:01 +00:00 Compare
mbiryukova force-pushed feature/add_linters from 6e5c88ba2b to d7eb55708e 2023-08-07 13:35:48 +00:00 Compare
mbiryukova force-pushed feature/add_linters from d349e7ad98 to a11cf2986e 2023-08-08 12:17:26 +00:00 Compare
mbiryukova force-pushed feature/add_linters from a11cf2986e to 98a29e4396 2023-08-09 08:46:11 +00:00 Compare
fyrchik commented 2023-08-09 11:46:08 +00:00
Owner
Copy link

Hm, do we really want to change "not our code"? It can create problems if we want to rebase on a new version.

Hm, do we really want to change "not our code"? It can create problems if we want to rebase on a new version.
👍 1
mbiryukova commented 2023-08-09 12:55:04 +00:00
Author
Member
Copy link

Hm, do we really want to change "not our code"? It can create problems if we want to rebase on a new version.

If it's ok that tests fail with the current implementation I can leave them unchanged

> Hm, do we really want to change "not our code"? It can create problems if we want to rebase on a new version. If it's ok that tests fail with the current implementation I can leave them unchanged
Some checks failed
Tests and linters / Lint (pull_request) Failing after 4s
Details
Tests and linters / Tests (pull_request) Failing after 13s
Details
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature/add_linters:mbiryukova-feature/add_linters
git checkout mbiryukova-feature/add_linters
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
  
Infrastructure

Infrastructure, Automation, CI/CD or DevOps related stuff

  
blocked

The issue or PR is blocked by something

  
bug

Something is not working

  
config

Configuration format update or breaking change

  
discussion

Talking about something in order to reach a decision or to exchange ideas

  
documentation

Documentation related

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
go

Language features adoption

  
help wanted

Extra attention is needed

  
internal

   
invalid

Something is wrong

  
kludge

This is a kludge and we know it

  
observability

Related to metrics, tracing and logs

  
perfomance

Perfomance related

  
question

More information is needed

  
refactoring

Refactoring

  
wontfix

This won't be fixed

No labels
Infrastructure
blocked
bug
config
discussion
documentation
duplicate
enhancement
go
help wanted
internal
invalid
kludge
observability
perfomance
question
refactoring
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: TrueCloudLab/certificates#5
No description provided.
Delete branch "mbiryukova/certificates:feature/add_linters"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?